Message-ID: <sashiko-outbox-208903@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH net-next 01/12] dt-bindings: can: renesas,rcar-canfd:
 Document RZ/G3S SoC
Reply-To: sashiko-reviews@lists.linux.dev
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, "Oliver Hartkopp" <socketcan@hartkopp.net>, "Vincent
 Mailhol" <mailhol@kernel.org>, "Oleksij Rempel" <o.rempel@pengutronix.de>
In-Reply-To: <20261110115112.3807247-2-mkl@pengutronix.de>
References: <20261110115112.3807247-1-mkl@pengutronix.de>
 <20261110115112.3807247-2-mkl@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 11:51:31 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: can: renesas,rcar-canfd: unwieldy per-compatible
  conditionals
--

commit 5428d12c7ddcccf614fa8a3231cb0f54fd8f9de0
Author: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC

This commit adds the renesas,r9a08g045-canfd compatible string for the
Renesas RZ/G3S SoC and updates the conditional schema constraints for its
channel, reset, operating mode, and clock differences.

Link: https://patch.msgid.link/20260902141544.565763-2-claudiu.beznea+renes=
as@tuxon.dev

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd=
.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index b9d9dd7a79676..bbaaef8f4282e 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -185,8 +186,6 @@ required:
>    - clocks
>    - clock-names
>    - power-domains
> -  - assigned-clocks
> -  - assigned-clock-rates
>    - channel0
>    - channel1
> =20
> @@ -198,6 +197,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - renesas,r9a08g045-canfd
>                - renesas,rzg2l-canfd
>      then:
>        properties:
> @@ -266,6 +266,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - renesas,r9a08g045-canfd
>                - renesas,r9a09g077-canfd
>                - renesas,rcar-gen3-canfd
>                - renesas,rzg2l-canfd
> @@ -330,6 +331,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - renesas,r9a08g045-canfd
>                - renesas,r9a09g047-canfd
>                - renesas,rzg2l-canfd
>      then:
> @@ -350,6 +352,20 @@ allOf:
>        properties:
>          reset-names: false
> =20
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g045-canfd
> +    then:
> +      properties:
> +        renesas,no-can-fd: false
> +        renesas,fd-only: false
> +    else:
> +      required:
> +        - assigned-clocks
> +        - assigned-clock-rates
> +
>  unevaluatedProperties: false
> =20
>  examples:

[Severity: Low]
This isn't a bug, but adding renesas,r9a08g045-canfd requires touching
three separate if-then blocks in allOf and adding a 14th conditional block
with an else branch to move assigned-clocks and assigned-clock-rates out of
the top-level required list.  With allOf now spanning 14 per-compatible
conditional blocks to toggle interrupts, resets, channels, operating modes,
and clock properties across variants, would it be cleaner to split the
diverging variants into a separate binding schema document instead of
adding more conditionals here?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110115112.3807=
247-1-mkl@pengutronix.de?part=3D1