Message-ID: <sashiko-outbox-208909@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH net-next 07/12] can: rcar_canfd: Use DT clock names in
 the probe message
Reply-To: sashiko-reviews@lists.linux.dev
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, "Oliver Hartkopp" <socketcan@hartkopp.net>, "Vincent
 Mailhol" <mailhol@kernel.org>, "Oleksij Rempel" <o.rempel@pengutronix.de>
In-Reply-To: <20261110115112.3807247-8-mkl@pengutronix.de>
References: <20261110115112.3807247-1-mkl@pengutronix.de>
 <20261110115112.3807247-8-mkl@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 11:51:34 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] can: rcar_canfd: wrong DT clock name logged in
  rcar_canfd_probe()
--

commit 465506d0bf0262439ace49568aa154d5d5ff9172
Author: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

can: rcar_canfd: Use DT clock names in the probe message

This commit updates the probe log message in rcar_canfd_probe() to report
the DT binding clock names ("can_clk", "fck", or "canfd") for the selected
clock.

Link: https://patch.msgid.link/20261019121356.2421761-3-claudiu.beznea@kern=
el.org

> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rca=
r_canfd.c
> index bb2d03b75142a..4f5cdfa8211da 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -2312,7 +2312,7 @@ static int rcar_canfd_probe(struct platform_device =
*pdev)
> =20
>  	platform_set_drvdata(pdev, gpriv);
>  	dev_info(dev, "global operational state (%s clk, %s mode)\n",
> -		 gpriv->extclk ? "ext" : "canfd",
> +		 gpriv->extclk ? "can_clk" : (info->fcan_pclk ? "fck" : "canfd"),
>  		 gpriv->fdmode ? (gpriv->fd_only_mode ? "fd-only" : "fd") : "classical=
");

[Severity: Low]
Does checking gpriv->extclk here log "canfd" instead of "can_clk" on SoCs
using r9a09g047_hw_info (such as RZ/G3E, RZ/V2N, and RZ/V2H)?

Those SoCs define their fCAN clock under the DT name "can_clk", so
devm_clk_get_optional(dev, "can_clk") succeeds with a non-zero rate and
rcar_canfd_probe() sets:

drivers/net/can/rcar/rcar_canfd.c:rcar_canfd_probe() {
	...
	} else {
		fcan_freq =3D clk_get_rate(gpriv->can_clk);
		gpriv->extclk =3D gpriv->info->external_clk;
	}
}

Because r9a09g047_hw_info has both .external_clk =3D 0 and .fcan_pclk =3D 0,
gpriv->extclk is false even though the "can_clk" DT clock was selected,
causing dev_info() to report "canfd clk".

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110115112.3807=
247-1-mkl@pengutronix.de?part=3D7