Message-ID: <sashiko-outbox-208913@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH net-next 11/12] dt-bindings: can: renesas,rcar-canfd:
 Document RZ/G3L SoC
Reply-To: sashiko-reviews@lists.linux.dev
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, "Oliver Hartkopp" <socketcan@hartkopp.net>, "Vincent
 Mailhol" <mailhol@kernel.org>, "Oleksij Rempel" <o.rempel@pengutronix.de>
In-Reply-To: <20261110115112.3807247-12-mkl@pengutronix.de>
References: <20261110115112.3807247-1-mkl@pengutronix.de>
 <20261110115112.3807247-12-mkl@pengutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 11:51:35 +0000
Precedence: list

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: can: renesas,rcar-canfd: unwieldy per-compatible
  conditionals
--

commit b004ab68b21e93b39df6164d000c1b8ef430f90c
Author: Biju Das <biju.das.au@gmail.com>

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

This commit documents the Renesas RZ/G3L (R9A08G046) SoC in the
renesas,rcar-canfd device tree binding schema.

Link: https://patch.msgid.link/20261021-canfd_rzg3l-v6-3-b4abfdba8e70@bp.re=
nesas.com

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd=
.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 81674ea4bef47..dc74377021207 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -292,6 +293,27 @@ allOf:
>        patternProperties:
>          "^channel[6-7]$": false
> =20
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g046-canfd
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 11
> +          maxItems: 11
> +
> +        interrupt-names:
> +          minItems: 11
> +          maxItems: 11
> +
> +        resets:
> +          minItems: 2
> +
> +      patternProperties:
> +        "^channel[3-7]$": false
> +
>    - if:
>        properties:
>          compatible:
> @@ -332,6 +354,7 @@ allOf:
>            contains:
>              enum:
>                - renesas,r9a08g045-canfd
> +              - renesas,r9a08g046-canfd
>                - renesas,r9a09g047-canfd
>                - renesas,rzg2l-canfd
>      then:
> @@ -356,7 +379,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: renesas,r9a08g045-canfd
> +            enum:
> +              - renesas,r9a08g045-canfd
> +              - renesas,r9a08g046-canfd
>      then:
>        properties:
>          renesas,no-can-fd: false

[Severity: Low]
This isn't a bug, but allOf now has 15 if-then conditional blocks to handle
differences in interrupt counts, channel counts, resets, clocks, and CAN
modes across R-Car and RZ variants, with constraints for
renesas,r9a08g046-canfd split across three separate conditionals.  Would it
make sense to split the binding into separate schema documents instead of
adding more per-compatible conditionals to this file?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261110115112.3807=
247-1-mkl@pengutronix.de?part=3D11