Message-ID: <sashiko-outbox-209710@kernel.org>
From: sashiko-bot@kernel.org
Subject: Re: [PATCH V4 4/7] power: supply: rk817-charger: Resolve boot state
 of charge from coulomb counter
Reply-To: sashiko-reviews@lists.linux.dev
To: "Chris Morgan" <macroalpha82@gmail.com>
Cc: mfd@lists.linux.dev, lee@kernel.org
In-Reply-To: <20261111205627.56652-5-macroalpha82@gmail.com>
References: <20261111205627.56652-1-macroalpha82@gmail.com>
 <20261111205627.56652-5-macroalpha82@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 11 Nov 2026 21:30:32 +0000
Precedence: list

> From: Chris Morgan <macromorgan@hotmail.com>
>=20
> The boot state of charge comes from PWRON_VOL when OFF_CNT reads three
> or more and from the coulomb counter otherwise, and both fail in the
> field.
>=20
> PWRON_VOL is sampled at the power-on instant. A power-on caused by
> plugging in a charger samples under charge current: on an RG353M it
> read above the pack's maximum design voltage while the pack was at
> 74%. An RG DS was seen holding 2.63V in the register while running.
> Either becomes a wrong percentage on every boot that reaches it.
>=20
> A negative counter was clamped to zero and reported as 0%.
>=20
> The counter itself keeps counting while the system is off: the same
> [ ... ]
>=20
> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK81=
7")
> Co-developed-by: Jacob Cook <jacobmcook1984@gmail.com>
> Signed-off-by: Jacob Cook <jacobmcook1984@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

Sashiko has reviewed this patch and found no issues.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261111205627.5665=
2-1-macroalpha82@gmail.com?part=3D4