From: Jeremy Fitzhardinge Subject: [tip:x86/mm] x86/32: no need to use set_pte_present in set_pte_vaddr Date: Thu, 19 Mar 2009 13:27:28 GMT Message-ID: References: <1237406613-2929-1-git-send-email-jeremy@goop.org> Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, jeremy.fitzhardinge@citrix.com, xen-devel@lists.xensource.com, mingo@elte.hu Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1237406613-2929-1-git-send-email-jeremy@goop.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: linux-tip-commits@vger.kernel.org Cc: xen-devel@lists.xensource.com, jeremy.fitzhardinge@citrix.com, linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, tglx@linutronix.de, mingo@elte.hu List-Id: xen-devel@lists.xenproject.org Commit-ID: b40c757964bbad76ecfa88eda9eb0b4d76dd8b40 Gitweb: http://git.kernel.org/tip/b40c757964bbad76ecfa88eda9eb0b4d76dd8b40 Author: Jeremy Fitzhardinge AuthorDate: Wed, 18 Mar 2009 13:03:32 -0700 Committer: Ingo Molnar CommitDate: Thu, 19 Mar 2009 14:04:18 +0100 x86/32: no need to use set_pte_present in set_pte_vaddr Impact: cleanup, remove last user of set_pte_present set_pte_vaddr() is only used to install ptes in fixmaps, and should never be used to overwrite a present mapping. Signed-off-by: Jeremy Fitzhardinge Cc: Xen-devel LKML-Reference: <1237406613-2929-1-git-send-email-jeremy@goop.org> Signed-off-by: Ingo Molnar --- arch/x86/mm/pgtable_32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c index f2e477c..46c8834 100644 --- a/arch/x86/mm/pgtable_32.c +++ b/arch/x86/mm/pgtable_32.c @@ -50,7 +50,7 @@ void set_pte_vaddr(unsigned long vaddr, pte_t pteval) } pte = pte_offset_kernel(pmd, vaddr); if (pte_val(pteval)) - set_pte_present(&init_mm, vaddr, pte, pteval); + set_pte_at(&init_mm, vaddr, pte, pteval); else pte_clear(&init_mm, vaddr, pte);