From: Marcus Sundberg Subject: Re: [PATCH] MARK target doesn't allow to set highest bit Date: 04 Nov 2002 18:36:25 +0100 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: References: <20021102153816.O8635@sunbeam.de.gnumonks.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@lists.netfilter.org Return-path: To: Harald Welte In-Reply-To: <20021102153816.O8635@sunbeam.de.gnumonks.org> Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Harald Welte writes: > > libipt_MARK.c has been broken since iptables 1.2.7. This patch > > makes it work properly again: > > Broken in which way? Am I right you are talking about signed/unsigned > numbers and not being able to specify the upper half of the mark > range? Yes, exactly. It worked fine with the old code, but string_to_number() doesn't handle unsigned numbers. //Marcus -- ---------------------------------------+-------------------------- Marcus Sundberg | Firewalls with SIP & NAT Firewall Developer, Ingate Systems AB | http://www.ingate.com/