From: Marcus Sundberg Subject: [PATCH] MARK target doesn't allow to set highest bit Date: 31 Oct 2002 12:47:58 +0100 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: To: netfilter-devel@lists.netfilter.org Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org Hi, libipt_MARK.c has been broken since iptables 1.2.7. This patch makes it work properly again: diff -u -r1.8 -r1.6 --- extensions/libipt_MARK.c 6 Aug 2002 18:46:18 -0000 1.8 +++ extensions/libipt_MARK.c 29 May 2002 13:08:16 -0000 1.6 @@ -46,9 +46,10 @@ = (struct ipt_mark_target_info *)(*target)->data; switch (c) { + char *end; case '1': - if (string_to_number(optarg, 0, 0xffffffff, - (unsigned int *)&markinfo->mark)) + markinfo->mark = strtoul(optarg, &end, 0); + if (*end != '\0' || end == optarg) exit_error(PARAMETER_PROBLEM, "Bad MARK value `%s'", optarg); if (*flags) exit_error(PARAMETER_PROBLEM, //Marcus -- ---------------------------------------+-------------------------- Marcus Sundberg | Firewalls with SIP & NAT Firewall Developer, Ingate Systems AB | http://www.ingate.com/