Received: from eggs.gnu.org ([2001:4830:134:3::10]:40437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMCyp-00066h-Dh for qemu-devel@nongnu.org; Tue, 05 Dec 2017 08:09:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMCyo-0005Vq-DS for qemu-devel@nongnu.org; Tue, 05 Dec 2017 08:09:47 -0500 From: Alberto Garcia In-Reply-To: <20171120201004.14999-24-mreitz@redhat.com> References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-24-mreitz@redhat.com> Date: Tue, 05 Dec 2017 14:09:36 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 for-2.12 23/25] block: Fix FIXME from "Add BDS.backing_overridden" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow On Mon 20 Nov 2017 09:10:02 PM CET, Max Reitz wrote: > Said commit introduced a FIXME stating that bdrv_open_backing_file() > should set bs->backing_overridden to true not only if the file.filename > option was set, but if the "options" QDict contained any option that is > significant for any node in the BDS tree emerging from the backing BDS. > This behavior is implemented by this patch. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto