Received: from eggs.gnu.org ([2001:4830:134:3::10]:46145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLsFb-0005s8-7t for qemu-devel@nongnu.org; Mon, 04 Dec 2017 10:01:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLsFV-0002u8-Gy for qemu-devel@nongnu.org; Mon, 04 Dec 2017 10:01:43 -0500 From: Alberto Garcia In-Reply-To: <20171120201004.14999-15-mreitz@redhat.com> References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-15-mreitz@redhat.com> Date: Mon, 04 Dec 2017 16:01:21 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 for-2.12 14/25] block/nbd: Make bdrv_dirname() return NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow On Mon 20 Nov 2017 09:09:53 PM CET, Max Reitz wrote: > The generic bdrv_dirname() implementation would be able to generate some > form of directory name for many NBD nodes, but it would be always wrong. > Therefore, we have to explicitly make it an error (until NBD has some > form of specification for export paths, if it ever will). > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto