Received: from eggs.gnu.org ([2001:4830:134:3::10]:45108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMBfc-0004dN-0V for qemu-devel@nongnu.org; Tue, 05 Dec 2017 06:45:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMBfa-0004su-WE for qemu-devel@nongnu.org; Tue, 05 Dec 2017 06:45:52 -0500 From: Alberto Garcia In-Reply-To: <20171120201004.14999-25-mreitz@redhat.com> References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-25-mreitz@redhat.com> Date: Tue, 05 Dec 2017 12:45:41 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 for-2.12 24/25] block/curl: Implement bdrv_refresh_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow On Mon 20 Nov 2017 09:10:03 PM CET, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/curl.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/block/curl.c b/block/curl.c > index 11318a9a29..fe57223fda 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -957,6 +957,20 @@ static int64_t curl_getlength(BlockDriverState *bs) > return s->len; > } > > +static void curl_refresh_filename(BlockDriverState *bs) > +{ > + BDRVCURLState *s = bs->opaque; > + > + if (!s->sslverify || s->cookie || > + s->username || s->password || s->proxyusername || s->proxypassword) > + { > + return; > + } > + > + pstrcpy(bs->exact_filename, sizeof(bs->exact_filename), s->url); > +} Reviewed-by: Alberto Garcia Berto