Received: from eggs.gnu.org ([2001:4830:134:3::10]:49935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxBzc-0002cM-9B for qemu-devel@nongnu.org; Tue, 04 Sep 2018 10:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxBza-0003BI-FR for qemu-devel@nongnu.org; Tue, 04 Sep 2018 10:07:44 -0400 From: Alberto Garcia In-Reply-To: References: <20180809213528.14738-1-mreitz@redhat.com> <20180809213528.14738-6-mreitz@redhat.com> Date: Tue, 04 Sep 2018 16:07:35 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake On Wed 29 Aug 2018 11:44:52 AM CEST, Max Reitz wrote: > On 2018-08-28 15:26, Alberto Garcia wrote: >> On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote: >>> + backing_overridden = bdrv_backing_overridden(bs); >>> + >>> + if (bs->open_flags & BDRV_O_NO_IO) { >>> + /* Without I/O, the backing file does not change anything. >>> + * Therefore, in such a case (primarily qemu-img), we can >>> + * pretend the backing file has not been overridden even if >>> + * it technically has been. */ >>> + backing_overridden = false; >>> + } >> >> What is this for? > > qemu-img info opens files with BDRV_O_NO_BACKING. Without this check, > you'd get a json:{} filename with "backing": null. Ah, I see. Reviewed-by: Alberto Garcia Berto