Received: from eggs.gnu.org ([2001:4830:134:3::10]:50664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fudd6-0002jR-EL for qemu-devel@nongnu.org; Tue, 28 Aug 2018 09:02:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fudRb-00082S-A2 for qemu-devel@nongnu.org; Tue, 28 Aug 2018 08:50:04 -0400 From: Alberto Garcia In-Reply-To: <20180809213528.14738-19-mreitz@redhat.com> References: <20180809213528.14738-1-mreitz@redhat.com> <20180809213528.14738-19-mreitz@redhat.com> Date: Tue, 28 Aug 2018 14:49:58 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-3.1 v10 18/31] block/nfs: Implement bdrv_dirname() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake On Thu 09 Aug 2018 11:35:15 PM CEST, Max Reitz wrote: > While the basic idea is obvious and could be handled by the default > bdrv_dirname() implementation, we cannot generate a directory name if > the gid or uid are set, so we have to explicitly return NULL in those > cases. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto