Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBE7C11D05 for ; Thu, 20 Feb 2020 16:35:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BBBF206F4 for ; Thu, 20 Feb 2020 16:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="dcUWaMuY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BBBF206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4omy-0003CF-Kn for qemu-devel@archiver.kernel.org; Thu, 20 Feb 2020 11:35:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59202) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4omE-0002cY-JY for qemu-devel@nongnu.org; Thu, 20 Feb 2020 11:34:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4omD-0004hh-AL for qemu-devel@nongnu.org; Thu, 20 Feb 2020 11:34:14 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:34113) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4omC-0004hR-KL; Thu, 20 Feb 2020 11:34:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=31AvhHiJGEzu2O3SDn0PH/4JjnYUdOR+IpQUi9lWMs0=; b=dcUWaMuYuKeTwK95YBWgAepzjHuL8U3BPz1SgU9DWRpnmNAdTcswdXTRXxls8pMXmudj04p8Iqm2F83iZ6Uw5Hf8DOHIpaNVX9irRqtheIwj6AJaa0OVi1EkWWMJAAf//4Ad/D0AAjRmpwY0bkqb00Hn8/LwydkIU1s1DsqFJLkXJ74LQoaDOE2KpJ9NQBdaYFJ8ru/YVshxsLmv0xn/RPNEd2xa6+bhvOu6H1qQwN/1nMjhliIYmZ76fqQfoOWT+0x43qc3gQP9nRA6zyYicChfbjueT77HB9fIlvTg4bmB1s9j3SRprVOahGRrsrw+MvrjLxxV3S88yqM/LCDeuA==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1j4om7-0007mT-CM; Thu, 20 Feb 2020 17:34:07 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1j4om7-00044p-2b; Thu, 20 Feb 2020 17:34:07 +0100 From: Alberto Garcia To: Eric Blake , qemu-devel@nongnu.org Subject: Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State In-Reply-To: References: User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 20 Feb 2020 17:34:07 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Max Reitz , Vladimir Sementsov-Ogievskiy , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu 20 Feb 2020 04:28:07 PM CET, Eric Blake wrote: >> Images without subclusters are treated as if they had exactly one, >> with subcluster_size = cluster_size. > > The qcow2 spec changes earlier in the series made it sound like your > choices are exactly 1 or 32, >> +#define QCOW_MAX_SUBCLUSTERS_PER_CLUSTER 32 >> + > > ...but this name sounds like other values (2, 4, 8, 16) might be > possible? I guess I didn't want to call it QCOW_SUBCLUSTERS_PER_CLUSTER because there's already BDRVQcow2State.subclusters_per_cluster. And that one can have two possible values (1 and 32) so 32 would be the maximum. I get your point, however, and I'm open to suggestions. Berto