Received: from eggs.gnu.org ([2001:4830:134:3::10]:58941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eKpZ6-00041d-MD for qemu-devel@nongnu.org; Fri, 01 Dec 2017 12:57:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKpZ6-0004v3-1Z for qemu-devel@nongnu.org; Fri, 01 Dec 2017 12:57:32 -0500 From: Alberto Garcia In-Reply-To: <20171120201004.14999-5-mreitz@redhat.com> References: <20171120201004.14999-1-mreitz@redhat.com> <20171120201004.14999-5-mreitz@redhat.com> Date: Fri, 01 Dec 2017 16:33:23 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 for-2.12 04/25] iotests: Drop explicit base blockdev in 191 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake , John Snow On Mon 20 Nov 2017 09:09:43 PM CET, Max Reitz wrote: > Overriding the backing image should result in a json:{} pseudo-filename. > Then, you can no longer use the commit block job with filename > parameters. Therefore, do not explicitly add the base and override the > middle image in iotest 191, since we do not need to anyway. This will > allow us to continue to use the middle image's filename to identify it. > > In the long run, we want block-commit to accept node names for base and > top (just like block-stream does). > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto