Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FAFC04AAF for ; Thu, 16 May 2019 12:53:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DDEF20833 for ; Thu, 16 May 2019 12:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="YFaVAZfS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DDEF20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:54686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFtN-0004Sl-Ad for qemu-devel@archiver.kernel.org; Thu, 16 May 2019 08:53:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRFpI-0000k3-5F for qemu-devel@nongnu.org; Thu, 16 May 2019 08:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRFpF-0000gc-3b for qemu-devel@nongnu.org; Thu, 16 May 2019 08:49:36 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:51019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRFp8-0000E0-96; Thu, 16 May 2019 08:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=33JXPy6AyDdqngPoYdtqQGEwI/C6yjY5/PW0GvoB14A=; b=YFaVAZfStqhvCJ8e4NlFs1oDMtg5IEiO4/cg2xqUoWCnc0W/uIeiQQLDgIcmeR6BfUGsbQ7t6HqOcrMXT+erq9V4KkfHIg2UEn2mhABlbh2A1hX/MGcb2rk8aHPvnV7njJ0s63HS7SuVKg4w5iYjoStjzM09XH2vnPnic/l8lX81mlfBNLSL3KEQqWF/3DjMo3u7KSYwuHnKzCjJl6XgaKRcMr4fHEVe7gBsj2eZ7oky4OyedqmXhdXzQhNVj6M+pzkKCOUF0pZqMzW3LqJ5KkRo+mmG9tr9qi63BQlI9vIWMGhpKtom2aIjAh0jIUOFhgmm0LpvNMNHykDXyXXvZw==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1hRFom-0005wy-II; Thu, 16 May 2019 14:49:04 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1hRFom-00060s-Fe; Thu, 16 May 2019 14:49:04 +0200 From: Alberto Garcia To: Max Reitz , qemu-block@nongnu.org In-Reply-To: <20190515201503.19069-2-mreitz@redhat.com> References: <20190515201503.19069-1-mreitz@redhat.com> <20190515201503.19069-2-mreitz@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 16 May 2019 14:49:04 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: Re: [Qemu-devel] [PATCH 1/4] block: Improve "Block node is read-only" message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed 15 May 2019 10:15:00 PM CEST, Max Reitz wrote: > This message does not make any sense when it appears as the response to > making an R/W node read-only. We should detect that case and emit a > different message, then. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto