Received: from eggs.gnu.org ([2001:4830:134:3::10]:56033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxX96-0007Lo-8y for qemu-devel@nongnu.org; Wed, 05 Sep 2018 08:43:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxX94-0001oQ-6k for qemu-devel@nongnu.org; Wed, 05 Sep 2018 08:42:56 -0400 From: Alberto Garcia In-Reply-To: <20180809213528.14738-23-mreitz@redhat.com> References: <20180809213528.14738-1-mreitz@redhat.com> <20180809213528.14738-23-mreitz@redhat.com> Date: Wed, 05 Sep 2018 14:42:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-3.1 v10 22/31] block: Add BlockDriver.bdrv_gather_child_options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake On Thu 09 Aug 2018 11:35:19 PM CEST, Max Reitz wrote: > Some follow-up patches will rework the way bs->full_open_options is > refreshed in bdrv_refresh_filename(). The new implementation will remove > the need for the block drivers' bdrv_refresh_filename() implementations > to set bs->full_open_options; instead, it will be generic and use static > information from each block driver. > > However, by implementing bdrv_gather_child_options(), block drivers will > still be able to override the way the full_open_options of their > children are incorporated into their own. > > We need to implement this function for VMDK because we have to prevent > the generic implementation from gathering the options of all children: > It is not possible to specify options for the extents through the > runtime options. > > For quorum, the child names that would be used by the generic > implementation and the ones that we actually (currently) want to use > differ. See quorum_gather_child_options() for more information. > > Note that both of these are cases which are not ideal: In case of VMDK > it would probably be nice to be able to specify options for all extents. > In case of quorum, the current runtime option structure is simply broken > and needs to be fixed (but that is left for another patch). > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto