Received: from eggs.gnu.org ([209.51.188.92]:57449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1WCZ-0000xO-5u for qemu-devel@nongnu.org; Wed, 06 Mar 2019 08:03:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1WCY-00019E-B2 for qemu-devel@nongnu.org; Wed, 06 Mar 2019 08:03:15 -0500 From: Alberto Garcia In-Reply-To: <20190305182908.13557-1-eblake@redhat.com> References: <20190305182908.13557-1-eblake@redhat.com> Date: Wed, 06 Mar 2019 14:03:08 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] iotests: Wait for qemu to end in 223 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Max Reitz On Tue 05 Mar 2019 07:29:08 PM CET, Eric Blake wrote: > When iotest 223 was first written, it didn't matter if we waited for > the qemu process to clean up. But with the introduction of a later > qemu-nbd process trying to reuse the same file, there is a race where > even though the asynchronous qemu process has responded to "quit", it > has not yet had time to unlock the file and exit, resulting in: > > -[{ "start": 0, "length": 65536, "depth": 0, "zero": false, "data": false}, > -{ "start": 65536, "length": 2031616, "depth": 0, "zero": false, "data": true}, > -{ "start": 2097152, "length": 2097152, "depth": 0, "zero": false, "data": false}] > +qemu-nbd: Failed to blk_new_open 'tests/qemu-iotests/scratch/t.qcow2': Failed to get shared "write" lock > +Is another process using the image [tests/qemu-iotests/scratch/t.qcow2]? > +qemu-img: Could not open 'driver=nbd,server.type=unix,server.path=tests/qemu-iotests/scratch/qemu-nbd.sock,x-dirty-bitmap=qemu:dirty-bitmap:b': Failed to connect socket tests/qemu-iotests/scratch/qemu-nbd.sock: Connection refused > +./common.nbd: line 33: kill: (11122) - No such process > > Fixes: ddd09448 > Reported-by: Alberto Garcia > Signed-off-by: Eric Blake Tested-by: Alberto Garcia Berto