Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CB6C433B4 for ; Mon, 10 May 2021 15:33:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF51260FE4 for ; Mon, 10 May 2021 15:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF51260FE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg7ua-0004UY-3C for qemu-devel@archiver.kernel.org; Mon, 10 May 2021 11:33:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg7sF-0002xi-Le; Mon, 10 May 2021 11:31:12 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:56036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lg7sC-00059l-8X; Mon, 10 May 2021 11:31:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=ig8qZC3vTq2HVHNrArFudDc3eMKAnn1iOZ93IZLEDAc=; b=ABWgmHNIQJWFEh1jMNJtNtNB2PN+Mal9g7DKuqxeGo+rLfFHVV6l3eroJZo/4EU5PS3iB6BHnt+8PInOlRxyHy69OQMulfKM0o6abSwX62FAUYld6OotYjov3k6doBvTezYGO3cOzGd41vFEORcfm7FNERHWmA2DEAlGUBBKR8SJFtkImhMsaHMs0pT1N9Aln92qckZuIEPna8kFkQIjvSYr+qgP4DOJ+p2x/bPLFZOZBAubk7eJA+VzQQwUw41rw3qisenf/FyRvwJsFH+ue3mBOgmq/oX7j0YhCKZNZFGvFOC8Amnrt6gqcQTbFy0uBPpt50Wr39au9yLTjXFXbQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1lg7rn-0002To-Ce; Mon, 10 May 2021 17:30:43 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1lg7rn-0001AU-2z; Mon, 10 May 2021 17:30:43 +0200 From: Alberto Garcia To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Subject: Re: [PATCH v2 3/5] block: improve bdrv_child_get_parent_desc() In-Reply-To: <20210504094510.25032-4-vsementsov@virtuozzo.com> References: <20210504094510.25032-1-vsementsov@virtuozzo.com> <20210504094510.25032-4-vsementsov@virtuozzo.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Mon, 10 May 2021 17:30:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 04 May 2021 11:45:08 AM CEST, Vladimir Sementsov-Ogievskiy wrote: > We have different types of parents: block nodes, block backends and > jobs. So, it makes sense to specify type together with name. > > Next, this handler us used to compose an error message about permission > conflict. And permission conflict occurs in a specific place of block > graph. We shouldn't report name of parent device (as it refers another > place in block graph), but exactly and only the name of the node. So, > use bdrv_get_node_name() directly. > > iotest 283 output is updated. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto