Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE311C432C0 for ; Tue, 26 Nov 2019 13:46:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB59C206BF for ; Tue, 26 Nov 2019 13:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="NvkT7e/9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB59C206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZbAh-00057E-Pl for qemu-devel@archiver.kernel.org; Tue, 26 Nov 2019 08:46:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZb9C-0004Dw-H3 for qemu-devel@nongnu.org; Tue, 26 Nov 2019 08:44:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZb9B-0003LF-J1 for qemu-devel@nongnu.org; Tue, 26 Nov 2019 08:44:54 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:53498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZb98-0003J9-PR; Tue, 26 Nov 2019 08:44:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=fAQSXDaN6kiLwvE/abKUnzEEPj+5HNzdoOPjo89ed3E=; b=NvkT7e/96Ut8G20h9qLLPJtq2qE+KRHc/VfZwKKxxCnthtmOVjk+ktpmfb3scLM/V6i/Fs0i0jmuvl2PcJQZP/nCR0f/GA0OomGNjWJ6OXZrU6xky+lqn8aTulZ4MdllHP3q4qn8lt+YMii+QZZqPUp74ereVgA5Um5DFVWy4JQIcyp0foFR4qGL2fnuYaja6Zgw3m+IQgrnQgBT1/rqC33MGumOvlzfE+n/+L4rE5y87U/yrTnWjD5H33cUX6GEMvOrMig7CmxMtRXCSMAavI2+7blj3fCwvF/KB/Ob8TibhHPlWY1q/3GELyOn42ds5YvMvHznbQ+XQPIwlKS/Lw==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1iZb95-00066J-Fs; Tue, 26 Nov 2019 14:44:47 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1iZb95-00054Q-DJ; Tue, 26 Nov 2019 14:44:47 +0100 From: Alberto Garcia To: Kevin Wolf , qemu-block@nongnu.org Subject: Re: [PATCH] blockjob: Fix error message for negative speed In-Reply-To: <20191126134222.16340-1-kwolf@redhat.com> References: <20191126134222.16340-1-kwolf@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 26 Nov 2019 14:44:47 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 26 Nov 2019 02:42:22 PM CET, Kevin Wolf wrote: > The error message for a negative speed uses QERR_INVALID_PARAMETER, > which implies that the 'speed' option doesn't even exist: > > {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} > > Make it use QERR_INVALID_PARAMETER_VALUE instead: > > {"error": {"class": "GenericError", "desc": "Parameter 'speed' expects a non-negative value"}} > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto