Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E859C43603 for ; Fri, 6 Dec 2019 16:32:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04C0420659 for ; Fri, 6 Dec 2019 16:32:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="r19YYB6D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04C0420659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idGWt-0002F4-Ly for qemu-devel@archiver.kernel.org; Fri, 06 Dec 2019 11:32:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38357) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idEzq-0001oH-Sc for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:54:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idEzp-0007Ow-Su for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:54:18 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:56259) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idEzp-0007NA-J5; Fri, 06 Dec 2019 09:54:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=Cxo/MHtH+nFMkb9v7RPW8Cgb4/W84HHMGrjuXZaT/+s=; b=r19YYB6DbMsyfNioVIrTGiabn6B16pcLX/oIVMG5NLBoIKo1eq/dHjUXTV6KgipZAkyBR8JYCiblEOPanv6LCarK20K+a5z9Dz81wYT65mPxXlWX4e17bR0rofW94fF3Cg49k7UCNW5rYUQGnHBa2qCB0wnVM+eKGXNRmQ2Pd5z1HNIBo3xK/yn36AmCZ797ANMRFDM0dQs5qbXLzzMc8t4m9NmvSdLLqLiJd5SPOw6XwJ86B68WaMshAJKT4p4of0lx5+yy+vsPRLPAQ4zVsUWxALgvkyAPbuCuhBjtl3xAu1sSuvxShBuQ5haz1SopImC+qmQAa4bphS01jic4pQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1idB4F-0006WL-NG; Fri, 06 Dec 2019 11:42:35 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1idB4F-0005qy-Kc; Fri, 06 Dec 2019 11:42:35 +0100 From: Alberto Garcia To: Stefan Hajnoczi , qemu-devel@nongnu.org Subject: Re: [PATCH] qemu-img: fix info --backing-chain --image-opts In-Reply-To: <20191205134646.445427-1-stefanha@redhat.com> References: <20191205134646.445427-1-stefanha@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Fri, 06 Dec 2019 11:42:35 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu 05 Dec 2019 02:46:46 PM CET, Stefan Hajnoczi wrote: > Only apply --image-opts to the topmost image when listing an entire > backing chain. It is incorrect to treat backing filenames as image > options. Assuming we have the backing chain t.IMGFMT.base <- > t.IMGFMT.mid <- t.IMGFMT, qemu-img info fails as follows: > > $ qemu-img info --backing-chain --image-opts \ > driver=qcow2,file.driver=file,file.filename=t.IMGFMT > qemu-img: Could not open 'TEST_DIR/t.IMGFMT.mid': Cannot find device=TEST_DIR/t.IMGFMT.mid nor node_name=TEST_DIR/t.IMGFMT.mid > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Berto