Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB4D5C352A3 for ; Tue, 11 Feb 2020 15:32:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8A342082F for ; Tue, 11 Feb 2020 15:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="XF+HzvP6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8A342082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1XWN-0001dg-TB for qemu-devel@archiver.kernel.org; Tue, 11 Feb 2020 10:32:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44106) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1XVP-0000Vy-Bf for qemu-devel@nongnu.org; Tue, 11 Feb 2020 10:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1XVO-0002J6-7B for qemu-devel@nongnu.org; Tue, 11 Feb 2020 10:31:19 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:54758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1XVI-0002Go-Mc; Tue, 11 Feb 2020 10:31:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=5KfZY/ifPyqYz/JAEA9s9mZTVkrxYVECExQ/jYW26Bw=; b=XF+HzvP6SPrZlD/5dqQtZc4Gp2SIbT7sYcAhDRRX2Kd2/ZeK7eRxJKaBxzPGRwCBOXubZKs4s1fktWjgzNIXYtLq7GcXgY4MLOscXqDLYaGh4QZML+OzThCCSwvbadfdgvhtt6uBJ9LaUcv1RtyX45GJWZLdhuysGKJSII41sW5TrNC3tcYE+Fw6U5cIQecznOwtS8w0EZ8B28LqgikNwNi9F1Q9k7of34oDzUPVPmmDuqH5cwmRvaCYUk9IqQSNJ/eDur4koS7MEDP1ODDxbWzAXwiH96A1Q1QPzdIRlMlXoP5BCcIslW68qfeYSSPEOCRfl4VdY0WE9WMmECZZRg==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1j1XVG-0006KV-Qk; Tue, 11 Feb 2020 16:31:10 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1j1XVG-0008Pb-Gq; Tue, 11 Feb 2020 16:31:10 +0100 From: Alberto Garcia To: Max Reitz , qemu-block@nongnu.org Subject: Re: [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass In-Reply-To: <20200204170848.614480-3-mreitz@redhat.com> References: <20200204170848.614480-1-mreitz@redhat.com> <20200204170848.614480-3-mreitz@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 11 Feb 2020 16:31:10 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 04 Feb 2020 06:08:17 PM CET, Max Reitz wrote: > This structure nearly only contains parent callbacks for child state > changes. It cannot really reflect a child's role, because different > roles may overlap (as we will see when real roles are introduced), and > because parents can have custom callbacks even when the child fulfills a > standard role. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto