Received: from eggs.gnu.org ([2001:4830:134:3::10]:57514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHYgC-0002xk-0m for qemu-devel@nongnu.org; Thu, 15 Dec 2016 11:14:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHYgB-0004cB-4t for qemu-devel@nongnu.org; Thu, 15 Dec 2016 11:14:48 -0500 From: Alberto Garcia In-Reply-To: <20161130011851.24696-2-mreitz@redhat.com> References: <20161130011851.24696-1-mreitz@redhat.com> <20161130011851.24696-2-mreitz@redhat.com> Date: Thu, 15 Dec 2016 17:14:01 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 01/25] block/mirror: Small absolute-paths simplification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake On Wed 30 Nov 2016 02:18:27 AM CET, Max Reitz wrote: > When invoking drive-mirror in absolute-paths mode, the target's backing > BDS is assigned to it in mirror_complete(). The current logic only does > so if the target does not have that backing BDS already; but it actually > cannot have a backing BDS at all (the BDS is opened with O_NO_BACKING in > qmp_drive_mirror()), so just assert that and assign the new backing BDS > unconditionally. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto