Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kjisY-00015h-Dg for mharc-qemu-trivial@gnu.org; Mon, 30 Nov 2020 08:06:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjisM-00014R-B8; Mon, 30 Nov 2020 08:05:58 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:40625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjisI-0005ha-Km; Mon, 30 Nov 2020 08:05:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=2ii3zZD7jNqWhPp8HQg62f2Ag3MydWhRj+hhn/NZOEQ=; b=Vz1X5GqgV4/SN9rJvVAkNErDlGUpztLGFGMnPn8QidxL2licfzezrp9fBksXy03s9Naokeg7IOVe4vnRNms3fRJGl7eo4eY2UFld+r3egLMrprCtejcrOT4Fr+lwZAMbDWlkERnHZxa17sLoPWwF7DtcbgL2Mp3zGQz4r22yKDqzVTrJpQGtmbJyc24ji0vqAQYPoj5095TPPDecrC+brZpiVqdI+RYrsORgmWAK3OAGchdRxxEOUZlks3y5O4iqRIQVEyTB/f+WK71x/qJXrHc/l+ZKgzeUjjoARbivHKAoDWCcxY4E+1maINiT6si5P4OIkdsxAXl+mhapZWMfhQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1kjirn-0004XZ-KC; Mon, 30 Nov 2020 14:05:19 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1kjirn-0001XU-Ax; Mon, 30 Nov 2020 14:05:19 +0100 From: Alberto Garcia To: Alex Chen , eblake@redhat.com Cc: alex.chen@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org, zhang.zhanghailiang@huawei.com Subject: Re: [PATCH] qemu-nbd: Fix a memleak in qemu_nbd_client_list() In-Reply-To: <20201130123651.17543-1-alex.chen@huawei.com> References: <20201130123651.17543-1-alex.chen@huawei.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Mon, 30 Nov 2020 14:05:19 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 13:06:01 -0000 On Mon 30 Nov 2020 01:36:51 PM CET, Alex Chen wrote: > When the qio_channel_socket_connect_sync() fails > we should goto 'out' label to free the 'sioc' instead of return. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Reviewed-by: Alberto Garcia Berto