Received: from eggs.gnu.org ([2001:4830:134:3::10]:57626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fufDI-0003U8-Jv for qemu-devel@nongnu.org; Tue, 28 Aug 2018 10:43:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fufDH-00070m-P1 for qemu-devel@nongnu.org; Tue, 28 Aug 2018 10:43:24 -0400 From: Alberto Garcia In-Reply-To: <20180809213528.14738-22-mreitz@redhat.com> References: <20180809213528.14738-1-mreitz@redhat.com> <20180809213528.14738-22-mreitz@redhat.com> Date: Tue, 28 Aug 2018 16:43:11 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-3.1 v10 21/31] block: Add strong_runtime_opts to BlockDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Eric Blake On Thu 09 Aug 2018 11:35:18 PM CEST, Max Reitz wrote: > This new field can be set by block drivers to list the runtime options > they accept that may influence the contents of the respective BDS. As of > a follow-up patch, this list will be used by the common > bdrv_refresh_filename() implementation to decide which options to put > into BDS.full_open_options (and consequently whether a JSON filename has > to be created), thus freeing the drivers of having to implement that > logic themselves. > > Additionally, this patch adds the field to all of the block drivers that > need it and sets it accordingly. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto