Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2704C4361B for ; Tue, 8 Dec 2020 15:34:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F251B23A7A for ; Tue, 8 Dec 2020 15:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F251B23A7A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmf0K-0002lQ-4Q for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 10:34:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmesi-0005IZ-B0; Tue, 08 Dec 2020 10:26:24 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:50336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmesf-0003bF-H7; Tue, 08 Dec 2020 10:26:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=WbB/t7yNTCMJ/KYWc6un/XKVwB37sZxv4elkjQT+Hs8=; b=TGYjC9+vL+DMFMM2ovqIsF0AMZ0P3up31DuADWryKpkkcely0d7gYvIkZaENMYe4mXmNEy9YITh1Q4XRfpydWeO4EBtlx9Mde0UEhV5t9FTLYDtME12kOEADcBt1VNlzotsLyrDob3DEbeuitHQhOSKyTLzZfUgSpDnTwIvIsC1QC7c4z3knANk3isJl+MP7XNWydPZozzV9/Mm4g/YHgCBOtvinWJRB72xy0uAYXZwhpWsrTXP01Le8wAQJqArX1KXjbarUGv1z1faSi6yuD97a1AP9FfYC9wxph1e0RS32QoID2d+mjVayc8a8WJXGF47eyhETyXFc02Ki6VlSZQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1kmesc-0001Ut-QG; Tue, 08 Dec 2020 16:26:18 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1kmesc-00025i-FR; Tue, 08 Dec 2020 16:26:18 +0100 From: Alberto Garcia To: Maxim Levitsky , qemu-devel@nongnu.org Subject: Re: [PATCH v3 2/2] block: qcow2: remove the created file on initialization error In-Reply-To: <20201208142159.492489-3-mlevitsk@redhat.com> References: <20201208142159.492489-1-mlevitsk@redhat.com> <20201208142159.492489-3-mlevitsk@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 08 Dec 2020 16:26:18 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 08 Dec 2020 03:21:59 PM CET, Maxim Levitsky wrote: > If the qcow initialization fails, we should remove the file if it was > already created, to avoid leaving stale files around. > > We already do this for luks raw images. > > Signed-off-by: Maxim Levitsky Reviewed-by: Alberto Garcia > ret = qcow2_co_create(create_options, errp); > if (ret < 0) { > + > + Error *local_delete_err = NULL; Why that empty line though? Berto