Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475E744C506 for ; Tue, 28 Jul 2026 20:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785270341; cv=none; b=pu7DbuKJjsnsolRIN4qQiO64qwmz4EnffgtfViZkwr4U2KGYl4mc5b/JCVZxkU9CSHHVOaIgtDmKL0UVqCik/yU8hOOcJpi/I66K9S2lDw1a95vrKk0Hi6yq7TfwRei759V2JllqumbYn6jqQcnkFndUYNg2WVEDuaEDlXHBFOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785270341; c=relaxed/simple; bh=p6zmJ1zu1+RL0MiiP/4UYl0hFtaw1+qbOgAeR31gc6k=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=j40VoIq7mcOpTpCflLM4lvaDf042ROdf7o2T4h9XS4hVUMRTcIKrGWr3f9N+4x9nOYvyZJJB+5/nk2q3usgNNRggaHptYGLtqh+kXeesYPbbIx6llLePlzP6s1NNHXFNQ4OsDfOVb3KysCui/XmiqrsAe/n1ID+m+ckW5lFWDKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jl5cX33H; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jl5cX33H" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-81ecf499af9so4446527b3.1 for ; Tue, 28 Jul 2026 13:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785270338; x=1785875138; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=jztAXRFwasloX8cNXV5kk0XS+9iLdyAy7im/Gre2hoU=; b=Jl5cX33HPIHdwPxeSrlFpNXrxsNgYz9smxmaBL70xWjjgT+yNd13O/FmTTPRayc4Gh IrVhViUliKny4KCIJxdapXA+Mewh0HorQsvWzvZ1jCtTkcOrjITPIh71olVdAuwJEUtm 8q/RNjtXVP8yPH1U8SX21RBMNm7Px8Vkfw2eQHkvIW9521nhFbrLLcm17CAePvdslIyj 0eIjpCZpKHogjiwq81zUx7qBPQJ3EHIN3C+OTR2K+XZd8XnONtNCA28hWSnCbUtfuP97 RPgk3IjSM+UBOlVuobIWzEBDp+QWziluWTr9iXiT6gnNY6rze304vfoD8E1LTQ56P8Wj vlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785270338; x=1785875138; h=content-transfer-encoding:content-type:mime-version:subject :references:in-reply-to:message-id:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jztAXRFwasloX8cNXV5kk0XS+9iLdyAy7im/Gre2hoU=; b=Z/iyk1tS8+iV5RB4fj6mlVLfZtpYTB3hS5X15zwLnykT5bMhy08VxWLECN8Seyh0j+ ic4MCkg6Cb56HlKqMlTfPg70Xi9I39J6ELyyEPivh5X6R76brKoFuhXa8vb3twy1sFNl NrnfmJopXvbzyLjDHX4sHWH4kSafRjayx3lOwToHRvKp0OlRhEAy2F1NUjYYd5vHOtW6 Kol9emtiaVT0l5jkt2mY9y7l8R1YzWtH7Yy2tCsPq9svUTqn4AuVZh5PfiTaKwTICvG+ QjEQcwSOOQmReCrSW7S+JtTTyLpbr9J3ZSrpExA/q3a+8xOi2g3DcM9YPlpPZJUms19N 7hFA== X-Forwarded-Encrypted: i=1; AHgh+RqKv60rGMtzrdPqE/kjysHMhWaE8x206HziQz+JLioT+41/MU1I1MouAEDfNRxaJFOzmcRIpmk=@vger.kernel.org X-Gm-Message-State: AOJu0YzHLyDb4IgTSO7xAS5tsVvRSoygk17JRUNOz4HXO+8ZKSXytKv+ sz960W+AteLQmZJcgIbXGIezjnov+lanNGQlbAOor/oQitUGiXkyhTap X-Gm-Gg: AR+sD11KnzdG06qrNLsUN9YKD6avfN00teh6P9fLKGDhu5hOhVAB8bNweHZZIDdy6Bt 5oQAs34l3oJo7KICQfjo71gNlO9SYrbXSISVbuI0C7hCP1L6/O5j/8W+GHpcvMiDuBEllJVogOX mLbTGUw5vuU6EseqG5NxwuB82H60fmD4qTLu203oW3BA0R++ZE1AwpUjzP/XmjKr/a9+JguDL4X HTsOHCdrSBivbMRepe/PFtoyr9wFv8hUIAsWV/YK6hIPf+XbdrFU/MuYv39ahIu4nUBdhlxgfjw QTVIc5uEPoW5vMflFaESrL/3/PyzqjZ1sH/SGJTCC9EZtdAPBuN2DFE6m1fXejFELaWIgO3Ou9U znLEaF/iL/vzHLknnS87iBiCf47E9Kicqr1WfCOfGYiqRyNGNpjat1LJ3Y2zE8y0Q3N1aUEOUn+ Z3kFJUf7X4OWizGA8J6K+GMpBXsSZnWTNUMjW1B4g1Kj0hf0aOiA== X-Received: by 2002:a05:690c:a8f:b0:80c:85e5:8732 with SMTP id 00721157ae682-81f992e339fmr18401707b3.64.1785270338266; Tue, 28 Jul 2026 13:25:38 -0700 (PDT) Received: from gmail.com (250.4.48.34.bc.googleusercontent.com. [34.48.4.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fa25ed2bbsm5648227b3.0.2026.07.28.13.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 13:25:37 -0700 (PDT) Date: Tue, 28 Jul 2026 16:25:36 -0400 From: Willem de Bruijn To: Qihang , netdev@vger.kernel.org Cc: willemdebruijn.kernel@gmail.com, daniel.zahka@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, stable@vger.kernel.org, Qihang Message-ID: In-Reply-To: <20260728031345.49562-2-q.h.hack.winter@gmail.com> References: <20260726092110.80185-1-q.h.hack.winter@gmail.com> <20260728031345.49562-1-q.h.hack.winter@gmail.com> <20260728031345.49562-2-q.h.hack.winter@gmail.com> Subject: Re: [PATCH net v3 1/2] packet: use consistent hard_header_len in non-ring send paths Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Qihang wrote: > packet_snd() reads dev->hard_header_len multiple times while allocating > and constructing an skb. Device reconfiguration can change this value > concurrently, for example through bonding device type changes. > > For SOCK_RAW, packet_snd() can save a larger value in reserve and later > allocate headroom using a smaller value. Moving skb->data back by reserve > then places it before skb->head, and the following copy from userspace can > attempt an out-of-bounds write. > > packet_sendmsg_spkt() has the same issue because it calculates its > reservation and header offset from separate reads before dropping the RCU > read lock to allocate the skb. > > Add LL_RESERVED_SPACE_EX() for callers that already saved a header length. > Read hard_header_len once in packet_snd() and use it for allocation and > construction. In packet_sendmsg_spkt(), preserve the allocation-time value > through the device lookup retry. > > The separate SOCK_DGRAM consistency problem between hard_header_len and > header_ops->create is not addressed here. > > Fixes: b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation") > Cc: stable@vger.kernel.org > Signed-off-by: Qihang Reviewed-by: Willem de Bruijn New revisions should not be sent as a reply to an existing thread.