Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75283BE7C for ; Fri, 4 Aug 2023 17:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691170968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9EDDK0fsFu6bJUbqzLisveQC3+ZS4AciWFCHdUEAAo=; b=eHrG7xXtpD5d6lklPPBZNsFqEKXzB+nq2Phoyy7EgisaSHbe36987/nnYIhq9Dtdvi/Zfa DhpA06bgQwOE7Alg+NtEt/bCphQzXlhCkkwLZNB+VHoiXp6ze9xfuMxCa4rjAMRIr+zMTb llYHyI+eOtH6OezhHxWUv1+ian1Z2dQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404-UfLZNS_WOTicT1ZrRXkUdQ-1; Fri, 04 Aug 2023 13:42:46 -0400 X-MC-Unique: UfLZNS_WOTicT1ZrRXkUdQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5713F8022EF; Fri, 4 Aug 2023 17:42:46 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BB77492B03; Fri, 4 Aug 2023 17:42:46 +0000 (UTC) From: Jeff Moyer To: "Aneesh Kumar K.V" Cc: nvdimm@lists.linux.dev, dan.j.williams@intel.com, vishal.l.verma@intel.com Subject: Re: [PATCH 1/2] nvdimm/pfn_dev: Prevent the creation of zero-sized namespaces References: <20230804084934.171056-1-aneesh.kumar@linux.ibm.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 Date: Fri, 04 Aug 2023 13:48:35 -0400 In-Reply-To: <20230804084934.171056-1-aneesh.kumar@linux.ibm.com> (Aneesh Kumar K. V.'s message of "Fri, 4 Aug 2023 14:19:33 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Hi, Aneesh, "Aneesh Kumar K.V" writes: > On architectures that have different page size values used for kernel > direct mapping and userspace mappings, the user can end up creating zero-sized > namespaces as shown below > > :/sys/bus/nd/devices/region1# cat align > 0x1000000 > /sys/bus/nd/devices/region1# echo 0x200000 > align > /sys/bus/nd/devices/region1/dax1.0# cat supported_alignments > 65536 16777216 > $ ndctl create-namespace -r region1 -m devdax -s 18M --align 64K > { > "dev":"namespace1.0", > "mode":"devdax", > "map":"dev", > "size":0, > "uuid":"3094329a-0c66-4905-847e-357223e56ab0", > "daxregion":{ > "id":1, > "size":0, > "align":65536 > }, > "align":65536 > } > similarily for fsdax > > $ ndctl create-namespace -r region1 -m fsdax -s 18M --align 64K > { > "dev":"namespace1.0", > "mode":"fsdax", > "map":"dev", > "size":0, > "uuid":"45538a6f-dec7-405d-b1da-2a4075e06232", > "sector_size":512, > "align":65536, > "blockdev":"pmem1" > } Just curious, but have you seen this in practice? It seems like an odd thing to do. > In commit 9ffc1d19fc4a ("mm/memremap_pages: Introduce memremap_compat_align()") > memremap_compat_align was added to make sure the kernel always creates > namespaces with 16MB alignment. But the user can still override the > region alignment and no input validation is done in the region alignment > values to retain the flexibility user had before. However, the kernel > ensures that only part of the namespace that can be mapped via kernel > direct mapping page size is enabled. This is achieved by tracking the > unmapped part of the namespace in pfn_sb->end_trunc. The kernel also > ensures that the start address of the namespace is also aligned to the > kernel direct mapping page size. > > Depending on the user request, the kernel implements userspace mapping > alignment by updating pfn device alignment attribute and this value is > used to adjust the start address for userspace mappings. This is tracked > in pfn_sb->dataoff. Hence the available size for userspace mapping is: > > usermapping_size = size of the namespace - pfn_sb->end_trun - pfn_sb->dataoff > > If the kernel finds the user mapping size zero then don't allow the > creation of namespace. > > After fix: > $ ndctl create-namespace -f -r region1 -m devdax -s 18M --align 64K > libndctl: ndctl_dax_enable: dax1.1: failed to enable > Error: namespace1.2: failed to enable > > failed to create namespace: No such device or address > > And existing zero sized namespace will be marked disabled. > root@ltczz75-lp2:/home/kvaneesh# ndctl list -N -r region1 -i > [ > { > "dev":"namespace1.0", > "mode":"raw", > "size":18874368, > "uuid":"94a90fb0-8e78-4fb6-a759-ffc62f9fa181", > "sector_size":512, > "state":"disabled" > }, Thank you for providing examples of the command output before and after the change. I appreciate that. > > Signed-off-by: Aneesh Kumar K.V > --- > drivers/nvdimm/pfn_devs.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > index af7d9301520c..36b904a129b9 100644 > --- a/drivers/nvdimm/pfn_devs.c > +++ b/drivers/nvdimm/pfn_devs.c > @@ -453,7 +453,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig) > struct resource *res; > enum nd_pfn_mode mode; > struct nd_namespace_io *nsio; > - unsigned long align, start_pad; > + unsigned long align, start_pad, end_trunc; > struct nd_pfn_sb *pfn_sb = nd_pfn->pfn_sb; > struct nd_namespace_common *ndns = nd_pfn->ndns; > const uuid_t *parent_uuid = nd_dev_to_uuid(&ndns->dev); > @@ -503,6 +503,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig) > align = le32_to_cpu(pfn_sb->align); > offset = le64_to_cpu(pfn_sb->dataoff); > start_pad = le32_to_cpu(pfn_sb->start_pad); > + end_trunc = le32_to_cpu(pfn_sb->end_trunc); > if (align == 0) > align = 1UL << ilog2(offset); > mode = le32_to_cpu(pfn_sb->mode); > @@ -610,6 +611,10 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig) > return -EOPNOTSUPP; > } > > + if (offset >= (res->end - res->start + 1 - start_pad - end_trunc)) { ^^^^^^^^^^^^^^^^^^^^^^^^^ That's what resource_size(res) does. It might be better to create a local variable 'size' to hold that, as there are now two instances of that in the function. > + dev_err(&nd_pfn->dev, "bad offset with small namespace\n"); > + return -EOPNOTSUPP; > + } > return 0; > } > EXPORT_SYMBOL(nd_pfn_validate); > @@ -810,7 +815,8 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) > else > return -ENXIO; > > - if (offset >= size) { > + if (offset >= (size - end_trunc)) { > + /* This implies we result in zero size devices */ > dev_err(&nd_pfn->dev, "%s unable to satisfy requested alignment\n", > dev_name(&ndns->dev)); > return -ENXIO; Functionally, this looks good to me. Cheers, Jeff