Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D559C34031 for ; Tue, 18 Feb 2020 21:12:54 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA932176D for ; Tue, 18 Feb 2020 21:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WosBEEfE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DA932176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 8AA7510FC340D; Tue, 18 Feb 2020 13:13:46 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=jmoyer@redhat.com; receiver= Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DDA210FC340A for ; Tue, 18 Feb 2020 13:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582060371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcoEnVPH4YXfkwXGAc9vYSXk97yhitvx6mPN7wiSCI8=; b=WosBEEfEk5Y4Kf2IndcURATlS1hZMVkG3KM/F1ur4o2xl3+nwAShPH6p815tfWD7mvlfI7 11exARHhjQYLQIww+XBboFRQkm8rKcstMvogEnOPAHDdzqIiXIuovVzMCykzg/5p35dQFM A8h8njfAbwGWLG4ZugwrCcSefFdXU88= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-skP_IvATOTmlRhN0ERtlCg-1; Tue, 18 Feb 2020 16:12:49 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D2DD1005512; Tue, 18 Feb 2020 21:12:48 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E58625C1B0; Tue, 18 Feb 2020 21:12:44 +0000 (UTC) From: Jeff Moyer To: Yi Zhang Subject: Re: [PATCH ndctl] ndctl, test: add bus-id parameter for start-scrub/wait-scrub operation References: <20191218025145.26741-1-yi.zhang@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 Date: Tue, 18 Feb 2020 16:12:44 -0500 In-Reply-To: <20191218025145.26741-1-yi.zhang@redhat.com> (Yi Zhang's message of "Wed, 18 Dec 2019 10:51:45 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: skP_IvATOTmlRhN0ERtlCg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: TFNNMWEGYHODGBTUZFJCE2Q3EUFGPFW2 X-Message-ID-Hash: TFNNMWEGYHODGBTUZFJCE2Q3EUFGPFW2 X-MailFrom: jmoyer@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-nvdimm@lists.01.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Yi Zhang writes: > On some NVDIMM servers, scrub operation will take long time to be finished > as it start on all nvdimm buses in the system, add the bus-id parameter to > do the scrub on the NFIT_TEST_BUS0 > > Signed-off-by: Yi Zhang Reviewed-by: Jeff Moyer > --- > test/btt-errors.sh | 4 ++-- > test/clear.sh | 2 +- > test/inject-error.sh | 2 +- > test/pfn-meta-errors.sh | 2 +- > test/pmem-errors.sh | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/btt-errors.sh b/test/btt-errors.sh > index cb35865..00c0796 100755 > --- a/test/btt-errors.sh > +++ b/test/btt-errors.sh > @@ -115,7 +115,7 @@ bb_inj=$((dataoff/512)) > > # inject badblocks for one page at the start of the file > $NDCTL inject-error --block="$bb_inj" --count=8 $dev > -$NDCTL start-scrub && $NDCTL wait-scrub > +$NDCTL start-scrub $NFIT_TEST_BUS0 && $NDCTL wait-scrub $NFIT_TEST_BUS0 > > force_raw 0 > mount -o nodelalloc "/dev/$blockdev" $MNT > @@ -149,7 +149,7 @@ map=$(hexdump -s 96 -n 4 "/dev/$raw_bdev" | head -1 | cut -d' ' -f2-) > map=$(tr -d ' ' <<< "0x${map#* }${map%% *}") > bb_inj=$((map/512)) > $NDCTL inject-error --block="$bb_inj" --count=1 $dev > -$NDCTL start-scrub && $NDCTL wait-scrub > +$NDCTL start-scrub $NFIT_TEST_BUS0 && $NDCTL wait-scrub $NFIT_TEST_BUS0 > force_raw 0 > > # make sure reading the first block of the namespace fails > diff --git a/test/clear.sh b/test/clear.sh > index 17d5bed..1bd12da 100755 > --- a/test/clear.sh > +++ b/test/clear.sh > @@ -41,7 +41,7 @@ err_sector="$(((size/512) / 2))" > err_count=8 > if ! read sector len < /sys/block/$blockdev/badblocks; then > $NDCTL inject-error --block="$err_sector" --count=$err_count $dev > - $NDCTL start-scrub && $NDCTL wait-scrub > + $NDCTL start-scrub $NFIT_TEST_BUS0 && $NDCTL wait-scrub $NFIT_TEST_BUS0 > fi > read sector len < /sys/block/$blockdev/badblocks > [ $((sector * 2)) -ne $((size /512)) ] && echo "fail: $LINENO" && exit 1 > diff --git a/test/inject-error.sh b/test/inject-error.sh > index 49e68b3..825bf18 100755 > --- a/test/inject-error.sh > +++ b/test/inject-error.sh > @@ -77,7 +77,7 @@ do_tests() > > # inject normally > $NDCTL inject-error --block=$err_block --count=$err_count $dev > - $NDCTL start-scrub && $NDCTL wait-scrub > + $NDCTL start-scrub $NFIT_TEST_BUS0 && $NDCTL wait-scrub $NFIT_TEST_BUS0 > check_status "$err_block" "$err_count" > if read -r sector len < /sys/block/$blockdev/badblocks; then > test "$sector" -eq "$err_block" > diff --git a/test/pfn-meta-errors.sh b/test/pfn-meta-errors.sh > index 2b57f19..14a15ae 100755 > --- a/test/pfn-meta-errors.sh > +++ b/test/pfn-meta-errors.sh > @@ -61,7 +61,7 @@ mblk="$((metaoff/512))" > # inject in the middle of the struct page area > bb_inj=$(((dblk - mblk)/2)) > $NDCTL inject-error --block="$bb_inj" --count=32 $dev > -$NDCTL start-scrub && $NDCTL wait-scrub > +$NDCTL start-scrub $NFIT_TEST_BUS0 && $NDCTL wait-scrub $NFIT_TEST_BUS0 > > # after probe from the enable-namespace, the error should've been cleared > force_raw 0 > diff --git a/test/pmem-errors.sh b/test/pmem-errors.sh > index 9553a3f..3d90508 100755 > --- a/test/pmem-errors.sh > +++ b/test/pmem-errors.sh > @@ -46,7 +46,7 @@ err_sector="$(((size/512) / 2))" > err_count=8 > if ! read sector len < /sys/block/$blockdev/badblocks; then > $NDCTL inject-error --block="$err_sector" --count=$err_count $dev > - $NDCTL start-scrub; $NDCTL wait-scrub > + $NDCTL start-scrub $NFIT_TEST_BUS0; $NDCTL wait-scrub $NFIT_TEST_BUS0 > fi > read sector len < /sys/block/$blockdev/badblocks > [ $((sector * 2)) -ne $((size /512)) ] && echo "fail: $LINENO" && false _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org