Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D59631FC19 for ; Fri, 24 Mar 2017 17:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbdCXRsM (ORCPT ); Fri, 24 Mar 2017 13:48:12 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:54607 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753866AbdCXRsG (ORCPT ); Fri, 24 Mar 2017 13:48:06 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B6C0475056; Fri, 24 Mar 2017 13:45:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=w2A7Fi/+D0uRGKzN9IUNMd3CQQ0=; b=sOOdsf 1QnOISagHUd++Ee6OHqV7bt6hVSYg16F7Sel8oTTlTnl+oHu79RR0GENiNghdL4P qamQPcJTN9eZpjz7kL5mrmDFuh/fqFUZQVbNcrjSU2hwlosjdf27sNVFlTHHWFJU t4bvEoYw/QcnOFQPGXNNqUOB5GvQE9HmU//tw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=xyARU6HiKWUhVnMY9eTU1f5MM9P/dcXo vYzS38+AiyEZSfJowmqJdwaHnty9j0uxJMqaeFoTHVNDOr404K/eKjOlN5nj2oCP GQP92DqMu1dpRyeVlif/NlN8fxHvHZyKehTv9wICgEVkyhrtsc7ivIat7wVUFPmJ qOSVEpxoapk= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 7B67375053; Fri, 24 Mar 2017 13:45:01 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 5FF7775052; Fri, 24 Mar 2017 13:45:00 -0400 (EDT) From: Junio C Hamano To: Jeff Hostetler Cc: git@vger.kernel.org, peff@peff.net, Jeff Hostetler Subject: Re: [PATCH v2 0/7] thread lazy_init_name_hash References: <1490276825-41544-1-git-send-email-git@jeffhostetler.com> <5f29c3d9-0de5-385e-fda1-fb4380c7bc17@jeffhostetler.com> Date: Fri, 24 Mar 2017 10:44:59 -0700 In-Reply-To: <5f29c3d9-0de5-385e-fda1-fb4380c7bc17@jeffhostetler.com> (Jeff Hostetler's message of "Fri, 24 Mar 2017 08:39:52 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 9A6FA908-10B9-11E7-B84C-97B1B46B9B0B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff Hostetler writes: > WRT the assert() in name-hash.c, Stefan suggested converting it > to an if-!-die form in an earlier message in this thread. I'm OK > with that or with removing the assert completely. I actually am OK with leaving things as they are ;-)