Received: from eggs.gnu.org ([2001:4830:134:3::10]:58502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJS71-0000y6-KS for qemu-devel@nongnu.org; Thu, 05 Feb 2015 14:29:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJS6x-0000Fm-LC for qemu-devel@nongnu.org; Thu, 05 Feb 2015 14:29:15 -0500 Received: from pb-smtp1.int.icgroup.com ([208.72.237.35]:56577 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJS6x-0000Dp-Fr for qemu-devel@nongnu.org; Thu, 05 Feb 2015 14:29:11 -0500 From: Junio C Hamano References: <20150205114914.GA10126@stefanha-thinkpad.redhat.com> <54D38B73.4060803@redhat.com> Date: Thu, 05 Feb 2015 11:29:07 -0800 In-Reply-To: <54D38B73.4060803@redhat.com> (Eric Blake's message of "Thu, 05 Feb 2015 08:25:39 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Zhu Guihua , Stefan Hajnoczi , qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, guz.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com, afaerber@suse.de, git@vger.kernel.org Eric Blake writes: > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: >>> This series is based on the previous patchset from Chen Fan: >>> https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html >> >> This email has an invalid charset: >> Content-Type: text/plain; charset="y" >> >> I guess you entered "y" when asked how the message was encoded. >> >> Please don't do that, it means we can only guess at the charset. > > In the past, people made a similar problem when 'git send-email' was > asking if a message was in-reply-to something else (the number of > messages incorrectly threaded to a message-id of 'y' or 'n' was evidence > of the poor quality of the question). git.git commit 51bbccfd1b4a > corrected that problem. Sounds like charset encoding is another case > where the interactive parser should be taught to balk at nonsense > encoding answers? I think I answered this in $gmane/263354; care to come up with a plausible valid_re? It is inpractical to attempt to cover all valid charset names, so whatever you do I'd imagine you would want to pass the confirm_only parameter set to true.