From: Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Apr 2012, #09; Mon, 23)
Date: Tue, 24 Apr 2012 11:57:26 -0700
Message-ID: <xmqqipgpgdpl.fsf@junio.mtv.corp.google.com>
References: <xmqq8vhmhzpk.fsf@junio.mtv.corp.google.com>
	<4F966F0C.6090504@seap.minhap.es>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Envelope-to: gcvg-git-2@plane.gmane.org
In-Reply-To: <4F966F0C.6090504@seap.minhap.es> (Nelson Benitez Leon's message
	of "Tue, 24 Apr 2012 11:14:52 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/196236>

Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:

> My original patch already peeked in HTTPS_PROXY env var, I post the
> relevant part:
>  
> +	if (!curl_http_proxy) {
> +		const char *env_proxy, *no_proxy;
> +		char *env_proxy_var;
> +		int read_http_proxy;
> +		struct strbuf buf = STRBUF_INIT;
> +		credential_from_url(&cre_url, url);
> +		strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
> +		env_proxy_var = strbuf_detach(&buf, NULL);
> +		env_proxy = getenv(env_proxy_var);
>
>                 ^^ HERE ^^

When cre_url.protocol is "https", this looks at $ENV{"https_proxy"}, no?

    http://curl.haxx.se/docs/manpage.html#ENVIRONMENT

> so are you referring to something else ?

There may be some other things that break people's settings but
regarding PROXY, the above was wnat I was referring to.