DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 60C65606A326
DKIM2-Signature: i=1; m=1; t=1793611879; d=pobox.com;
	mf=PGdpdHN0ZXJAcG9ib3guY29tPg==;
	rt=PGdpdEB2Z2VyLmtlcm5lbC5vcmc+;
	s=fm1:rsa-sha256:NK3QQZy5j5+E/YiqBpko1F/hPjkgE8EjNNmAjYa/H9Qc1jU
	1DkPYO+xGZCobimXCzqO8v/7oREM9Qir8JMoMarKkJMb4Z7SiRzLTSpjH37d/hQ0
	3vxkJ3cmYXrveSa5zvJUO09lJlyzRjyyWcPiCcTGMB3XoCCC/kaDUQqyLq1zY48M
	NplkIVM8gHCBMg+BHYzD6pT3+5pWuj3QaK843smrpp07jkBOj13vAMcWJGCsmPSg
	/9MXz29Y/pdUPvnbR3krAN82b87dHsrXgp1fCKsT9655BkGyUlUBvKzMzVfIpfQz
	a7q3MwU4LJnU50RJVc+DDtDs8ktfo7D5qezIaZg==;
Message-Instance: m=1; h=sha256:/jMiWNokT4UaQ6fEQ/eI7jvj4U6JsO4NFl9M/aq6+kU=:3QirBHkbxupT11OoR2EwN2mHwJmee6d/iZQeXMSkcJk=;
Feedback-ID: if26b431b:Fastmail
From: Junio C Hamano <gitster@pobox.com>
To: "Anupam Mediratta via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Anupam Mediratta <mediratta@gmail.com>
Subject: Re: [PATCH v2] git-p4: avoid shell interpretation of commit ids in
 applyCommit
In-Reply-To: <pull.2411.v2.git.git.1790238482045.gitgitgadget@gmail.com>
	(Anupam Mediratta via GitGitGadget's message of "Thu, 24 Sep 2026
	08:28:02 +0000")
References: <pull.2411.git.git.1790093506966.gitgitgadget@gmail.com>
	<pull.2411.v2.git.git.1790238482045.gitgitgadget@gmail.com>
Date: Mon, 02 Nov 2026 01:31:17 -0800
Message-ID: <xmqqld7blguy.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain

"Anupam Mediratta via GitGitGadget" <gitgitgadget@gmail.com> writes:

> The shell-based call that applied the patch for real went through
> git-p4.py's own system() helper, which raises CalledProcessError on a
> non-zero exit status, so a failed apply aborted the submit. Keep that
> behaviour by giving the new helper the same ignore_error contract
> system() uses: it raises unless the caller asks for the status, and the
> two callers that test the status for themselves ask for it.
>
> Add a regression test exercising `git p4 submit --commit` with a shell
> metacharacter payload, verifying it is never interpreted.
>
> Signed-off-by: Anupam Mediratta <mediratta@gmail.com>
> ---
>
>     I have read https://git-scm.com/docs/SubmittingPatches#ai and confirm
>     this contribution complies with it.

I do not know what this means, but anyway.

This round unfortunately saw interest and reviews on the list from
nobody.  Unless we see some volunteers to give it a review in a few
weeks, I will discard the topic out of my tree, as 'seen' has been
crowded with topics that have been collecting dust without getting
many reviews.

Thanks.