Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B3EC46466 for ; Sat, 3 Oct 2020 01:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B040321D24 for ; Sat, 3 Oct 2020 01:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="lYehtUjO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725795AbgJCBje (ORCPT ); Fri, 2 Oct 2020 21:39:34 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47656 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgJCBje (ORCPT ); Fri, 2 Oct 2020 21:39:34 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0931dRN8027539; Sat, 3 Oct 2020 01:39:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=ouc9bc3hh2zvSkdXnaR5wXuKREHRkvknNtta6nXK+F0=; b=lYehtUjOGGoDGTifHSGqGwppuneUiNQSsgG5raegNHEctWFGecaqoSi38/Q6NdX9znXa gkThgCPH3c2yKHbFAzH1pTph8eBxzeUWU7FfSwgncLE9fpWKGE6n5Oq03a1yJjPBJrR0 lbM1TSmWzpzzxwCo0la9cu4Xbw3MDyKRc7o8YJ7nkYEyzUmkU0TmvzdlKEVzXSe3B4QM PjpenHprDrWeJyz+4KPXGRWwGyzzxBjOtaFruNImBJp/QoHD5epSCXDL/7ujQfO448Na d1v/whmIrAIzIke6EoFRZ4YQ1cPsiRAT2PG3IfJWOeS4rPFQe/tuKlPYTn0QAq3dEsjO sA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 33sx9nnexn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 03 Oct 2020 01:39:26 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0931ZsDQ194312; Sat, 3 Oct 2020 01:39:26 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33xeds2r1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 03 Oct 2020 01:39:26 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0931dO7t006826; Sat, 3 Oct 2020 01:39:24 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 02 Oct 2020 18:39:24 -0700 To: Hannes Reinecke Cc: James Smart , "Martin K. Petersen" , James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org Subject: Re: [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200910084059.138507-1-hare@suse.de> Date: Fri, 02 Oct 2020 21:39:22 -0400 In-Reply-To: <20200910084059.138507-1-hare@suse.de> (Hannes Reinecke's message of "Thu, 10 Sep 2020 10:40:59 +0200") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030014 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=1 phishscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030015 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hannes, > If we fail to issue the iocb in lpfc_gen_req() we need to drop the > nodelist reference. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering