From: "Martin K. Petersen" Subject: Re: [PATCH] sys/block: Add discard_support entry Date: Mon, 02 May 2011 10:18:55 -0400 Message-ID: References: <1304335504-14048-1-git-send-email-lczerner@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "Martin K. Petersen" , linux-fsdevel@vger.kernel.org, Jens Axboe , Jeff Moyer To: Lukas Czerner Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:35553 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758549Ab1EBOTK (ORCPT ); Mon, 2 May 2011 10:19:10 -0400 In-Reply-To: (Lukas Czerner's message of "Mon, 2 May 2011 15:58:05 +0200 (CEST)") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: >>>>> "Lukas" == Lukas Czerner writes: >> Not true. If discard_max_bytes is > 0 then discard is supported. >> Lukas> Yes I thought about that, but it is not actually *very* obvious Lukas> and I was not even sure it works this way all the time. I think Lukas> it is better to have a real sysfs file. To me it's pretty obvious that if the device reports a max discard size of 0 then discard is not supported. -- Martin K. Petersen Oracle Linux Engineering