From: Martin K. Petersen Date: Wed, 06 Apr 2022 23:27:40 -0400 Subject: [Cluster-devel] [Ocfs2-devel] [PATCH 21/27] block: move {bdev, queue_limit}_discard_alignment out of line In-Reply-To: <20220406060516.409838-22-hch@lst.de> (Christoph Hellwig via Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:10 +0200") References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-22-hch@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Christoph, > No need to inline these fairly larger helpers. Also fix the return > value to be unsigned, just like the field in struct queue_limits. I believe the original reason for the signed int here was to be able to express -1 for sysfs. I am not sure why I didn't just use the misaligned flag. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering