From: "Martin K. Petersen" Subject: Re: [PATCH 1/3] block: Add blk_queue_copy_limits() Date: Sun, 20 Sep 2009 17:00:24 -0400 Message-ID: References: <4AB3B43D.9000802@ce.jp.nec.com> <4AB4F74E.7000908@ce.jp.nec.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <4AB4F74E.7000908@ce.jp.nec.com> (Jun'ichi Nomura's message of "Sun, 20 Sep 2009 00:22:54 +0900") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development Cc: Jens Axboe , Alasdair G Kergon , Mike Snitzer , "Martin K. Petersen" , linux-kernel@vger.kernel.org List-Id: dm-devel.ids >>>>> "Jun'ichi" == Jun'ichi Nomura writes: Jun'ichi> Umm, with this, BLK_DEF_MAX_SECTORS becomes upper bound of Jun'ichi> max_hw_sectors and the values of underlying devices are not Jun'ichi> propagated to the stacking devices. Well, max_sectors is already bounded by this. max_hw_sectors only really matters for PC commands, so I'm not sure it's a big deal for DM. But I guess we could set the default max_hw_sectors to -1. I'm just trying to avoid these scattered if-0-set-it-to-something-else cases. I'd much rather have the defaults do the right thing. -- Martin K. Petersen Oracle Linux Engineering