Return-Path: Subject: Re: fix and cleanup discard_alignment handling From: "Martin K. Petersen" Message-ID: References: <20220418045314.360785-1-hch@lst.de> Date: Tue, 26 Apr 2022 00:16:21 -0400 In-Reply-To: <20220418045314.360785-1-hch@lst.de> (Christoph Hellwig's message of "Mon, 18 Apr 2022 06:53:03 +0200") MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Johannes Berg , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Roger Pau =?utf-8?Q?Monn=C3=A9?= , Mike Snitzer , Song Liu , Stefan Haberland , Jan Hoeppner , "Martin K. Petersen" , linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, dm-devel@redhat.com Christoph, > the somewhat confusing name of the discard_alignment queue limit, that > really is an offset for the discard granularity mislead a lot of > driver authors to set it to an incorrect value. This series tries to > fix up all these cases. Not sure how I ended up with "discard_alignment" when I called the corresponding I/O parameter "alignment_offset". Anyway. All this looks good to me. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um