From: Keith Packard Subject: Re: [PATCH] Destroy screen pixmap on screen close. Date: Sat, 03 Jul 2010 16:46:36 -0400 Message-ID: References: <1277992600-7721-1-git-send-email-keithp@keithp.com> <89k83a$8ps5en@azsmga001.ch.intel.com> <89k77n$o86ttb@fmsmga001.fm.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0308945214==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 62A119E733 for ; Sat, 3 Jul 2010 13:48:43 -0700 (PDT) In-Reply-To: <89k77n$o86ttb@fmsmga001.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.sourceforge.net List-Id: intel-gfx@lists.freedesktop.org --===============0308945214== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 02 Jul 2010 17:19:18 +0100, Chris Wilson = wrote: > On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard wro= te: > > On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson wrote: > >=20 > > > This looks like the responsibility of miCloseScreen(). Are we failing= to > > > chain up properly? > >=20 > > I don't think miCloseScreen (or fbCloseScreen) can do this -- before > > we're called, rendering may not have been finished, after we're called, > > the acceleration code is shut down and pixmaps cannot be freed. >=20 > That sounds true, and deserves a comment in the code. It doesn't explain > why fbCloseScreen() calls free(screen->devPrivate) instead of > miCloseScreen() and causing the leak in the first place... :) yeah, miCloseScreen frees the pixmap, but that's too late... =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFML6GtQp8BWwlsTdMRAm0NAJ90g/4AMKQQ39BpLiJWpNCokB02jACfZH82 tkhWmqRm9EDB+g7HEuMWzmg= =4c4B -----END PGP SIGNATURE----- --=-=-=-- --===============0308945214== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0308945214==--