From: Keith Packard Subject: Re: [PATCH] drm/i915:fix the bug that testdisplay can't work with 32 bits depth (bug # 40011) Date: Sat, 13 Aug 2011 10:46:58 -0700 Message-ID: References: <1313292134-15318-1-git-send-email-hai.lan@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0813451854==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 686149E75E for ; Sat, 13 Aug 2011 10:47:01 -0700 (PDT) In-Reply-To: <1313292134-15318-1-git-send-email-hai.lan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Hai Lan , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0813451854== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 13 Aug 2011 23:22:14 -0400, Hai Lan wrote: > case 32: > if (fb->depth =3D=3D 24) > dspcntr |=3D DISPPLANE_32BPP_NO_ALPHA; > + else if (fb->depth =3D=3D 32) > + dspcntr |=3D DISPPLANE_32BPP_NO_ALPHA; > else if (fb->depth =3D=3D 30) > dspcntr |=3D DISPPLANE_32BPP_30BIT_NO_ALPHA; > else There is no hardware support for depth 32 output -- the hardware can only do 24-bits (8-8-8-8) XRGB or 30-bits (2-10-10-10) XRGB. Passing depth 32 to this function is in fact an error which the kernel now correctly reports. This patch simply assumes that the application programmer created a depth 24 frame buffer and then mistakenly told the kernel that it was depth 32. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFORriSQp8BWwlsTdMRAivMAKCBn8I+eUk9KVLhEte1GmvZVR3WAACfWhRe 0nBxCnqprTUs57OIkJEmD5I= =E2+k -----END PGP SIGNATURE----- --=-=-=-- --===============0813451854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0813451854==--