From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915:merge ring_put/get_irq into bsd_ring_put/get_irq Date: Wed, 27 Apr 2011 19:40:49 -0700 Message-ID: References: <1303890079-2518-1-git-send-email-boqun.feng@intel.com> <749B9D3DBF0F054390025D9EAFF47F224BDFB524@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0189637602==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 410149E84B for ; Wed, 27 Apr 2011 19:40:57 -0700 (PDT) In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F224BDFB524@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Feng, Boqun" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============0189637602== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 28 Apr 2011 10:06:51 +0800, "Feng, Boqun" wr= ote: > I have discussed this with Chris in my earlier patch. >=20 > This change is a clean-up, since ring_put_irq and ring_get_irq are only u= sed by=20 > bsd_ring_put_irq and bsd_ring_get_irq. >=20 > And once this change is made, it is more clear to see the difference betw= een > g4x and ironlake BSD interrupt control interface, because they are handle= d in > a single function and they are different at the interrupt mask reg addres= ss as > well as the interrupt flag please put important details like that in the commit message; having some way to evaluate the utility of the patch is very important for something which doesn't actually change how the code works. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNuNOxQp8BWwlsTdMRAj+ZAKDJerWP4pp3GVP+KAaaOr1nARx4PwCdEHbV dHcAfOgDAXGUVeews3plZDk= =76Xb -----END PGP SIGNATURE----- --=-=-=-- --===============0189637602== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0189637602==--