From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Date: Mon, 28 Oct 2013 23:19:53 +0000 Subject: [U-Boot] Illegal use of FP ops in clock_ti814x.c In-Reply-To: <20131027211157.1AF2E380495@gemini.denx.de> (Wolfgang Denk's message of "Sun, 27 Oct 2013 22:11:57 +0100") References: <20131027211157.1AF2E380495@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk writes: > Dear Matt, > > I hope you are the right person to address this to - if not, please > help to redirect to the current responsible developer. > > Function pll_sigma_delta_val() in arch/arm/cpu/armv7/am33xx/clock_ti814x.c > incorrectly uses "float" data, which results in FP operations which > are not permitted in U-Boot. > > The actual computation appears simple enough so a rewrite of the code > without using any floating point operations should be fairly easy, but > I don't understand the actual logic of this code, so I'd rather leave > this to someone who does. > > Could you please help and clean up these three lines of code? Something like this should be equivalent. That said, it looks suspiciously like it's meant to simply do a division and round up. If that is the case, +225 should be +249. It probably makes no difference for the values actually encountered. diff --git a/arch/arm/cpu/armv7/am33xx/clock_ti814x.c b/arch/arm/cpu/armv7/am33xx/clock_ti814x.c index ef14f47..9b5a47b 100644 --- a/arch/arm/cpu/armv7/am33xx/clock_ti814x.c +++ b/arch/arm/cpu/armv7/am33xx/clock_ti814x.c @@ -211,11 +211,8 @@ static u32 pll_dco_freq_sel(u32 clkout_dco) static u32 pll_sigma_delta_val(u32 clkout_dco) { u32 sig_val = 0; - float frac_div; - frac_div = (float) clkout_dco / 250; - frac_div = frac_div + 0.90; - sig_val = (int)frac_div; + sig_val = (clkout_dco + 225) / 250; sig_val = sig_val << 24; return sig_val; -- M?ns Rullg?rd mans@mansr.com