drm: Add orientation quirk for GPD Win Max
Subsystems (30)
Sasha Levin
maintainerPATCH 141/149 MIPS: ingenic: correct unit node address
In reply to Sasha LevinFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 8931ddd8d6a55fcefb20f44a38ba42bb746f0b62 ]
Unit node addresses should not have leading 0x:
Warning (unit_address_format): /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have leading "0x"
--- arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/ingenic/jz4780.dtsi +1 -1
@@ -510,7 +510,7 @@ efuse: efuse@d0 { #address-cells = <1>; #size-cells = <1>; - eth0_addr: eth-mac-addr@0x22 { + eth0_addr: eth-mac-addr@22 { reg = <0x22 0x6>; }; };
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 142/149 Bluetooth: Fix use after free in hci_send_acl
In reply to Sasha LevinFrom: Luiz Augusto von Dentz <[email protected]>
[ Upstream commit f63d24baff787e13b723d86fe036f84bdbc35045 ]
This fixes the following trace caused by receiving HCI_EV_DISCONN_PHY_LINK_COMPLETE which does call hci_conn_del without first checking if conn->type is in fact AMP_LINK and in case it is do properly cleanup upper layers with hci_disconn_cfm:
==================================================================
BUG: KASAN: use-after-free in hci_send_acl+0xaba/0xc50
Read of size 8 at addr ffff88800e404818 by task bluetoothd/142
CPU: 0 PID: 142 Comm: bluetoothd Not tainted
5.17.0-rc5-00006-gda4022eeac1a #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
Call Trace:
<TASK>
dump_stack_lvl+0x45/0x59
print_address_description.constprop.0+0x1f/0x150
kasan_report.cold+0x7f/0x11b
hci_send_acl+0xaba/0xc50
l2cap_do_send+0x23f/0x3d0
l2cap_chan_send+0xc06/0x2cc0
l2cap_sock_sendmsg+0x201/0x2b0
sock_sendmsg+0xdc/0x110
sock_write_iter+0x20f/0x370
do_iter_readv_writev+0x343/0x690
do_iter_write+0x132/0x640
vfs_writev+0x198/0x570
do_writev+0x202/0x280
do_syscall_64+0x38/0x90
entry_SYSCALL_64_after_hwframe+0x44/0xae
RSP: 002b:00007ffce8a099b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000014
Code: 0f 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b8 0f 1f 00 f3
0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 14 00 00 00 0f 05
<48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10
RDX: 0000000000000001 RSI: 00007ffce8a099e0 RDI: 0000000000000015
RAX: ffffffffffffffda RBX: 00007ffce8a099e0 RCX: 00007f788fc3cf77
R10: 00007ffce8af7080 R11: 0000000000000246 R12: 000055e4ccf75580
RBP: 0000000000000015 R08: 0000000000000002 R09: 0000000000000001
</TASK>
R13: 000055e4ccf754a0 R14: 000055e4ccf75cd0 R15: 000055e4ccf4a6b0
Allocated by task 45:
kasan_save_stack+0x1e/0x40
__kasan_kmalloc+0x81/0xa0
hci_chan_create+0x9a/0x2f0
l2cap_conn_add.part.0+0x1a/0xdc0
l2cap_connect_cfm+0x236/0x1000
le_conn_complete_evt+0x15a7/0x1db0
hci_le_conn_complete_evt+0x226/0x2c0
hci_le_meta_evt+0x247/0x450
hci_event_packet+0x61b/0xe90
hci_rx_work+0x4d5/0xc50
process_one_work+0x8fb/0x15a0
worker_thread+0x576/0x1240
kthread+0x29d/0x340
ret_from_fork+0x1f/0x30
Freed by task 45:
kasan_save_stack+0x1e/0x40
kasan_set_track+0x21/0x30
kasan_set_free_info+0x20/0x30
__kasan_slab_free+0xfb/0x130
kfree+0xac/0x350
hci_conn_cleanup+0x101/0x6a0
hci_conn_del+0x27e/0x6c0
hci_disconn_phylink_complete_evt+0xe0/0x120
hci_event_packet+0x812/0xe90
hci_rx_work+0x4d5/0xc50
process_one_work+0x8fb/0x15a0
worker_thread+0x576/0x1240
kthread+0x29d/0x340
ret_from_fork+0x1f/0x30
The buggy address belongs to the object at ffff88800c0f0500
The buggy address is located 24 bytes inside of
which belongs to the cache kmalloc-128 of size 128
The buggy address belongs to the page:
128-byte region [ffff88800c0f0500, ffff88800c0f0580)
flags: 0x100000000000200(slab|node=0|zone=1)
page:00000000fe45cd86 refcount:1 mapcount:0
mapping:0000000000000000 index:0x0 pfn:0xc0f0
raw: 0000000000000000 0000000080100010 00000001ffffffff
0000000000000000
raw: 0100000000000200 ffffea00003a2c80 dead000000000004
ffff8880078418c0
page dumped because: kasan: bad access detected
ffff88800c0f0400: 00 00 00 00 00 00 00 00 00 00 00 00 00 fc fc fc
Memory state around the buggy address:
>ffff88800c0f0500: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88800c0f0480: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88800c0f0580: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
^
==================================================================
ffff88800c0f0600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb--- net/bluetooth/hci_event.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/bluetooth/hci_event.c +2 -1
@@ -5453,8 +5453,9 @@ static void hci_disconn_phylink_complete_evt(struct hci_dev *hdev, void *data,hci_dev_lock (hdev); hcon =hci_conn_hash_lookup_handle (hdev, ev->phy_handle); -if (hcon) { +if (hcon && hcon->type ==AMP_LINK ) { hcon->state =BT_CLOSED ; +hci_disconn_cfm (hcon, ev->reason);hci_conn_del (hcon); }
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 143/149 netfilter: conntrack: revisit gc autotuning
In reply to Sasha LevinFrom: Florian Westphal <[email protected]>
[ Upstream commit 2cfadb761d3d0219412fd8150faea60c7e863833 ]
as of commit 4608fdfc07e1
("netfilter: conntrack: collect all entries in one cycle") conntrack gc was changed to run every 2 minutes.
On systems where conntrack hash table is set to large value, most evictions happen from gc worker rather than the packet path due to hash table distribution.
This causes netlink event overflows when events are collected.
This change collects average expiry of scanned entries and reschedules to the average remaining value, within 1 to 60 second interval.
To avoid event overflows, reschedule after each bucket and add a limit for both run time and number of evictions per run.
If more entries have to be evicted, reschedule and restart 1 jiffy into the future.
--- net/netfilter/nf_conntrack_core.c | 85 ++++++++++++++++++++++++------- 1 file changed, 68 insertions(+), 17 deletions(-)
net/netfilter/nf_conntrack_core.c +68 -17
@@ -67,6 +67,8 @@ EXPORT_SYMBOL_GPL(nf_conntrack_hash);struct conntrack_gc_work {struct delayed_work dwork;u32 next_bucket; +u32 avg_timeout; +u32 start_time;bool exiting;bool early_drop; };
@@ -78,8 +80,19 @@ static __read_mostly bool nf_conntrack_locks_all;/* serialize hash resizes and nf_ct_iterate_cleanup */ static DEFINE_MUTEX (nf_conntrack_mutex); -#define GC_SCAN_INTERVAL (120u * HZ) +#define GC_SCAN_INTERVAL_MAX (60ul * HZ) +#define GC_SCAN_INTERVAL_MIN (1ul * HZ) + +/* clamp timeouts to this value (TCP unacked) */ +#define GC_SCAN_INTERVAL_CLAMP (300ul * HZ) + +/* large initial bias so that we don't scan often just because we have +* three entries with a 1s timeout. +*/ +#define GC_SCAN_INTERVAL_INIT INT_MAX +#define GC_SCAN_MAX_DURATION msecs_to_jiffies(10) +#define GC_SCAN_EXPIRED_MAX (64000u / HZ)#define MIN_CHAINLEN 8u#define MAX_CHAINLEN (32u - MIN_CHAINLEN)
@@ -1421,16 +1434,28 @@ static bool gc_worker_can_early_drop(const struct nf_conn *ct)static void gc_worker (struct work_struct *work) { -unsigned long end_time = jiffies +GC_SCAN_MAX_DURATION ;unsigned int i, hashsz, nf_conntrack_max95 =0 ; -unsigned long next_run =GC_SCAN_INTERVAL ; +u32 end_time, start_time = nfct_time_stamp;struct conntrack_gc_work *gc_work; +unsigned int expired_count =0 ; +unsigned long next_run; +s32 delta_time; + gc_work = container_of(work, struct conntrack_gc_work, dwork.work); i = gc_work->next_bucket;if (gc_work->early_drop) nf_conntrack_max95 = nf_conntrack_max /100u *95u ; +if (i ==0 ) { + gc_work->avg_timeout =GC_SCAN_INTERVAL_INIT ; + gc_work->start_time = start_time; + } + + next_run = gc_work->avg_timeout; + + end_time = start_time +GC_SCAN_MAX_DURATION ; + do { struct nf_conntrack_tuple_hash *h; struct hlist_nulls_head *ct_hash;
@@ -1447,6 +1472,7 @@ static void gc_worker(struct work_struct *work)hlist_nulls_for_each_entry_rcu (h, n, &ct_hash[i], hnnode) {struct nf_conntrack_net *cnet; +unsigned long expires;struct net *net; tmp =nf_ct_tuplehash_to_ctrack (h);
@@ -1456,11 +1482,29 @@ static void gc_worker(struct work_struct *work)continue ; } +if (expired_count >GC_SCAN_EXPIRED_MAX ) { +rcu_read_unlock (); + + gc_work->next_bucket = i; + gc_work->avg_timeout = next_run; + + delta_time = nfct_time_stamp - gc_work->start_time; + +/* re-sched immediately if total cycle time is exceeded */ + next_run = delta_time < (s32 )GC_SCAN_INTERVAL_MAX ; + goto early_exit; + } +if (nf_ct_is_expired (tmp)) {nf_ct_gc_expired (tmp); + expired_count++;continue ; } + expires =clamp (nf_ct_expires (tmp),GC_SCAN_INTERVAL_MIN ,GC_SCAN_INTERVAL_CLAMP ); + next_run += expires; + next_run /=2u ; +if (nf_conntrack_max95 ==0 ||gc_worker_skip_ct (tmp))continue ;
@@ -1478,8 +1522,10 @@ static void gc_worker(struct work_struct *work)continue ; } -if (gc_worker_can_early_drop (tmp)) +if (gc_worker_can_early_drop (tmp)) {nf_ct_kill (tmp); + expired_count++; + }nf_ct_put (tmp); }
@@ -1492,33 +1538,38 @@ static void gc_worker(struct work_struct *work)cond_resched (); i++; -if (time_after (jiffies, end_time) && i < hashsz) { + delta_time = nfct_time_stamp - end_time; +if (delta_time >0 && i < hashsz) { + gc_work->avg_timeout = next_run; gc_work->next_bucket = i; next_run =0 ; -break ; + goto early_exit; } }while (i < hashsz); + gc_work->next_bucket =0 ; + + next_run =clamp (next_run,GC_SCAN_INTERVAL_MIN ,GC_SCAN_INTERVAL_MAX ); + + delta_time =max_t (s32, nfct_time_stamp - gc_work->start_time,1 ); +if (next_run > (unsigned long )delta_time) + next_run -= delta_time; +else + next_run =1 ; + +early_exit:if (gc_work->exiting)return ; -/* -* Eviction will normally happen from the packet path, and not -* from this gc worker. -* -* This worker is only here to reap expired entries when system went -* idle after a busy period. -*/ -if (next_run) { +if (next_run) gc_work->early_drop = false; - gc_work->next_bucket =0 ; - } +queue_delayed_work (system_power_efficient_wq, &gc_work->dwork, next_run); }static void conntrack_gc_work_init (struct conntrack_gc_work *gc_work) { -INIT_DEFERRABLE_WORK (&gc_work->dwork, gc_worker); +INIT_DELAYED_WORK (&gc_work->dwork, gc_worker); gc_work->exiting = false; }
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 144/149 netlabel: fix out-of-bounds memory accesses
In reply to Sasha LevinFrom: Wang Yufen <[email protected]>
[ Upstream commit f22881de730ebd472e15bcc2c0d1d46e36a87b9c ]
In calipso_map_cat_ntoh(), in the for loop, if the return value of netlbl_bitmap_walk() is equal to (net_clen_bits - 1), when netlbl_bitmap_walk() is called next time, out-of-bounds memory accesses of bitmap[byte_offset] occurs.
The bug was found during fuzzing. The following is the fuzzing report
BUG: KASAN: slab-out-of-bounds in netlbl_bitmap_walk+0x3c/0xd0 Read of size 1 at addr ffffff8107bf6f70 by task err_OH/252 CPU: 7 PID: 252 Comm: err_OH Not tainted 5.17.0-rc7+ #17 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace+0x21c/0x230 show_stack+0x1c/0x60 dump_stack_lvl+0x64/0x7c print_address_description.constprop.0+0x70/0x2d0 __kasan_report+0x158/0x16c kasan_report+0x74/0x120 __asan_load1+0x80/0xa0 netlbl_bitmap_walk+0x3c/0xd0 calipso_opt_getattr+0x1a8/0x230 calipso_sock_getattr+0x218/0x340 calipso_sock_getattr+0x44/0x60 netlbl_sock_getattr+0x44/0x80 selinux_netlbl_socket_setsockopt+0x138/0x170 selinux_socket_setsockopt+0x4c/0x60 security_socket_setsockopt+0x4c/0x90 __sys_setsockopt+0xbc/0x2b0 __arm64_sys_setsockopt+0x6c/0x84 invoke_syscall+0x64/0x190 el0_svc_common.constprop.0+0x88/0x200 do_el0_svc+0x88/0xa0 el0_svc+0x128/0x1b0 el0t_64_sync_handler+0x9c/0x120 el0t_64_sync+0x16c/0x170
--- net/netlabel/netlabel_kapi.c | 2 ++ 1 file changed, 2 insertions(+)
net/netlabel/netlabel_kapi.c +2 -0
@@ -885,6 +885,8 @@ int netlbl_bitmap_walk(const unsigned char *bitmap, u32 bitmap_len,unsigned char bitmask;unsigned char byte; +if (offset >= bitmap_len) +return -1 ; byte_offset = offset /8 ; byte = bitmap[byte_offset]; bit_spot = offset;
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 145/149 ceph: fix inode reference leakage in ceph_get_snapdir()
In reply to Sasha LevinFrom: Xiubo Li <[email protected]>
[ Upstream commit 322794d3355c33adcc4feace0045d85a8e4ed813 ]
The ceph_get_inode() will search for or insert a new inode into the hash for the given vino, and return a reference to it. If new is non-NULL, its reference is consumed.
We should release the reference when in error handing cases.
--- fs/ceph/inode.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/ceph/inode.c +8 -2
@@ -87,13 +87,13 @@ struct inode *ceph_get_snapdir(struct inode *parent)if (!S_ISDIR (parent->i_mode)) {pr_warn_once ("bad snapdir parent type (mode=0%o)\n" , parent->i_mode); -return ERR_PTR (-ENOTDIR ); + goto err; }if (!(inode->i_state &I_NEW ) && !S_ISDIR (inode->i_mode)) {pr_warn_once ("bad snapdir inode type (mode=0%o)\n" , inode->i_mode); -return ERR_PTR (-ENOTDIR ); + goto err; } inode->i_mode = parent->i_mode;
@@ -113,6 +113,12 @@ struct inode *ceph_get_snapdir(struct inode *parent) }return inode; +err: +if ((inode->i_state &I_NEW )) +discard_new_inode (inode); +else +iput (inode); +return ERR_PTR (-ENOTDIR ); }const struct inode_operations ceph_file_iops = {
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 146/149 ceph: fix memory leak in ceph_readdir when note_last_dentry returns error
In reply to Sasha LevinFrom: Xiubo Li <[email protected]>
[ Upstream commit f639d9867eea647005dc824e0e24f39ffc50d4e4 ]
Reset the last_readdir at the same time, and add a comment explaining why we don't free last_readdir when dir_emit returns false.
--- fs/ceph/dir.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
fs/ceph/dir.c +10 -1
@@ -478,8 +478,11 @@ static int ceph_readdir(struct file *file, struct dir_context *ctx) 2 : (fpos_off(rde->offset) + 1); err =note_last_dentry (dfi, rde->name, rde->name_len, next_offset); -if (err) +if (err) { +ceph_mdsc_put_request (dfi->last_readdir); + dfi->last_readdir =NULL ;return err; + } }else if (req->r_reply_info.dir_end) { dfi->next_offset =2 ;/* keep last name */
@@ -520,6 +523,12 @@ static int ceph_readdir(struct file *file, struct dir_context *ctx)if (!dir_emit (ctx, rde->name, rde->name_len,ceph_present_ino (inode->i_sb,le64_to_cpu (rde->inode.in->ino)),le32_to_cpu (rde->inode.in->mode) >>12 )) { +/* +* NOTE: Here no need to put the 'dfi->last_readdir', +* because when dir_emit stops us it's most likely +* doesn't have enough memory, etc. So for next readdir +* it will continue. +*/ dout ("filldir stopping us...\n" );return 0 ; }
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 147/149 lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option
In reply to Sasha LevinFrom: Feng Tang <[email protected]>
[ Upstream commit 1bf18da62106225dbc47aab41efee2aeb99caccd ]
0Day robots reported there is compiling issue for 'csky' ARCH when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
All errors (new ones prefixed by >>):
{standard input}: Assembler messages:
Quoted 1 line
Quoted 1 line
{standard input}:2277: Error: pcrel offset for branch to .LS000B too far (
0x3c)
Which was discussed in [2]. And as there is no solution for csky yet, add some dependency for this config to limit it to several ARCHs which have no compiling issue so far.
[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://www.spinics.net/lists/linux-kbuild/msg30298.html
--- lib/Kconfig.debug | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/Kconfig.debug +2 -1
@@ -416,7 +416,8 @@ config SECTION_MISMATCH_WARN_ONLY If unsure, say Y. config DEBUG_FORCE_FUNCTION_ALIGN_64B - bool "Force all function address 64B aligned" if EXPERT + bool "Force all function address 64B aligned" + depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC) help There are cases that a commit from one domain changes the function address alignment of other domains, and cause magic performance
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 148/149 init/main.c: return 1 from handled __setup() functions
In reply to Sasha LevinFrom: Randy Dunlap <[email protected]>
[ Upstream commit f9a40b0890658330c83c95511f9d6b396610defc ]
initcall_blacklist() should return 1 to indicate that it handled its cmdline arguments.
set_debug_rodata() should return 1 to indicate that it handled its cmdline arguments. Print a warning if the option string is invalid.
This prevents these strings from being added to the 'init' program's environment as they are not init arguments/parameters.
--- init/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
init/main.c +4 -2
@@ -1192,7 +1192,7 @@ static int __init initcall_blacklist(char *str) } }while (str_entry); -return 0 ; +return 1 ; } static bool __init_or_module initcall_blacklisted(initcall_t fn)
@@ -1454,7 +1454,9 @@ static noinline void __init kernel_init_freeable(void);bool rodata_enabled__ro_after_init = true;static int __init set_debug_rodata (char *str) { -return strtobool (str, &rodata_enabled); +if (strtobool (str, &rodata_enabled)) +pr_warn ("Invalid option string for rodata: '%s'\n" , str); +return 1 ; }__setup ("rodata=" , set_debug_rodata);#endif
Signature · 1 line
2.34.1
Sasha Levin
maintainerPATCH 149/149 minix: fix bug when opening a file with O_DIRECT
In reply to Sasha LevinFrom: Qinghua Jin <[email protected]>
[ Upstream commit 9ce3c0d26c42d279b6c378a03cd6a61d828f19ca ]
Testcase:
1. create a minix file system and mount it
2. open a file on the file system with O_RDWR|O_CREAT|O_TRUNC|O_DIRECT
3. open fails with -EINVAL but leaves an empty file behind. All other open() failures don't leave the failed open files behind.
It is hard to check the direct_IO op before creating the inode. Just as ext4 and btrfs do, this patch will resolve the issue by allowing to create the file with O_DIRECT but returning error when writing the file.
--- fs/minix/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/minix/inode.c +2 -1
@@ -447,7 +447,8 @@ static const struct address_space_operations minix_aops = { .writepage = minix_writepage, .write_begin = minix_write_begin, .write_end = generic_write_end, - .bmap = minix_bmap + .bmap = minix_bmap, + .direct_IO = noop_direct_IO };static const struct inode_operations minix_symlink_inode_operations = {
Signature · 1 line
2.34.1
Hi Sasha,
Quoted 11 lines · Sasha Levin
From: Anisse Astier <[email protected]>
[ Upstream commit
0b464ca3e0dd3cec65f28bc6d396d82f19080f69]Panel is 800x1280, but mounted on a laptop form factor, sideways.
Signed-off-by Anisse Astier <[email protected]>Reviewed-by Hans de Goede <[email protected]>Signed-off-by Jani Nikula <[email protected]>Signed-off-by Sasha Levin <[email protected]>
I don't think this patch will be very useful, because it won't fix the device's display orientation without the previous patch it came with, titled "drm/i915/opregion: add support for mailbox #5 EDID" (e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be added, I'd prefer if we waited a few more weeks to make sure it does not cause regressions.
My advice is to drop this patch from all stable kernels for now.
Regards,
Anisse
Hi,
Quoted 15 lines · Anisse Astier
Hi Sasha,
Quoted 11 lines · Sasha Levin
From: Anisse Astier <[email protected]>
[ Upstream commit
0b464ca3e0dd3cec65f28bc6d396d82f19080f69]Panel is 800x1280, but mounted on a laptop form factor, sideways.
Signed-off-by Anisse Astier <[email protected]>Reviewed-by Hans de Goede <[email protected]>Signed-off-by Jani Nikula <[email protected]>Signed-off-by Sasha Levin <[email protected]>
Quoted 5 lines
I don't think this patch will be very useful, because it won't fix the device's display orientation without the previous patch it came with, titled "drm/i915/opregion: add support for mailbox #5 EDID" (
e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be added
Well actually it will already put e.g. the text console the right way up since efifb also uses this quirks and gives a hint to fbcon to rotate the text. So it is not entirely useless.
And since all quirks added to drivers/gpu/drm/drm_panel_orientation_quirks.c typically get backported having this one in place now will avoid conflicts with future backports.
That combined with not really seeing a downside to already having this in place even without the i915 support being sorted out makes me lean more towards the direction of believing that having this in 5.17 is fine...
Regards,
Hans
Quoted 28 lines · Hans de Goede
Hi,
Quoted 15 lines · Anisse Astier
Hi Sasha,
Quoted 11 lines · Sasha Levin
From: Anisse Astier <[email protected]>
[ Upstream commit
0b464ca3e0dd3cec65f28bc6d396d82f19080f69]Panel is 800x1280, but mounted on a laptop form factor, sideways.
Signed-off-by Anisse Astier <[email protected]>Reviewed-by Hans de Goede <[email protected]>Signed-off-by Jani Nikula <[email protected]>Signed-off-by Sasha Levin <[email protected]>Quoted 5 lines
I don't think this patch will be very useful, because it won't fix the device's display orientation without the previous patch it came with, titled "drm/i915/opregion: add support for mailbox #5 EDID" (
e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be addedWell actually it will already put e.g. the text console the right way up since efifb also uses this quirks and gives a hint to fbcon to rotate the text. So it is not entirely useless.
Quoted 9 lines
And since all quirks added to
drivers/gpu/drm/drm_panel_orientation_quirks.ctypically get backported having this one in place now will avoid conflicts with future backports.That combined with not really seeing a downside to already having this in place even without the i915 support being sorted out makes me lean more towards the direction of believing that having this in 5.17 is fine...
Good points; lets's keep it in the stable queues.
Thanks,
Anisse