5.15.38-rc1 review
Subsystems (8)
Greg Kroah-Hartman
maintainerPATCH 167/177 tty: n_gsm: fix wrong command frame length field encoding
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit 398867f59f956985f4c324f173eff7b946e14bd8 upstream.
n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.4.6.1 states that each command frame shall
be made up from type, length and value. Looking for example in chapter
5.4.6.3.5 at the description for the encoding of a flow control on command
it becomes obvious, that the type and length field is always present
whereas the value may be zero bytes long. The current implementation omits
the length field if the value is not present. This is wrong.
Correct this by always sending the length in gsm_control_transmit().
So far only the modem status command (MSC) has included a value and encoded
its length directly. Therefore, also change gsmtty_modem_update().
--- drivers/tty/n_gsm.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
drivers/tty/n_gsm.c +11 -12
@@ -1302,11 +1302,12 @@ static void gsm_control_response(structstatic void gsm_control_transmit (struct gsm_mux *gsm,struct gsm_control *ctrl) { -struct gsm_msg *msg =gsm_data_alloc (gsm,0 , ctrl->len +1 , gsm->ftype); +struct gsm_msg *msg =gsm_data_alloc (gsm,0 , ctrl->len +2 , gsm->ftype);if (msg ==NULL )return ; - msg->data[0 ] = (ctrl->cmd <<1 ) |2 |EA ;/* command */ -memcpy (msg->data +1 , ctrl->data, ctrl->len); + msg->data[0 ] = (ctrl->cmd <<1 ) |CR |EA ;/* command */ + msg->data[1 ] = (ctrl->len <<1 ) |EA ; +memcpy (msg->data +2 , ctrl->data, ctrl->len);gsm_data_queue (gsm->dlci[0 ], msg); }
@@ -2889,19 +2890,17 @@ static struct tty_ldisc_ops tty_ldisc_pastatic int gsmtty_modem_update (struct gsm_dlci *dlci,u8 brk) { -u8 modembits[5 ]; +u8 modembits[3 ];struct gsm_control *ctrl;int len =2 ; -if (brk) + modembits[0 ] = (dlci->addr <<2 ) |2 |EA ;/* DLCI, Valid, EA */ + modembits[1 ] = (gsm_encode_modem (dlci) <<1 ) |EA ; +if (brk) { + modembits[2 ] = (brk <<4 ) |2 |EA ;/* Length, Break, EA */ len++; - - modembits[0 ] = len <<1 |EA ;/* Data bytes */ - modembits[1 ] = dlci->addr <<2 |3 ;/* DLCI, EA, 1 */ - modembits[2 ] =gsm_encode_modem (dlci) <<1 |EA ; -if (brk) - modembits[3 ] = brk <<4 |2 |EA ;/* Valid, EA */ - ctrl =gsm_control_send (dlci->gsm,CMD_MSC , modembits, len +1 ); + } + ctrl =gsm_control_send (dlci->gsm,CMD_MSC , modembits, len);if (ctrl ==NULL )return -ENOMEM ;return gsm_control_wait (dlci->gsm, ctrl);
Greg Kroah-Hartman
maintainerPATCH 168/177 tty: n_gsm: fix wrong signal octets encoding in MSC
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit 317f86af7f5d19f286ed2d181cbaef4a188c7f19 upstream.
n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. The value of the modem status command (MSC) frame
contains an address field, control signal and optional break signal octet.
The address field is encoded as described in chapter 5.2.1.2 with only one
octet (may be extended to more in future versions of the standard). Whereas
the control signal and break signal octet are always one byte each. This is
strange at first glance as it makes the EA bit redundant. However, the same
two octets are also encoded as header in convergence layer type 2 as
described in chapter 5.5.2. No header length field is given and the only
way to test if there is an optional break signal octet is via the EA flag
which extends the control signal octet with a break signal octet. Now it
becomes obvious how the EA bit for those two octets shall be encoded in the
MSC frame. The current implementation treats the signal octet different for
MSC frame and convergence layer type 2 header even though the standard
describes it for both in the same way.
Use the EA bit to encode the signal octets not only in the convergence
layer type 2 header but also in the MSC frame in the same way with either
1 or 2 bytes in case of an optional break signal. Adjust the receiving path
accordingly in gsm_control_modem().
--- drivers/tty/n_gsm.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-)
drivers/tty/n_gsm.c +5 -13
@@ -1083,7 +1083,6 @@ static void gsm_control_modem(struct gsm {unsigned int addr =0 ;unsigned int modem =0 ; -unsigned int brk =0 ;struct gsm_dlci *dlci;int len = clen;int slen;
@@ -1113,17 +1112,8 @@ static void gsm_control_modem(struct gsmreturn ; } len--; -if (len >0 ) { -while (gsm_read_ea (&brk, *dp++) ==0 ) { - len--; -if (len ==0 ) -return ; - } - modem <<=7 ; - modem |= (brk &0x7f ); - } tty =tty_port_tty_get (&dlci->port); -gsm_process_modem (tty, dlci, modem, slen); +gsm_process_modem (tty, dlci, modem, slen - len);if (tty) {tty_wakeup (tty);tty_kref_put (tty);
@@ -2895,8 +2885,10 @@ static int gsmtty_modem_update(struct gsint len =2 ; modembits[0 ] = (dlci->addr <<2 ) |2 |EA ;/* DLCI, Valid, EA */ - modembits[1 ] = (gsm_encode_modem (dlci) <<1 ) |EA ; -if (brk) { +if (!brk) { + modembits[1 ] = (gsm_encode_modem (dlci) <<1 ) |EA ; + }else { + modembits[1 ] =gsm_encode_modem (dlci) <<1 ; modembits[2 ] = (brk <<4 ) |2 |EA ;/* Length, Break, EA */ len++; }
Greg Kroah-Hartman
maintainerPATCH 169/177 tty: n_gsm: fix missing tty wakeup in convergence layer type 2
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit 1adf6fee58ca25fb6720b8d34c919dcf5425cc9c upstream.
gsm_control_modem() informs the virtual tty that more data can be written after receiving a control signal octet via modem status command (MSC). However, gsm_dlci_data() fails to do the same after receiving a control signal octet from the convergence layer type 2 header.
Add tty_wakeup() in gsm_dlci_data() for convergence layer type 2 to fix this.
--- drivers/tty/n_gsm.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/n_gsm.c +1 -0
@@ -1586,6 +1586,7 @@ static void gsm_dlci_data(struct gsm_dlc tty =tty_port_tty_get (port);if (tty) {gsm_process_modem (tty, dlci, modem, slen); +tty_wakeup (tty);tty_kref_put (tty); } fallthrough;
Greg Kroah-Hartman
maintainerPATCH 170/177 tty: n_gsm: fix reset fifo race condition
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit 73029a4d7161f8b6c0934553145ef574d2d0c645 upstream.
gsmtty_write() and gsm_dlci_data_output() properly guard the fifo access. However, gsm_dlci_close() and gsmtty_flush_buffer() modifies the fifo but do not guard this.
Add a guard here to prevent race conditions on parallel writes to the fifo.
--- drivers/tty/n_gsm.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/tty/n_gsm.c +8 -0
@@ -1417,13 +1417,17 @@ static int gsm_control_wait(struct gsm_mstatic void gsm_dlci_close (struct gsm_dlci *dlci) { +unsigned long flags; +del_timer (&dlci->t1);if (debug &8 )pr_debug ("DLCI %d goes closed.\n" , dlci->addr); dlci->state =DLCI_CLOSED ;if (dlci->addr !=0 ) {tty_port_tty_hangup (&dlci->port, false); +spin_lock_irqsave (&dlci->lock, flags);kfifo_reset (&dlci->fifo); +spin_unlock_irqrestore (&dlci->lock, flags);/* Ensure that gsmtty_open() can return. */ tty_port_set_initialized (&dlci->port,0 );wake_up_interruptible (&dlci->port.open_wait);
@@ -3078,13 +3082,17 @@ static unsigned int gsmtty_chars_in_buffstatic void gsmtty_flush_buffer (struct tty_struct *tty) {struct gsm_dlci *dlci = tty->driver_data; +unsigned long flags; +if (dlci->state ==DLCI_CLOSED )return ;/* Caution needed: If we implement reliable transport classes then the data being transmitted can't simply be junked once it has first hit the stack. Until then we can just blow it away */ +spin_lock_irqsave (&dlci->lock, flags);kfifo_reset (&dlci->fifo); +spin_unlock_irqrestore (&dlci->lock, flags);/* Need to unhook this DLCI from the transmit queue logic */ }
Greg Kroah-Hartman
maintainerPATCH 171/177 tty: n_gsm: fix incorrect UA handling
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit ff9166c623704337bd6fe66fce2838d9768a6634 upstream.
n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.4.4.2 states that any received unnumbered acknowledgment (UA) with its poll/final (PF) bit set to 0 shall be
discarded. Currently, all UA frame are handled in the same way regardless
of the PF bit. This does not comply with the standard.
Remove the UA case in gsm_queue() to process only UA frames with PF bit set
to 1 to abide the standard.
--- drivers/tty/n_gsm.c | 1 - 1 file changed, 1 deletion(-)
drivers/tty/n_gsm.c +0 -1
@@ -1816,7 +1816,6 @@ static void gsm_queue(struct gsm_mux *gsgsm_response (gsm, address,UA );gsm_dlci_close (dlci);break ; -case UA :case UA |PF :if (cr ==0 || dlci ==NULL )break ;
Greg Kroah-Hartman
maintainerPATCH 172/177 tty: n_gsm: fix software flow control handling
In reply to Greg Kroah-HartmanFrom: Daniel Starke <[email protected]>
commit f4f7d63287217ba25e5c80f5faae5e4f7118790e upstream.
n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.4.8.1 states that XON/XOFF characters
shall be used instead of Fcon/Fcoff command in advanced option mode to
handle flow control. Chapter 5.4.8.2 describes how XON/XOFF characters
shall be handled. Basic option mode only used Fcon/Fcoff commands and no
XON/XOFF characters. These are treated as data bytes here.
The current implementation uses the gsm_mux field 'constipated' to handle
flow control from the remote peer and the gsm_dlci field 'constipated' to
handle flow control from each DLCI. The later is unrelated to this patch.
The gsm_mux field is correctly set for Fcon/Fcoff commands ingsm_control_message(). However, the same is not true for XON/XOFF
characters in gsm1_receive().
Disable software flow control handling in the tty to allow explicit
handling by n_gsm.
Add the missing handling in advanced option mode for gsm_mux ingsm1_receive() to comply with the standard.
This patch depends on the following commit:
Commit 8838b2af23ca ("tty: n_gsm: fix SW flow control encoding/handling")
--- drivers/tty/n_gsm.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/tty/n_gsm.c +16 -0
@@ -233,6 +233,7 @@ struct gsm_mux {int initiator;/* Did we initiate connection */ bool dead;/* Has the mux been shut down */ struct gsm_dlci *dlci[NUM_DLCI ]; +int old_c_iflag;/* termios c_iflag value before attach */ bool constipated;/* Asked by remote to shut up */ spinlock_t tx_lock;
@@ -1959,6 +1960,16 @@ static void gsm0_receive(struct gsm_muxstatic void gsm1_receive (struct gsm_mux *gsm,unsigned char c) { +/* handle XON/XOFF */ +if ((c &ISO_IEC_646_MASK ) ==XON ) { + gsm->constipated = true; +return ; + }else if ((c &ISO_IEC_646_MASK ) ==XOFF ) { + gsm->constipated = false; +/* Kick the link in case it is idling */ +gsm_data_kick (gsm,NULL ); +return ; + }if (c ==GSM1_SOF ) {/* EOF is only valid in frame if we have got to the data state and received at least one byte (the FCS) */
@@ -2377,6 +2388,9 @@ static int gsmld_attach_gsm(struct tty_sint ret, i; gsm->tty =tty_kref_get (tty); +/* Turn off tty XON/XOFF handling to handle it explicitly. */ + gsm->old_c_iflag = tty->termios.c_iflag; + tty->termios.c_iflag &= (IXON |IXOFF ); ret =gsm_activate_mux (gsm);if (ret !=0 )tty_kref_put (gsm->tty);
@@ -2417,6 +2431,8 @@ static void gsmld_detach_gsm(struct tty_WARN_ON (tty != gsm->tty);for (i =1 ; i <NUM_DLCI ; i++)tty_unregister_device (gsm_tty_driver, base + i); +/* Restore tty XON/XOFF handling. */ + gsm->tty->termios.c_iflag = gsm->old_c_iflag;tty_kref_put (gsm->tty); gsm->tty =NULL ; }
Greg Kroah-Hartman
maintainerPATCH 173/177 perf symbol: Remove arch__symbols__fixup_end()
In reply to Greg Kroah-HartmanFrom: Namhyung Kim <[email protected]>
commit a5d20d42a2f2dc2b2f9e9361912062732414090d upstream.
Now the generic code can handle kallsyms fixup properly so no need to keep the arch-functions anymore.
--- tools/perf/arch/arm64/util/Build | 1 - tools/perf/arch/arm64/util/machine.c | 28 ---------------------------- tools/perf/arch/powerpc/util/Build | 1 - tools/perf/arch/powerpc/util/machine.c | 25 ------------------------- tools/perf/arch/s390/util/machine.c | 16 ---------------- tools/perf/util/symbol.c | 5 ----- tools/perf/util/symbol.h | 1 - 7 files changed, 77 deletions(-) delete mode 100644 tools/perf/arch/powerpc/util/machine.c
tools/perf/arch/arm64/util/Build +0 -1
@@ -1,5 +1,4 @@ perf-y += header.o -perf-y += machine.o perf-y += perf_regs.o perf-y += tsc.o perf-y += pmu.o
tools/perf/arch/arm64/util/machine.c deleted +0 -28
@@ -1,28 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -#include <inttypes.h> -#include <stdio.h> -#include <string.h> -#include "debug.h" -#include "symbol.h" - -/* On arm64, kernel text segment starts at high memory address, -* for example 0xffff 0000 8xxx xxxx. Modules start at a low memory -* address, like 0xffff 0000 00ax xxxx. When only small amount of -* memory is used by modules, gap between end of module's text segment -* and start of kernel text segment may reach 2G. -* Therefore do not fill this gap and do not assign it to the kernel dso map. -*/ - -#define SYMBOL_LIMIT (1 << 12)/* 4K */ - -void arch__symbols__fixup_end (struct symbol *p,struct symbol *c) -{ -if ((strchr (p->name,'[' ) &&strchr (c->name,'[' ) ==NULL ) || - (strchr (p->name,'[' ) ==NULL &&strchr (c->name,'[' ))) -/* Limit range of last symbol in module and kernel */ - p->end +=SYMBOL_LIMIT ; -else - p->end = c->start; -pr_debug4 ("%s sym:%s end:%#" PRIx64"\n" , __func__, p->name, p->end); -}
tools/perf/arch/powerpc/util/Build +0 -1
@@ -1,5 +1,4 @@ perf-y += header.o -perf-y += machine.o perf-y += kvm-stat.o perf-y += perf_regs.o perf-y += mem-events.o
tools/perf/arch/powerpc/util/machine.c deleted +0 -25
@@ -1,25 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -#include <inttypes.h> -#include <stdio.h> -#include <string.h> -#include <internal/lib.h> // page_size -#include "debug.h" -#include "symbol.h" - -/* On powerpc kernel text segment start at memory addresses, 0xc000000000000000 -* whereas the modules are located at very high memory addresses, -* for example 0xc00800000xxxxxxx. The gap between end of kernel text segment -* and beginning of first module's text segment is very high. -* Therefore do not fill this gap and do not assign it to the kernel dso map. -*/ - -void arch__symbols__fixup_end (struct symbol *p,struct symbol *c) -{ -if (strchr (p->name,'[' ) ==NULL &&strchr (c->name,'[' )) -/* Limit the range of last kernel symbol */ - p->end += page_size; -else - p->end = c->start; -pr_debug4 ("%s sym:%s end:%#" PRIx64"\n" , __func__, p->name, p->end); -}
tools/perf/arch/s390/util/machine.c +0 -16
@@ -35,19 +35,3 @@ int arch__fix_module_text_start(u64 *stareturn 0 ; } - -/* On s390 kernel text segment start is located at very low memory addresses, -* for example 0x10000. Modules are located at very high memory addresses, -* for example 0x3ff xxxx xxxx. The gap between end of kernel text segment -* and beginning of first module's text segment is very big. -* Therefore do not fill this gap and do not assign it to the kernel dso map. -*/ -void arch__symbols__fixup_end (struct symbol *p,struct symbol *c) -{ -if (strchr (p->name,'[' ) ==NULL &&strchr (c->name,'[' )) -/* Last kernel symbol mapped to end of page */ - p->end =roundup (p->end, page_size); -else - p->end = c->start; -pr_debug4 ("%s sym:%s end:%#" PRIx64"\n" , __func__, p->name, p->end); -}
tools/perf/util/symbol.c +0 -5
@@ -101,11 +101,6 @@ static int prefix_underscores_count(consreturn tail - str; } -void __weak arch__symbols__fixup_end (struct symbol *p,struct symbol *c) -{ - p->end = c->start; -} -const char *__weak arch__normalize_symbol_name (const char *name) {return name;
tools/perf/util/symbol.h +0 -1
@@ -230,7 +230,6 @@ const char *arch__normalize_symbol_name(#define SYMBOL_A 0#define SYMBOL_B 1 -void arch__symbols__fixup_end (struct symbol *p,struct symbol *c);int arch__compare_symbol_names (const char *namea,const char *nameb);int arch__compare_symbol_names_n (const char *namea,const char *nameb,unsigned int n);
Greg Kroah-Hartman
maintainerPATCH 174/177 eeprom: at25: Use DMA safe buffers
In reply to Greg Kroah-HartmanFrom: Christophe Leroy <[email protected]>
commit 5b47b751b760ee1c74a51660fd096aa148a362cd upstream.
Reading EEPROM fails with following warning:
[ 16.357496] ------------[ cut here ]------------ [ 16.357529] fsl_spi b01004c0.spi: rejecting DMA map of vmalloc memory [ 16.357698] WARNING: CPU: 0 PID: 371 at include/linux/dma-mapping.h:326 fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.357775] CPU: 0 PID: 371 Comm: od Not tainted 5.16.11-s3k-dev-01743-g19beecbfe9d6-dirty #109 [ 16.357806] NIP: c03fbc9c LR: c03fbc9c CTR: 00000000 [ 16.357825] REGS: e68d9b20 TRAP: 0700 Not tainted (5.16.11-s3k-dev-01743-g19beecbfe9d6-dirty) [ 16.357849] MSR: 00029032 <EE,ME,IR,DR,RI> CR: 24002282 XER: 00000000 [ 16.357931] [ 16.357931] GPR00: c03fbc9c e68d9be0 c26d06a0 00000039 00000001 c0d36364 c0e96428 00000027 [ 16.357931] GPR08: 00000001 00000000 00000023 3fffc000 24002282 100d3dd6 100a2ffc 00000000 [ 16.357931] GPR16: 100cd280 100b0000 00000000 aff54f7e 100d0000 100d0000 00000001 100cf328 [ 16.357931] GPR24: 100cf328 00000000 00000003 e68d9e30 c156b410 e67ab4c0 e68d9d38 c24ab278 [ 16.358253] NIP [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.358292] LR [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.358325] Call Trace: [ 16.358336] [e68d9be0] [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 (unreliable) [ 16.358388] [e68d9c00] [c03fcb44] fsl_spi_bufs.isra.0+0x94/0x1a0 [ 16.358436] [e68d9c20] [c03fd970] fsl_spi_do_one_msg+0x254/0x3dc [ 16.358483] [e68d9cb0] [c03f7e50] __spi_pump_messages+0x274/0x8a4 [ 16.358529] [e68d9ce0] [c03f9d30] __spi_sync+0x344/0x378 [ 16.358573] [e68d9d20] [c03fb52c] spi_sync+0x34/0x60 [ 16.358616] [e68d9d30] [c03b4dec] at25_ee_read+0x138/0x1a8 [ 16.358667] [e68d9e50] [c04a8fb8] bin_attr_nvmem_read+0x98/0x110 [ 16.358725] [e68d9e60] [c0204b14] kernfs_fop_read_iter+0xc0/0x1fc [ 16.358774] [e68d9e80] [c0168660] vfs_read+0x284/0x410 [ 16.358821] [e68d9f00] [c016925c] ksys_read+0x6c/0x11c [ 16.358863] [e68d9f30] [c00160e0] ret_from_syscall+0x0/0x28 ... [ 16.359608] ---[ end trace a4ce3e34afef0cb5 ]--- [ 16.359638] fsl_spi b01004c0.spi: unable to map tx dma
This is due to the AT25 driver using buffers on stack, which is not possible with CONFIG_VMAP_STACK.
As mentionned in kernel Documentation (Documentation/spi/spi-summary.rst):
- Follow standard kernel rules, and provide DMA-safe buffers in your messages. That way controller drivers using DMA aren't forced to make extra copies unless the hardware requires it (e.g. working around hardware errata that force the use of bounce buffering).
Modify the driver to use a buffer located in the at25 device structure which is allocated via kmalloc during probe.
Protect writes in this new buffer with the driver's mutex.
--- drivers/misc/eeprom/at25.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
drivers/misc/eeprom/at25.c +11 -8
@@ -30,6 +30,8 @@*/ #define FM25_SN_LEN 8/* serial number length */ +#define EE_MAXADDRLEN 3/* 24 bit addresses, up to 2 MBytes */ +struct at25_data {struct spi_device *spi;struct mutex lock;
@@ -38,6 +40,7 @@ struct at25_data {struct nvmem_config nvmem_config;struct nvmem_device *nvmem;u8 sernum[FM25_SN_LEN ]; +u8 command[EE_MAXADDRLEN +1 ]; };#define AT25_WREN 0x06/* latch the write enable */
@@ -60,8 +63,6 @@ struct at25_data {#define FM25_ID_LEN 9/* ID length */ -#define EE_MAXADDRLEN 3/* 24 bit addresses, up to 2 MBytes */ -/* Specs often allow 5 msec for a page write, sometimes 20 msec; * it's important to recover from write timeouts. */
@@ -76,7 +77,6 @@ static int at25_ee_read(void *priv, unsi {struct at25_data *at25 = priv;char *buf = val; -u8 command[EE_MAXADDRLEN +1 ];u8 *cp;ssize_t status;struct spi_transfer t[2 ];
@@ -90,12 +90,15 @@ static int at25_ee_read(void *priv, unsiif (unlikely (!count))return -EINVAL ; - cp = command; + cp = at25->command; instr =AT25_READ ;if (at25->chip.flags &EE_INSTR_BIT3_IS_ADDR )if (offset >= (1U << (at25->addrlen *8 ))) instr |=AT25_INSTR_BIT3 ; + +mutex_lock (&at25->lock); + *cp++ = instr;/* 8/16/24-bit address is written MSB first */
@@ -114,7 +117,7 @@ static int at25_ee_read(void *priv, unsispi_message_init (&m);memset (t,0 ,sizeof (t)); - t[0 ].tx_buf = command; + t[0 ].tx_buf = at25->command; t[0 ].len = at25->addrlen +1 ;spi_message_add_tail (&t[0 ], &m);
@@ -122,8 +125,6 @@ static int at25_ee_read(void *priv, unsi t[1 ].len = count;spi_message_add_tail (&t[1 ], &m); -mutex_lock (&at25->lock); -/* Read it all at once. * * REVISIT that's potentially a problem with large chips, if
@@ -151,7 +152,7 @@ static int fm25_aux_read(struct at25_datspi_message_init (&m);memset (t,0 ,sizeof (t)); - t[0 ].tx_buf = &command; + t[0 ].tx_buf = at25->command; t[0 ].len =1 ;spi_message_add_tail (&t[0 ], &m);
@@ -161,6 +162,8 @@ static int fm25_aux_read(struct at25_datmutex_lock (&at25->lock); + at25->command[0 ] = command; + status =spi_sync (at25->spi, &m);dev_dbg (&at25->spi->dev,"read %d aux bytes --> %d\n" , len, status);
Greg Kroah-Hartman
maintainerPATCH 175/177 objtool: Fix code relocs vs weak symbols
In reply to Greg Kroah-HartmanFrom: Peter Zijlstra <[email protected]>
commit 4abff6d48dbcea8200c7ea35ba70c242d128ebf3 upstream.
Occasionally objtool driven code patching (think .static_call_sites .retpoline_sites etc..) goes sideways and it tries to patch an instruction that doesn't match.
Much head-scatching and cursing later the problem is as outlined below and affects every section that objtool generates for us, very much including the ORC data. The below uses .static_call_sites because it's convenient for demonstration purposes, but as mentioned the ORC sections, .retpoline_sites and __mount_loc are all similarly affected.
Consider:
foo-weak.c:
extern void __SCT__foo(void);
__attribute__((weak)) void foo(void)
{
return __SCT__foo();}
foo.c:
extern void __SCT__foo(void); extern void my_foo(void);
void foo(void)
{
my_foo();
return __SCT__foo();}
These generate the obvious code
(gcc -O2 -fcf-protection=none -fno-asynchronous-unwind-tables -c foo*.c):
foo-weak.o:
0000000000000000 <foo>:
0: e9 00 00 00 00 jmpq 5 <foo+0x5> 1: R_X86_64_PLT32 __SCT__foo-0x4
foo.o:
0000000000000000 <foo>:
0: 48 83 ec 08 sub $0x8,%rsp 4: e8 00 00 00 00 callq 9 <foo+0x9> 5: R_X86_64_PLT32 my_foo-0x4 9: 48 83 c4 08 add $0x8,%rsp d: e9 00 00 00 00 jmpq 12 <foo+0x12> e: R_X86_64_PLT32 __SCT__foo-0x4
Now, when we link these two files together, you get something like (ld -r -o foos.o foo-weak.o foo.o):
foos.o:
0000000000000000 <foo-0x10>:
0: e9 00 00 00 00 jmpq 5 <foo-0xb> 1: R_X86_64_PLT32 __SCT__foo-0x4 5: 66 2e 0f 1f 84 00 00 00 00 00 nopw %cs:0x0(%rax,%rax,1) f: 90 nop
0000000000000010 <foo>:
10: 48 83 ec 08 sub $0x8,%rsp 14: e8 00 00 00 00 callq 19 <foo+0x9> 15: R_X86_64_PLT32 my_foo-0x4 19: 48 83 c4 08 add $0x8,%rsp 1d: e9 00 00 00 00 jmpq 22 <foo+0x12> 1e: R_X86_64_PLT32 __SCT__foo-0x4
Noting that ld preserves the weak function text, but strips the symbol off of it (hence objdump doing that funny negative offset thing). This does lead to 'interesting' unused code issues with objtool when ran on linked objects, but that seems to be working (fingers crossed).
So far so good.. Now lets consider the objtool static_call output section (readelf output, old binutils):
foo-weak.o:
Relocation section '.rela.static_call_sites' at offset 0x2c8 contains 1 entry:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000200000002 R_X86_64_PC32 0000000000000000 .text + 0 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
foo.o:
Relocation section '.rela.static_call_sites' at offset 0x310 contains 2 entries:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000200000002 R_X86_64_PC32 0000000000000000 .text + d 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
foos.o:
Relocation section '.rela.static_call_sites' at offset 0x430 contains 4 entries:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000100000002 R_X86_64_PC32 0000000000000000 .text + 0 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1 0000000000000008 0000000100000002 R_X86_64_PC32 0000000000000000 .text + 1d 000000000000000c 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
So we have two patch sites, one in the dead code of the weak foo and one in the real foo. All is well.
*HOWEVER*, when the toolchain strips unused section symbols it generates things like this (using new enough binutils):
foo-weak.o:
Relocation section '.rela.static_call_sites' at offset 0x2c8 contains 1 entry:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000200000002 R_X86_64_PC32 0000000000000000 foo + 0 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
foo.o:
Relocation section '.rela.static_call_sites' at offset 0x310 contains 2 entries:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000200000002 R_X86_64_PC32 0000000000000000 foo + d 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
foos.o:
Relocation section '.rela.static_call_sites' at offset 0x430 contains 4 entries:
Offset Info Type Symbol's Value Symbol's Name + Addend
0000000000000000 0000000100000002 R_X86_64_PC32 0000000000000000 foo + 0 0000000000000004 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1 0000000000000008 0000000100000002 R_X86_64_PC32 0000000000000000 foo + d 000000000000000c 0000000d00000002 R_X86_64_PC32 0000000000000000 __SCT__foo + 1
And now we can see how that foos.o .static_call_sites goes side-ways, we now have _two_ patch sites in foo. One for the weak symbol at foo+0 (which is no longer a static_call site!) and one at foo+d which is in fact the right location.
This seems to happen when objtool cannot find a section symbol, in which case it falls back to any other symbol to key off of, however in this case that goes terribly wrong!
As such, teach objtool to create a section symbol when there isn't one.
--- tools/objtool/elf.c | 187 +++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 165 insertions(+), 22 deletions(-)
tools/objtool/elf.c +165 -22
@@ -514,37 +514,180 @@ int elf_add_reloc(struct elf *elf, strucreturn 0 ; } -int elf_add_reloc_to_insn (struct elf *elf,struct section *sec, -unsigned long offset,unsigned int type, -struct section *insn_sec,unsigned long insn_off) +/* +* Ensure that any reloc section containing references to @sym is marked +* changed such that it will get re-generated in elf_rebuild_reloc_sections() +* with the new symbol index. +*/ +static void elf_dirty_reloc_sym (struct elf *elf,struct symbol *sym) +{ +struct section *sec; + +list_for_each_entry (sec, &elf->sections, list) { +struct reloc *reloc; + +if (sec->changed) +continue ; + +list_for_each_entry (reloc, &sec->reloc_list, list) { +if (reloc->sym == sym) { + sec->changed = true; +break ; + } + } + } +} + +/* +* Move the first global symbol, as per sh_info, into a new, higher symbol +* index. This fees up the shndx for a new local symbol. +*/ +static int elf_move_global_symbol (struct elf *elf,struct section *symtab, +struct section *symtab_shndx) { +Elf_Data *data, *shndx_data =NULL ; +Elf32_Word first_non_local;struct symbol *sym; -int addend; +Elf_Scn *s; -if (insn_sec->sym) { - sym = insn_sec->sym; - addend = insn_off; + first_non_local = symtab->sh.sh_info; - }else { -/* -* The Clang assembler strips section symbols, so we have to -* reference the function symbol instead: -*/ - sym =find_symbol_containing (insn_sec, insn_off); -if (!sym) { -/* -* Hack alert. This happens when we need to reference -* the NOP pad insn immediately after the function. -*/ - sym =find_symbol_containing (insn_sec, insn_off -1 ); + sym =find_symbol_by_index (elf, first_non_local); +if (!sym) { +WARN ("no non-local symbols !?" ); +return first_non_local; + } + + s =elf_getscn (elf->elf, symtab->idx); +if (!s) { +WARN_ELF ("elf_getscn" ); +return -1 ; + } + + data =elf_newdata (s); +if (!data) { +WARN_ELF ("elf_newdata" ); +return -1 ; + } + + data->d_buf = &sym->sym; + data->d_size =sizeof (sym->sym); + data->d_align =1 ; + data->d_type =ELF_T_SYM ; + + sym->idx = symtab->sh.sh_size /sizeof (sym->sym); +elf_dirty_reloc_sym (elf, sym); + + symtab->sh.sh_info +=1 ; + symtab->sh.sh_size += data->d_size; + symtab->changed = true; + +if (symtab_shndx) { + s =elf_getscn (elf->elf, symtab_shndx->idx); +if (!s) { +WARN_ELF ("elf_getscn" ); +return -1 ; } -if (!sym) { -WARN ("can't find symbol containing %s+0x%lx" , insn_sec->name, insn_off); + shndx_data =elf_newdata (s); +if (!shndx_data) { +WARN_ELF ("elf_newshndx_data" );return -1 ; } - addend = insn_off - sym->offset; + shndx_data->d_buf = &sym->sec->idx; + shndx_data->d_size =sizeof (Elf32_Word); + shndx_data->d_align =4 ; + shndx_data->d_type =ELF_T_WORD ; + + symtab_shndx->sh.sh_size +=4 ; + symtab_shndx->changed = true; + } + +return first_non_local; +} + +static struct symbol * +elf_create_section_symbol (struct elf *elf,struct section *sec) +{ +struct section *symtab, *symtab_shndx; +Elf_Data *shndx_data =NULL ; +struct symbol *sym; +Elf32_Word shndx; + + symtab =find_section_by_name (elf,".symtab" ); +if (symtab) { + symtab_shndx =find_section_by_name (elf,".symtab_shndx" ); +if (symtab_shndx) + shndx_data = symtab_shndx->data; + }else { +WARN ("no .symtab" ); +return NULL ; + } + + sym =malloc (sizeof (*sym)); +if (!sym) { +perror ("malloc" ); +return NULL ; + } +memset (sym,0 ,sizeof (*sym)); + + sym->idx =elf_move_global_symbol (elf, symtab, symtab_shndx); +if (sym->idx <0 ) { +WARN ("elf_move_global_symbol" ); +return NULL ; + } + + sym->name = sec->name; + sym->sec = sec; + +// st_name 0 + sym->sym.st_info =GELF_ST_INFO (STB_LOCAL ,STT_SECTION ); +// st_other 0 +// st_value 0 +// st_size 0 + shndx = sec->idx; +if (shndx >=SHN_UNDEF && shndx <SHN_LORESERVE ) { + sym->sym.st_shndx = shndx; +if (!shndx_data) + shndx =0 ; + }else { + sym->sym.st_shndx =SHN_XINDEX ; +if (!shndx_data) { +WARN ("no .symtab_shndx" ); +return NULL ; + } + } + +if (!gelf_update_symshndx (symtab->data, shndx_data, sym->idx, &sym->sym, shndx)) { +WARN_ELF ("gelf_update_symshndx" ); +return NULL ; + } + +elf_add_symbol (elf, sym); + +return sym; +} + +int elf_add_reloc_to_insn (struct elf *elf,struct section *sec, +unsigned long offset,unsigned int type, +struct section *insn_sec,unsigned long insn_off) +{ +struct symbol *sym = insn_sec->sym; +int addend = insn_off; + +if (!sym) { +/* +* Due to how weak functions work, we must use section based +* relocations. Symbol based relocations would result in the +* weak and non-weak function annotations being overlaid on the +* non-weak function after linking. +*/ + sym =elf_create_section_symbol (elf, insn_sec); +if (!sym) +return -1 ; + + insn_sec->sym = sym; }return elf_add_reloc (elf, sec, offset, type, sym, addend);
Greg Kroah-Hartman
maintainerPATCH 176/177 objtool: Fix type of reloc::addend
In reply to Greg Kroah-HartmanFrom: Peter Zijlstra <[email protected]>
commit c087c6e7b551b7f208c0b852304f044954cf2bb3 upstream.
Elf{32,64}_Rela::r_addend is of type: Elf{32,64}_Sword, that means that our reloc::addend needs to be long or face tuncation issues when we do elf_rebuild_reloc_section():
- 107: 48 b8 00 00 00 00 00 00 00 00 movabs $0x0,%rax 109: R_X86_64_64 level4_kernel_pgt+0x80000067 + 107: 48 b8 00 00 00 00 00 00 00 00 movabs $0x0,%rax 109: R_X86_64_64 level4_kernel_pgt-0x7fffff99
--- tools/objtool/check.c | 8 ++++---- tools/objtool/elf.c | 2 +- tools/objtool/include/objtool/elf.h | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-)
tools/objtool/check.c +4 -4
@@ -393,12 +393,12 @@ static int add_dead_ends(struct objtool_else if (reloc->addend == reloc->sym->sec->sh.sh_size) { insn =find_last_insn (file, reloc->sym->sec);if (!insn) { -WARN ("can't find unreachable insn at %s+0x%x" , +WARN ("can't find unreachable insn at %s+0x%lx" , reloc->sym->sec->name, reloc->addend);return -1 ; } }else { -WARN ("can't find unreachable insn at %s+0x%x" , +WARN ("can't find unreachable insn at %s+0x%lx" , reloc->sym->sec->name, reloc->addend);return -1 ; }
@@ -428,12 +428,12 @@ reachable:else if (reloc->addend == reloc->sym->sec->sh.sh_size) { insn =find_last_insn (file, reloc->sym->sec);if (!insn) { -WARN ("can't find reachable insn at %s+0x%x" , +WARN ("can't find reachable insn at %s+0x%lx" , reloc->sym->sec->name, reloc->addend);return -1 ; } }else { -WARN ("can't find reachable insn at %s+0x%x" , +WARN ("can't find reachable insn at %s+0x%lx" , reloc->sym->sec->name, reloc->addend);return -1 ; }
tools/objtool/elf.c +1 -1
@@ -485,7 +485,7 @@ static struct section *elf_create_reloc_ int reltype);int elf_add_reloc (struct elf *elf,struct section *sec,unsigned long offset, -unsigned int type,struct symbol *sym,int addend) +unsigned int type,struct symbol *sym,long addend) {struct reloc *reloc;
tools/objtool/include/objtool/elf.h +2 -2
@@ -69,7 +69,7 @@ struct reloc {struct symbol *sym;unsigned long offset;unsigned int type; -int addend; +long addend;int idx;bool jump_table_start; };
@@ -131,7 +131,7 @@ struct elf *elf_open_read(const char *nastruct section *elf_create_section (struct elf *elf,const char *name,unsigned int sh_flags,size_t entsize,int nr);int elf_add_reloc (struct elf *elf,struct section *sec,unsigned long offset, -unsigned int type,struct symbol *sym,int addend); +unsigned int type,struct symbol *sym,long addend);int elf_add_reloc_to_insn (struct elf *elf,struct section *sec,unsigned long offset,unsigned int type,struct section *insn_sec,unsigned long insn_off);
Greg Kroah-Hartman
maintainerPATCH 177/177 powerpc/64: Add UADDR64 relocation support
In reply to Greg Kroah-HartmanFrom: Alexey Kardashevskiy <[email protected]>
commit d799769188529abc6cbf035a10087a51f7832b6b upstream.
When ld detects unaligned relocations, it emits R_PPC64_UADDR64 relocations instead of R_PPC64_RELATIVE. Currently R_PPC64_UADDR64 are detected by arch/powerpc/tools/relocs_check.sh and expected not to work. Below is a simple chunk to trigger this behaviour (this disables optimization for the demonstration purposes only, this also happens with -O1/-O2 when CONFIG_PRINTK_INDEX=y, for example):
\#pragma GCC push_options
\#pragma GCC optimize ("O0")
struct entry {
const char *file;
int line;
} __attribute__((packed));
static const struct entry e1 = { .file = __FILE__, .line = __LINE__ };
static const struct entry e2 = { .file = __FILE__, .line = __LINE__ };
...
prom_printf("e1=%s %lx %lx\n", e1.file, (unsigned long) e1.file, mfmsr());
prom_printf("e2=%s %lx\n", e2.file, (unsigned long) e2.file);
\#pragma GCC pop_optionsThis adds support for UADDR64 for 64bit. This reuses __dynamic_symtab from the 32bit code which supports more relocation types already.
Because RELACOUNT includes only R_PPC64_RELATIVE, this replaces it with RELASZ which is the size of all relocation records.
--- arch/powerpc/kernel/reloc_64.S | 67 +++++++++++++++++++++++++------------ arch/powerpc/kernel/vmlinux.lds.S | 2 - arch/powerpc/tools/relocs_check.sh | 7 --- 3 files changed, 48 insertions(+), 28 deletions(-)
arch/powerpc/kernel/reloc_64.S +47 -20
@@ -8,8 +8,10 @@ #include <asm/ppc_asm.h> RELA = 7 -RELACOUNT = 0x6ffffff9 +RELASZ = 8 +RELAENT = 9 R_PPC64_RELATIVE = 22 +R_PPC64_UADDR64 = 43 /* * r3 = desired final address of kernel
@@ -25,29 +27,38 @@ _GLOBAL(relocate) add r9,r9,r12 /* r9 has runtime addr of .rela.dyn section */ ld r10,(p_st - 0b)(r12) add r10,r10,r12 /* r10 has runtime addr of _stext */ + ld r13,(p_sym - 0b)(r12) + add r13,r13,r12 /* r13 has runtime addr of .dynsym */ /* - * Scan the dynamic section for the RELA and RELACOUNT entries. + * Scan the dynamic section for the RELA, RELASZ and RELAENT entries. */ li r7,0 li r8,0 -1: ld r6,0(r11) /* get tag */ +.Ltags: + ld r6,0(r11) /* get tag */ cmpdi r6,0 - beq 4f /* end of list */ + beq .Lend_of_list /* end of list */ cmpdi r6,RELA bne 2f ld r7,8(r11) /* get RELA pointer in r7 */ - b 3f -2: addis r6,r6,(-RELACOUNT)@ha - cmpdi r6,RELACOUNT@l + b 4f +2: cmpdi r6,RELASZ bne 3f - ld r8,8(r11) /* get RELACOUNT value in r8 */ -3: addi r11,r11,16 - b 1b -4: cmpdi r7,0 /* check we have both RELA and RELACOUNT */ + ld r8,8(r11) /* get RELASZ value in r8 */ + b 4f +3: cmpdi r6,RELAENT + bne 4f + ld r12,8(r11) /* get RELAENT value in r12 */ +4: addi r11,r11,16 + b .Ltags +.Lend_of_list: + cmpdi r7,0 /* check we have RELA, RELASZ, RELAENT */ cmpdi cr1,r8,0 - beq 6f - beq cr1,6f + beq .Lout + beq cr1,.Lout + cmpdi r12,0 + beq .Lout /* * Work out linktime address of _stext and hence the
@@ -62,23 +73,39 @@ _GLOBAL(relocate) /* * Run through the list of relocations and process the - * R_PPC64_RELATIVE ones. + * R_PPC64_RELATIVE and R_PPC64_UADDR64 ones. */ + divd r8,r8,r12 /* RELASZ / RELAENT */ mtctr r8 -5: ld r0,8(9) /* ELF64_R_TYPE(reloc->r_info) */ +.Lrels: ld r0,8(r9) /* ELF64_R_TYPE(reloc->r_info) */ cmpdi r0,R_PPC64_RELATIVE - bne 6f + bne .Luaddr64 ld r6,0(r9) /* reloc->r_offset */ ld r0,16(r9) /* reloc->r_addend */ + b .Lstore +.Luaddr64: + srdi r14,r0,32 /* ELF64_R_SYM(reloc->r_info) */ + clrldi r0,r0,32 + cmpdi r0,R_PPC64_UADDR64 + bne .Lnext + ld r6,0(r9) + ld r0,16(r9) + mulli r14,r14,24 /* 24 == sizeof(elf64_sym) */ + add r14,r14,r13 /* elf64_sym[ELF64_R_SYM] */ + ld r14,8(r14) + add r0,r0,r14 +.Lstore: add r0,r0,r3 stdx r0,r7,r6 - addi r9,r9,24 - bdnz 5b - -6: blr +.Lnext: + add r9,r9,r12 + bdnz .Lrels +.Lout: + blr .balign 8 p_dyn: .8byte __dynamic_start - 0b p_rela: .8byte __rela_dyn_start - 0b +p_sym: .8byte __dynamic_symtab - 0b p_st: .8byte _stext - 0b
arch/powerpc/kernel/vmlinux.lds.S +0 -2
@@ -275,9 +275,7 @@ SECTIONS . = ALIGN(8); .dynsym : AT(ADDR(.dynsym) - LOAD_OFFSET) { -#ifdef CONFIG_PPC32 __dynamic_symtab = .; -#endif *(.dynsym) } .dynstr : AT(ADDR(.dynstr) - LOAD_OFFSET) { *(.dynstr) }
arch/powerpc/tools/relocs_check.sh +1 -6
@@ -39,6 +39,7 @@ $objdump -R "$vmlinux" | # R_PPC_NONE grep -F -w -v 'R_PPC64_RELATIVE R_PPC64_NONE +R_PPC64_UADDR64 R_PPC_ADDR16_LO R_PPC_ADDR16_HI R_PPC_ADDR16_HA
@@ -54,9 +55,3 @@ fi num_bad=$(echo "$bad_relocs" | wc -l) echo "WARNING: $num_bad bad relocations" echo "$bad_relocs" - -# If we see this type of relocation it's an idication that -# we /may/ be using an old version of binutils. -if echo "$bad_relocs" | grep -q -F -w R_PPC64_UADDR64; then - echo "WARNING: You need at least binutils >= 2.19 to build a CONFIG_RELOCATABLE kernel" -fi
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Built and booted successfully on RISC-V RV64 (HiFive Unmatched).
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
## Build
* kernel: 5.15.38-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git branch: linux-5.15.y
* git commit: c8851235b4b74c00f49cc1cf05ab6f4a483e978e
* git describe: v5.15.37-178-gc8851235b4b7
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.37-178-gc8851235b4b7
## Test Regressions (compared to v5.15.37)
No test regressions found.
## Metric Regressions (compared to v5.15.37)
No metric regressions found.
## Test Fixes (compared to v5.15.37)
No test fixes found.
## Metric Fixes (compared to v5.15.37)
No metric fixes found.
## Test result summary
total: 106754, pass: 90235, fail: 665, skip: 14702, xfail: 1152
## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 291 total, 291 passed, 0 failed
* arm64: 41 total, 41 passed, 0 failed
* i386: 39 total, 39 passed, 0 failed
* juno-r2: 1 total, 1 passed, 0 failed
* mips: 37 total, 37 passed, 0 failed
* parisc: 12 total, 12 passed, 0 failed
* powerpc: 60 total, 54 passed, 6 failed
* riscv: 27 total, 22 passed, 5 failed
* s390: 21 total, 21 passed, 0 failed
* sh: 24 total, 24 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x86_64: 41 total, 41 passed, 0 failed
## Test suites summary
* fwts
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-bpf
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* linux-log-parser
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-controllers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-open-posix-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* network-basic-tests
* packetdrill
* perf
* perf/Zstd-perf.data-compression
* rcutorture
* ssuite
* v4l2-compliance
* vdso
--
Linaro LKFT
https://lkft.linaro.org
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v5.15:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
114 tests: 110 pass, 4 failLinux version: 5.15.38-rc1-gc8851235b4b7
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04Test failures: tegra194-p2972-0000: boot.py
tegra194-p2972-0000: pm-system-suspend.sh
tegra20-ventana: pm-system-suspend.shJon
Greg Kroah-Hartman
maintainerQuoted 28 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v5.15:
10 builds: 10 pass, 0 fail 28 boots: 28 pass, 0 fail 114 tests: 110 pass, 4 failLinux version: 5.15.38-rc1-gc8851235b4b7
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
Quoted 7 lines
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000, tegra20-ventana, tegra210-p2371-2180, tegra210-p3450-0000, tegra30-cardhu-a04Test failures: tegra194-p2972-0000:
boot.pytegra194-p2972-0000: pm-system-suspend.sh tegra20-ventana: pm-system-suspend.sh
Odd, any ideas why things failed here?
thanks,
greg k-h
Jon Hunter
maintainerQuoted 33 lines · Greg Kroah-Hartman
Quoted 32 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v5.15:
10 builds: 10 pass, 0 fail 28 boots: 28 pass, 0 fail 114 tests: 110 pass, 4 failLinux version: 5.15.38-rc1-gc8851235b4b7
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000, tegra20-ventana, tegra210-p2371-2180, tegra210-p3450-0000, tegra30-cardhu-a04
Quoted 5 lines
Quoted 3 lines
Test failures: tegra194-p2972-0000:
boot.pytegra194-p2972-0000: pm-system-suspend.sh tegra20-ventana: pm-system-suspend.shOdd, any ideas why things failed here?
Odd, indeed. Usually, if something fails I catch it and check to see if this is a proper failure. Looks like something went awry and we got a false-positive. I have checked again and all seems to be passing fine ...
Test results for stable-v5.15:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
114 tests: 114 pass, 0 failLinux version: 5.15.39-rc1-gab77581473a3
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04Sorry for the noise here.
Jon
Signature · 1 line
nvpublic
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
Build results:
total: 156 pass: 156 fail: 0 Qemu test results: total: 488 pass: 488 fail: 0
Guenter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.15.38 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri, 06 May 2022 15:25:19 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.38-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.15.y
and the diffstat can be found below.thanks,
greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels:
Signature · 1 line
Florian