Factorization of messages with similar meaning
PATCH v5 3/11 i18n: turn "options are incompatible" into "cannot be used together"
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- apply.c | 2 +- archive.c | 2 +- builtin/add.c | 8 ++++---- builtin/branch.c | 2 +- builtin/checkout.c | 8 ++++---- builtin/clone.c | 2 +- builtin/commit.c | 6 +++--- builtin/describe.c | 2 +- builtin/difftool.c | 2 +- builtin/fast-export.c | 2 +- builtin/index-pack.c | 2 +- builtin/ls-files.c | 2 +- builtin/merge.c | 4 ++-- builtin/pack-objects.c | 2 +- builtin/push.c | 8 ++++---- builtin/rebase.c | 6 +++--- builtin/repack.c | 4 ++-- builtin/reset.c | 4 ++-- builtin/rev-list.c | 2 +- builtin/show-branch.c | 4 ++-- builtin/stash.c | 4 ++-- builtin/tag.c | 4 ++-- revision.c | 20 ++++++++++---------- t/t2026-checkout-pathspec-file.sh | 4 ++-- t/t2072-restore-pathspec-file.sh | 2 +- t/t3431-rebase-fork-point.sh | 2 +- t/t3704-add-pathspec-file.sh | 6 +++--- t/t3909-stash-pathspec-file.sh | 2 +- t/t5606-clone-options.sh | 2 +- t/t7107-reset-pathspec-file.sh | 2 +- t/t7526-commit-pathspec-file.sh | 6 +++--- 31 files changed, 64 insertions(+), 64 deletions(-)
apply.c +1 -1
@@ -133,7 +133,7 @@ int check_apply_state(struct apply_state *state, int force_apply)int is_not_gitdir = !startup_info->have_repository;if (state->apply_with_reject && state->threeway) -return error (_ ("--reject and --3way cannot be used together." )); +return error (_ ("options '%s' and '%s' cannot be used together" ),"--reject" ,"--3way" );if (state->threeway) {if (is_not_gitdir)return error (_ ("--3way outside a repository" ));
archive.c +1 -1
@@ -581,7 +581,7 @@ static int parse_archive_args(int argc, const char **argv,if (output)die (_ ("Unexpected option --output" ));if (is_remote && args->extra_files.nr) -die (_ ("Options --add-file and --remote cannot be used together" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--add-file" ,"--remote" );if (!base) base ="" ;
builtin/add.c +4 -4
@@ -507,9 +507,9 @@ int cmd_add(int argc, const char **argv, const char *prefix) add_interactive =1 ;if (add_interactive) {if (show_only) -die (_ ("--dry-run is incompatible with --interactive/--patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--dry-run" ,"--interactive/--patch" );if (pathspec_from_file) -die (_ ("--pathspec-from-file is incompatible with --interactive/--patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--interactive/--patch" );exit (interactive_add (argv +1 , prefix, patch_interactive)); }if (legacy_stash_p) {
@@ -526,7 +526,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)if (edit_interactive) {if (pathspec_from_file) -die (_ ("--pathspec-from-file is incompatible with --edit" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--edit" );return (edit_patch (argc, argv, prefix)); } argc--;
@@ -538,7 +538,7 @@ int cmd_add(int argc, const char **argv, const char *prefix) addremove =0 ;/* "-u" was given but not "-A" */ if (addremove && take_worktree_changes) -die (_ ("-A and -u are mutually incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"-A" ,"-u" );if (!show_only && ignore_missing)die (_ ("Option --ignore-missing can only be used together with --dry-run" ));
builtin/branch.c +1 -1
@@ -722,7 +722,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)finalize_colopts (&colopts,-1 );if (filter.verbose) {if (explicitly_enable_column (colopts)) -die (_ ("--column and --verbose are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--column" ,"--verbose" ); colopts =0 ; }
builtin/checkout.c +4 -4
@@ -464,10 +464,10 @@ static int checkout_paths(const struct checkout_opts *opts,die (_ ("'%s' cannot be used with updating paths" ),"--detach" );if (opts->merge && opts->patch_mode) -die (_ ("'%s' cannot be used with %s" ),"--merge" ,"--patch" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--merge" ,"--patch" );if (opts->ignore_unmerged && opts->merge) -die (_ ("'%s' cannot be used with %s" ), +die (_ ("options '%s' and '%s' cannot be used together" ), opts->ignore_unmerged_opt,"-m" );if (opts->new_branch)
@@ -1749,10 +1749,10 @@ static int checkout_main(int argc, const char **argv, const char *prefix,die (_ ("--pathspec-from-file is incompatible with pathspec arguments" ));if (opts->force_detach) -die (_ ("--pathspec-from-file is incompatible with --detach" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--detach" );if (opts->patch_mode) -die (_ ("--pathspec-from-file is incompatible with --patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--patch" ); parse_pathspec_file(&opts->pathspec, 0, 0,
builtin/clone.c +1 -1
@@ -903,7 +903,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)die (_ ("--bare and --origin %s options are incompatible." ), option_origin);if (real_git_dir) -die (_ ("--bare and --separate-git-dir are incompatible." )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--bare" ,"--separate-git-dir" ); option_no_checkout =1 ; }
builtin/commit.c +3 -3
@@ -355,10 +355,10 @@ static const char *prepare_index(const char **argv, const char *prefix,if (pathspec_from_file) {if (interactive) -die (_ ("--pathspec-from-file is incompatible with --interactive/--patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--interactive/--patch" );if (all) -die (_ ("--pathspec-from-file with -a does not make sense" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"-a" );if (pathspec.nr)die (_ ("--pathspec-from-file is incompatible with pathspec arguments" ));
@@ -1193,7 +1193,7 @@ static void finalize_deferred_config(struct wt_status *s) status_format == STATUS_FORMAT_UNSPECIFIED) status_format =STATUS_FORMAT_PORCELAIN ; else if (status_format == STATUS_FORMAT_LONG) - die(_("--long and -z are incompatible")); + die(_("options '%s' and '%s' cannot be used together"), "--long", "-z"); }if (use_deferred_config && status_format ==STATUS_FORMAT_UNSPECIFIED )
builtin/describe.c +1 -1
@@ -590,7 +590,7 @@ int cmd_describe(int argc, const char **argv, const char *prefix) save_commit_buffer =0 ;if (longformat && abbrev ==0 ) -die (_ ("--long is incompatible with --abbrev=0" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--long" ,"--abbrev=0" );if (contains) {struct string_list_item *item;
builtin/difftool.c +1 -1
@@ -730,7 +730,7 @@ int cmd_difftool(int argc, const char **argv, const char *prefix)setenv (GIT_DIR_ENVIRONMENT ,absolute_path (get_git_dir ()),1 );setenv (GIT_WORK_TREE_ENVIRONMENT ,absolute_path (get_git_work_tree ()),1 ); }else if (dir_diff) -die (_ ("--dir-diff is incompatible with --no-index" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--dir-diff" ,"--no-index" );if (use_gui_tool + !!difftool_cmd + !!extcmd >1 )die (_ ("options '%s', '%s', and '%s' cannot be used together" ),"--gui" ,"--tool" ,"--extcmd" );
builtin/fast-export.c +1 -1
@@ -1269,7 +1269,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)printf ("feature done\n" );if (import_filename && import_filename_if_exists) -die (_ ("Cannot pass both --import-marks and --import-marks-if-exists" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--import-marks" ,"--import-marks-if-exists" );if (import_filename)import_marks (import_filename,0 );else if (import_filename_if_exists)
builtin/index-pack.c +1 -1
@@ -1849,7 +1849,7 @@ int cmd_index_pack(int argc, const char **argv, const char *prefix)if (from_stdin && !startup_info->have_repository)die (_ ("--stdin requires a git repository" ));if (from_stdin && hash_algo) -die (_ ("--object-format cannot be used with --stdin" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--object-format" ,"--stdin" );if (!index_name && pack_name) index_name =derive_filename (pack_name,"pack" ,"idx" , &index_name_buf);
builtin/ls-files.c +1 -1
@@ -767,7 +767,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)* would not make any sense with this option. */ if (show_stage || show_unmerged) -die ("ls-files --with-tree is incompatible with -s or -u" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"ls-files --with-tree" ,"-s/-u" );overlay_tree_on_index (the_repository->index, with_tree, max_prefix); }
builtin/merge.c +2 -2
@@ -1396,9 +1396,9 @@ int cmd_merge(int argc, const char **argv, const char *prefix)if (squash) {if (fast_forward ==FF_NO ) -die (_ ("You cannot combine --squash with --no-ff." )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--squash" ,"--no-ff." );if (option_commit >0 ) -die (_ ("You cannot combine --squash with --commit." )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--squash" ,"--commit." );/* * squash can now silently disable option_commit - this is not * a problem as it is only overriding the default, not a user
builtin/pack-objects.c +1 -1
@@ -4070,7 +4070,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)die (_ ("--thin cannot be used to build an indexable pack" ));if (keep_unreachable && unpack_unreachable) -die (_ ("--keep-unreachable and --unpack-unreachable are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--keep-unreachable" ,"--unpack-unreachable" );if (!rev_list_all || !rev_list_reflog || !rev_list_index) unpack_unreachable_expiration =0 ;
builtin/push.c +4 -4
@@ -589,7 +589,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)set_push_cert_flags (&flags, push_cert);if (deleterefs && (tags || (flags & (TRANSPORT_PUSH_ALL |TRANSPORT_PUSH_MIRROR )))) -die (_ ("--delete is incompatible with --all, --mirror and --tags" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--delete" ,"--all/--mirror/--tags" );if (deleterefs && argc <2 )die (_ ("--delete doesn't make sense without any refs" ));
@@ -627,18 +627,18 @@ int cmd_push(int argc, const char **argv, const char *prefix)if (flags &TRANSPORT_PUSH_ALL ) {if (tags) -die (_ ("--all and --tags are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--all" ,"--tags" );if (argc >=2 )die (_ ("--all can't be combined with refspecs" )); }if (flags &TRANSPORT_PUSH_MIRROR ) {if (tags) -die (_ ("--mirror and --tags are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--mirror" ,"--tags" );if (argc >=2 )die (_ ("--mirror can't be combined with refspecs" )); }if ((flags &TRANSPORT_PUSH_ALL ) && (flags &TRANSPORT_PUSH_MIRROR )) -die (_ ("--all and --mirror are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--all" ,"--mirror" );if (!is_empty_cas (&cas) && (flags &TRANSPORT_PUSH_FORCE_IF_INCLUDES )) cas.use_force_if_includes =1 ;
builtin/rebase.c +3 -3
@@ -1190,13 +1190,13 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)if (keep_base) {if (options.onto_name) -die (_ ("cannot combine '--keep-base' with '--onto'" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--keep-base" ,"--onto" );if (options.root) -die (_ ("cannot combine '--keep-base' with '--root'" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--keep-base" ,"--root" ); }if (options.root && options.fork_point >0 ) -die (_ ("cannot combine '--root' with '--fork-point'" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--root" ,"--fork-point" );if (action !=ACTION_NONE && !in_progress)die (_ ("No rebase in progress?" ));
builtin/repack.c +2 -2
@@ -681,7 +681,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)if (keep_unreachable && (unpack_unreachable || (pack_everything &LOOSEN_UNREACHABLE ))) -die (_ ("--keep-unreachable and -A are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--keep-unreachable" ,"-A" );if (write_bitmaps <0 ) { if (!write_midx &&
@@ -712,7 +712,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)if (geometric_factor) {if (pack_everything) -die (_ ("--geometric is incompatible with -A, -a" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--geometric" ,"-A/-a" );init_pack_geometry (&geometry);split_pack_geometry (geometry, geometric_factor); }
builtin/reset.c +2 -2
@@ -423,7 +423,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)if (pathspec_from_file) {if (patch_mode) -die (_ ("--pathspec-from-file is incompatible with --patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--patch" );if (pathspec.nr)die (_ ("--pathspec-from-file is incompatible with pathspec arguments" ));
@@ -459,7 +459,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)if (patch_mode) {if (reset_type !=NONE ) -die (_ ("--patch is incompatible with --{hard,mixed,soft}" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--patch" ,"--{hard,mixed,soft}" );trace2_cmd_mode ("patch-interactive" );return run_add_interactive (rev,"--patch=reset" , &pathspec); }
builtin/rev-list.c +1 -1
@@ -538,7 +538,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)const char *arg = argv[i];if (skip_prefix (arg,"--missing=" , &arg)) {if (revs.exclude_promisor_objects) -die (_ ("cannot combine --exclude-promisor-objects and --missing" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--exclude-promisor-objects" ,"--missing" );if (parse_missing_action_value (arg))break ; }
builtin/show-branch.c +2 -2
@@ -707,8 +707,8 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)* * Also --all and --remotes do not make sense either. */ -die (_ ("--reflog is incompatible with --all, --remotes, " -"--independent or --merge-base" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--reflog" , +"--all/--remotes/--independent/--merge-base" ); }/* If nothing is specified, show all branches by default */
builtin/stash.c +2 -2
@@ -1700,10 +1700,10 @@ static int push_stash(int argc, const char **argv, const char *prefix,if (pathspec_from_file) {if (patch_mode) -die (_ ("--pathspec-from-file is incompatible with --patch" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--patch" );if (only_staged) -die (_ ("--pathspec-from-file is incompatible with --staged" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--staged" );if (ps.nr)die (_ ("--pathspec-from-file is incompatible with pathspec arguments" ));
builtin/tag.c +2 -2
@@ -522,7 +522,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)finalize_colopts (&colopts,-1 );if (cmdmode =='l' && filter.lines !=-1 ) {if (explicitly_enable_column (colopts)) -die (_ ("--column and -n are incompatible" )); +die (_ ("options '%s' and '%s' cannot be used together" ),"--column" ,"-n" ); colopts =0 ; } sorting =ref_sorting_options (&sorting_options);
@@ -564,7 +564,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)if (msg.given || msgfile) {if (msg.given && msgfile) -die (_ ("only one -F or -m option is allowed." )); +die (_ ("options '%s' and '%s' cannot be used together" ),"-F" ,"-m" );if (msg.given)strbuf_addbuf (&buf, &(msg.buf));else {
revision.c +10 -10
@@ -2300,11 +2300,11 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs->left_only =1 ; }else if (!strcmp (arg,"--right-only" )) {if (revs->left_only) -die ("--right-only is incompatible with --left-only" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--right-only" ,"--left-only" ); revs->right_only =1 ; }else if (!strcmp (arg,"--cherry" )) {if (revs->left_only) -die ("--cherry is incompatible with --left-only" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--cherry" ,"--left-only" ); revs->cherry_mark =1 ; revs->right_only =1 ; revs->max_parents =1 ;
@@ -2313,12 +2313,12 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs->count =1 ; }else if (!strcmp (arg,"--cherry-mark" )) {if (revs->cherry_pick) -die ("--cherry-mark is incompatible with --cherry-pick" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--cherry-mark" ,"--cherry-pick" ); revs->cherry_mark =1 ; revs->limited =1 ;/* needs limit_list() */ }else if (!strcmp (arg,"--cherry-pick" )) {if (revs->cherry_mark) -die ("--cherry-pick is incompatible with --cherry-mark" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--cherry-pick" ,"--cherry-mark" ); revs->cherry_pick =1 ; revs->limited =1 ; }else if (!strcmp (arg,"--objects" )) {
@@ -2524,7 +2524,7 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **argreturn opts; }if (revs->graph && revs->track_linear) -die ("--show-linear-break and --graph are incompatible" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--show-linear-break" ,"--graph" );return 1 ; }
@@ -2867,22 +2867,22 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct scompile_grep_patterns (&revs->grep_filter);if (revs->reverse && revs->reflog_info) -die ("cannot combine --reverse with --walk-reflogs" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--reverse" ,"--walk-reflogs" );if (revs->reflog_info && revs->limited)die ("cannot combine --walk-reflogs with history-limiting options" );if (revs->rewrite_parents && revs->children.name) -die ("cannot combine --parents and --children" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--parents" ,"--children" );/* * Limitations on the graph functionality */ if (revs->reverse && revs->graph) -die ("cannot combine --reverse with --graph" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--reverse" ,"--graph" );if (revs->reflog_info && revs->graph) -die ("cannot combine --walk-reflogs with --graph" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--walk-reflogs" ,"--graph" );if (revs->no_walk && revs->graph) -die ("cannot combine --no-walk with --graph" ); +die (_ ("options '%s' and '%s' cannot be used together" ),"--no-walk" ,"--graph" );if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)die ("cannot use --grep-reflog without --walk-reflogs" );
t/t2026-checkout-pathspec-file.sh +2 -2
@@ -149,10 +149,10 @@ test_expect_success 'error conditions' ' echo fileA.t >list && test_must_fail git checkout --pathspec-from-file=list --detach 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --detach" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--detach. cannot be used together" err && test_must_fail git checkout --pathspec-from-file=list --patch 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git checkout --pathspec-from-file=list -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
t/t2072-restore-pathspec-file.sh +1 -1
@@ -152,7 +152,7 @@ test_expect_success 'error conditions' ' >empty_list && test_must_fail git restore --pathspec-from-file=list --patch --source=HEAD^1 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git restore --pathspec-from-file=list --source=HEAD^1 -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
t/t3431-rebase-fork-point.sh +1 -1
@@ -83,7 +83,7 @@ test_expect_success 'git rebase --fork-point with ambigous refname' ' test_expect_success '--fork-point and --root both given' ' test_must_fail git rebase --fork-point --root 2>err && - test_i18ngrep "cannot combine" err + test_i18ngrep "cannot be used together" err ' test_expect_success 'rebase.forkPoint set to false' '
t/t3704-add-pathspec-file.sh +3 -3
@@ -138,13 +138,13 @@ test_expect_success 'error conditions' ' >empty_list && test_must_fail git add --pathspec-from-file=list --interactive 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --interactive/--patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err && test_must_fail git add --pathspec-from-file=list --patch 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --interactive/--patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err && test_must_fail git add --pathspec-from-file=list --edit 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --edit" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--edit. cannot be used together" err && test_must_fail git add --pathspec-from-file=list -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
t/t3909-stash-pathspec-file.sh +1 -1
@@ -88,7 +88,7 @@ test_expect_success 'error conditions' ' echo fileA.t >list && test_must_fail git stash push --pathspec-from-file=list --patch 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git stash push --pathspec-from-file=list -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
t/t5606-clone-options.sh +1 -1
@@ -54,7 +54,7 @@ test_expect_success 'disallows --bare with --separate-git-dir' ' test_must_fail git clone --bare --separate-git-dir dot-git-destiation parent clone-bare-sgd 2>err && test_debug "cat err" && - test_i18ngrep -e "--bare and --separate-git-dir are incompatible" err + test_i18ngrep -e "options .--bare. and .--separate-git-dir. cannot be used together" err '
t/t7107-reset-pathspec-file.sh +1 -1
@@ -160,7 +160,7 @@ test_expect_success 'error conditions' ' git rm fileA.t && test_must_fail git reset --pathspec-from-file=list --patch 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git reset --pathspec-from-file=list -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
t/t7526-commit-pathspec-file.sh +3 -3
@@ -141,13 +141,13 @@ test_expect_success 'error conditions' ' >empty_list && test_must_fail git commit --pathspec-from-file=list --interactive -m "Commit" 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --interactive/--patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err && test_must_fail git commit --pathspec-from-file=list --patch -m "Commit" 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with --interactive/--patch" err && + test_i18ngrep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err && test_must_fail git commit --pathspec-from-file=list --all -m "Commit" 2>err && - test_i18ngrep -e "--pathspec-from-file with -a does not make sense" err && + test_i18ngrep -e "options .--pathspec-from-file. and .-a. cannot be used together" err && test_must_fail git commit --pathspec-from-file=list -m "Commit" -- fileA.t 2>err && test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
Signature · 1 line
gitgitgadget
PATCH v5 4/11 i18n: standardize "cannot open" and "cannot read"
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- archive.c | 4 ++-- builtin/fetch.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
archive.c +2 -2
@@ -185,7 +185,7 @@ static int write_archive_entry(const struct object_id *oid, const char *base, buffer =object_file_to_archive (args, path.buf, oid, mode, &type, &size);if (!buffer) -return error (_ ("cannot read %s" ),oid_to_hex (oid)); +return error (_ ("cannot read '%s'" ),oid_to_hex (oid)); err =write_entry (args, oid, path.buf, path.len, mode, buffer, size);free (buffer);return err;
@@ -338,7 +338,7 @@ int write_archive_entries(struct archiver_args *args,strbuf_reset (&content);if (strbuf_read_file (&content, path, info->stat.st_size) <0 ) - err =error_errno (_ ("could not read '%s'" ), path); + err =error_errno (_ ("cannot read '%s'" ), path);else err = write_entry(args, &fake_oid, path_in_archive.buf, path_in_archive.len,
builtin/fetch.c +2 -2
@@ -996,7 +996,7 @@ static int open_fetch_head(struct fetch_head *fetch_head)if (write_fetch_head) { fetch_head->fp =fopen (filename,"a" );if (!fetch_head->fp) -return error_errno (_ ("cannot open %s" ), filename); +return error_errno (_ ("cannot open '%s'" ), filename);strbuf_init (&fetch_head->buf,0 ); }else { fetch_head->fp =NULL ;
@@ -1408,7 +1408,7 @@ static int truncate_fetch_head(void)FILE *fp =fopen_for_writing (filename);if (!fp) -return error_errno (_ ("cannot open %s" ), filename); +return error_errno (_ ("cannot open '%s'" ), filename);fclose (fp);return 0 ; }
Signature · 1 line
gitgitgadget
PATCH v5 5/11 i18n: tag.c factorize i18n strings
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- builtin/tag.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)
builtin/tag.c +14 -9
@@ -483,6 +483,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix) OPT_END() };int ret =0 ; +const char *only_in_list =NULL ;setup_ref_filter_porcelain_msg ();
@@ -542,15 +543,19 @@ int cmd_tag(int argc, const char **argv, const char *prefix) goto cleanup; }if (filter.lines !=-1 ) -die (_ ("-n option is only allowed in list mode" )); -if (filter.with_commit) -die (_ ("--contains option is only allowed in list mode" )); -if (filter.no_commit) -die (_ ("--no-contains option is only allowed in list mode" )); -if (filter.points_at.nr) -die (_ ("--points-at option is only allowed in list mode" )); -if (filter.reachable_from || filter.unreachable_from) -die (_ ("--merged and --no-merged options are only allowed in list mode" )); + only_in_list ="-n" ; +else if (filter.with_commit) + only_in_list ="--contains" ; +else if (filter.no_commit) + only_in_list ="--no-contains" ; +else if (filter.points_at.nr) + only_in_list ="--points-at" ; +else if (filter.reachable_from) + only_in_list ="--merged" ; +else if (filter.unreachable_from) + only_in_list ="--no-merged" ; +if (only_in_list) +die (_ ("the '%s' option is only allowed in list mode" ), only_in_list);if (cmdmode =='d' ) { ret =delete_tags (argv); goto cleanup;
Signature · 1 line
gitgitgadget
PATCH v5 6/11 i18n: factorize "--foo requires --bar" and the like
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
They are all replaced by "the option '%s' requires '%s'", which is a new string but replaces 17 previous unique strings.
--- archive.c | 2 +- builtin/add.c | 4 ++-- builtin/checkout.c | 2 +- builtin/commit.c | 2 +- builtin/fast-export.c | 2 +- builtin/index-pack.c | 2 +- builtin/log.c | 2 +- builtin/reset.c | 4 ++-- builtin/rm.c | 2 +- builtin/stash.c | 2 +- builtin/worktree.c | 2 +- fetch-pack.c | 2 +- http-fetch.c | 4 ++-- revision.c | 2 +- t/t2026-checkout-pathspec-file.sh | 2 +- t/t2072-restore-pathspec-file.sh | 2 +- t/t3601-rm-pathspec-file.sh | 2 +- t/t3704-add-pathspec-file.sh | 2 +- t/t3909-stash-pathspec-file.sh | 2 +- t/t7107-reset-pathspec-file.sh | 2 +- t/t7526-commit-pathspec-file.sh | 2 +- 21 files changed, 24 insertions(+), 24 deletions(-)
archive.c +1 -1
@@ -577,7 +577,7 @@ static int parse_archive_args(int argc, const char **argv,if (remote)die (_ ("Unexpected option --remote" ));if (exec) -die (_ ("Option --exec can only be used together with --remote" )); +die (_ ("the option '%s' requires '%s'" ),"--exec" ,"--remote" );if (output)die (_ ("Unexpected option --output" ));if (is_remote && args->extra_files.nr)
builtin/add.c +2 -2
@@ -541,7 +541,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)die (_ ("options '%s' and '%s' cannot be used together" ),"-A" ,"-u" );if (!show_only && ignore_missing) -die (_ ("Option --ignore-missing can only be used together with --dry-run" )); +die (_ ("the option '%s' requires '%s'" ),"--ignore-missing" ,"--dry-run" );if (chmod_arg && ((chmod_arg[0 ] !='-' && chmod_arg[0 ] !='+' ) || chmod_arg[1 ] !='x' || chmod_arg[2 ]))
@@ -573,7 +573,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)PATHSPEC_SYMLINK_LEADING_PATH , prefix, pathspec_from_file, pathspec_file_nul); }else if (pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); }if (require_pathspec && pathspec.nr ==0 ) {
builtin/checkout.c +1 -1
@@ -1758,7 +1758,7 @@ static int checkout_main(int argc, const char **argv, const char *prefix,0 , prefix, opts->pathspec_from_file, opts->pathspec_file_nul); }else if (opts->pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); } opts->pathspec.recursive =1 ;
builtin/commit.c +1 -1
@@ -367,7 +367,7 @@ static const char *prepare_index(const char **argv, const char *prefix,PATHSPEC_PREFER_FULL , prefix, pathspec_from_file, pathspec_file_nul); }else if (pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); } if (!pathspec.nr && (also || (only && !allow_empty &&
builtin/fast-export.c +1 -1
@@ -1254,7 +1254,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)usage_with_options (fast_export_usage, options);if (anonymized_seeds.cmpfn && !anonymize) -die (_ ("--anonymize-map without --anonymize does not make sense" )); +die (_ ("the option '%s' requires '%s'" ),"--anonymize-map" ,"--anonymize" );if (refspecs_list.nr) {int i;
builtin/index-pack.c +1 -1
@@ -1845,7 +1845,7 @@ int cmd_index_pack(int argc, const char **argv, const char *prefix)if (!pack_name && !from_stdin)usage (index_pack_usage);if (fix_thin_pack && !from_stdin) -die (_ ("--fix-thin cannot be used without --stdin" )); +die (_ ("the option '%s' requires '%s'" ),"--fix-thin" ,"--stdin" );if (from_stdin && !startup_info->have_repository)die (_ ("--stdin requires a git repository" ));if (from_stdin && hash_algo)
builtin/log.c +1 -1
@@ -2112,7 +2112,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)if (creation_factor <0 ) creation_factor =RANGE_DIFF_CREATION_FACTOR_DEFAULT ;else if (!rdiff_prev) -die (_ ("--creation-factor requires --range-diff" )); +die (_ ("the option '%s' requires '%s'" ),"--creation-factor" ,"--range-diff" );if (rdiff_prev) {if (!cover_letter && total !=1 )
builtin/reset.c +2 -2
@@ -432,7 +432,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)PATHSPEC_PREFER_FULL , prefix, pathspec_from_file, pathspec_file_nul); }else if (pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); } unborn = !strcmp (rev,"HEAD" ) &&get_oid ("HEAD" , &oid);
@@ -490,7 +490,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix) _(reset_type_names[reset_type]));if (intent_to_add && reset_type !=MIXED ) -die (_ ("-N can only be used with --mixed" )); +die (_ ("the option '%s' requires '%s'" ),"-N" ,"--mixed" );prepare_repo_settings (the_repository); the_repository->settings.command_requires_full_index =0 ;
builtin/rm.c +1 -1
@@ -278,7 +278,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)PATHSPEC_PREFER_CWD , prefix, pathspec_from_file, pathspec_file_nul); }else if (pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); }if (!pathspec.nr)
builtin/stash.c +1 -1
@@ -1712,7 +1712,7 @@ static int push_stash(int argc, const char **argv, const char *prefix,PATHSPEC_PREFER_FULL |PATHSPEC_PREFIX_ORIGIN , prefix, pathspec_from_file, pathspec_file_nul); }else if (pathspec_file_nul) { -die (_ ("--pathspec-file-nul requires --pathspec-from-file" )); +die (_ ("the option '%s' requires '%s'" ),"--pathspec-file-nul" ,"--pathspec-from-file" ); } return do_push_stash(&ps, stash_msg, quiet, keep_index, patch_mode,
builtin/worktree.c +1 -1
@@ -505,7 +505,7 @@ static int add(int ac, const char **av, const char *prefix)if (!!opts.detach + !!new_branch + !!new_branch_force >1 )die (_ ("options '%s', '%s', and '%s' cannot be used together" ),"-b" ,"-B" ,"--detach" );if (lock_reason && !keep_locked) -die (_ ("--reason requires --lock" )); +die (_ ("the option '%s' requires '%s'" ),"--reason" ,"--lock" );if (lock_reason) opts.keep_locked = lock_reason;else if (keep_locked)
fetch-pack.c +1 -1
@@ -297,7 +297,7 @@ static int find_common(struct fetch_negotiator *negotiator,struct packet_reader reader;if (args->stateless_rpc && multi_ack ==1 ) -die (_ ("--stateless-rpc requires multi_ack_detailed" )); +die (_ ("the option '%s' requires '%s'" ),"--stateless-rpc" ,"multi_ack_detailed" ); packet_reader_init(&reader, fd[0], NULL, 0, PACKET_READ_CHOMP_NEWLINE |
http-fetch.c +2 -2
@@ -141,7 +141,7 @@ int cmd_main(int argc, const char **argv)if (packfile) {if (!index_pack_args.nr) -die (_ ("--packfile requires --index-pack-args" )); +die (_ ("the option '%s' requires '%s'" ),"--packfile" ,"--index-pack-args" );fetch_single_packfile (&packfile_hash, argv[arg], index_pack_args.v);
@@ -150,7 +150,7 @@ int cmd_main(int argc, const char **argv) }if (index_pack_args.nr) -die (_ ("--index-pack-args can only be used with --packfile" )); +die (_ ("the option '%s' requires '%s'" ),"--index-pack-args" ,"--packfile" );if (commits_on_stdin) { commits =walker_targets_stdin (&commit_id, &write_ref);
revision.c +1 -1
@@ -2884,7 +2884,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct sif (revs->no_walk && revs->graph)die (_ ("options '%s' and '%s' cannot be used together" ),"--no-walk" ,"--graph" );if (!revs->reflog_info && revs->grep_filter.use_reflog_filter) -die ("cannot use --grep-reflog without --walk-reflogs" ); +die (_ ("the option '%s' requires '%s'" ),"--grep-reflog" ,"--walk-reflogs" );if (revs->line_level_traverse && (revs->diffopt.output_format & ~(DIFF_FORMAT_PATCH |DIFF_FORMAT_NO_OUTPUT )))
t/t2026-checkout-pathspec-file.sh +1 -1
@@ -158,7 +158,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git checkout --pathspec-file-nul 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err ' test_done
t/t2072-restore-pathspec-file.sh +1 -1
@@ -158,7 +158,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git restore --pathspec-file-nul --source=HEAD^1 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err && + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err && test_must_fail git restore --pathspec-from-file=empty_list --source=HEAD^1 2>err && test_i18ngrep -e "you must specify path(s) to restore" err
t/t3601-rm-pathspec-file.sh +1 -1
@@ -70,7 +70,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git rm --pathspec-file-nul 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err && + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err && >empty_list && test_must_fail git rm --pathspec-from-file=empty_list 2>err &&
t/t3704-add-pathspec-file.sh +1 -1
@@ -150,7 +150,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git add --pathspec-file-nul 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err && + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err && # This case succeeds, but still prints to stderr git add --pathspec-from-file=empty_list 2>err &&
t/t3909-stash-pathspec-file.sh +1 -1
@@ -94,7 +94,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git stash push --pathspec-file-nul 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err ' test_done
t/t7107-reset-pathspec-file.sh +1 -1
@@ -166,7 +166,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git reset --pathspec-file-nul 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err && + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err && test_must_fail git reset --soft --pathspec-from-file=list 2>err && test_i18ngrep -e "fatal: Cannot do soft reset with paths" err &&
t/t7526-commit-pathspec-file.sh +1 -1
@@ -153,7 +153,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && test_must_fail git commit --pathspec-file-nul -m "Commit" 2>err && - test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err && + test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err && test_must_fail git commit --pathspec-from-file=empty_list --include -m "Commit" 2>err && test_i18ngrep -e "No paths with --include/--only does not make sense." err &&
Signature · 1 line
gitgitgadget
PATCH v5 7/11 i18n: factorize "no directory given for --foo"
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- git.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
git.c +3 -3
@@ -185,7 +185,7 @@ static int handle_options(const char ***argv, int *argc, int *envchanged) *envchanged =1 ; }else if (!strcmp (cmd,"--git-dir" )) {if (*argc <2 ) { -fprintf (stderr,_ ("no directory given for --git-dir\n" )); +fprintf (stderr,_ ("no directory given for '%s' option\n" ),"--git-dir" );usage (git_usage_string); }setenv (GIT_DIR_ENVIRONMENT , (*argv)[1 ],1 );
@@ -213,7 +213,7 @@ static int handle_options(const char ***argv, int *argc, int *envchanged) *envchanged =1 ; }else if (!strcmp (cmd,"--work-tree" )) {if (*argc <2 ) { -fprintf (stderr,_ ("no directory given for --work-tree\n" )); +fprintf (stderr,_ ("no directory given for '%s' option\n" ),"--work-tree" );usage (git_usage_string); }setenv (GIT_WORK_TREE_ENVIRONMENT , (*argv)[1 ],1 );
@@ -297,7 +297,7 @@ static int handle_options(const char ***argv, int *argc, int *envchanged) *envchanged =1 ; }else if (!strcmp (cmd,"-C" )) {if (*argc <2 ) { -fprintf (stderr,_ ("no directory given for -C\n" )); +fprintf (stderr,_ ("no directory given for '%s' option\n" ),"-C" );usage (git_usage_string); }if ((*argv)[1 ][0 ]) {
Signature · 1 line
gitgitgadget
PATCH v5 8/11 i18n: refactor "unrecognized %(foo) argument" strings
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- ref-filter.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
ref-filter.c +7 -7
@@ -341,7 +341,7 @@ static int objectsize_atom_parser(struct ref_format *format, struct used_atom *aelse oi.info.disk_sizep = &oi.disk_size; }else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(objectsize) argument: %s" ), arg); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ),"objectsize" , arg);return 0 ; }
@@ -374,7 +374,7 @@ static int subject_atom_parser(struct ref_format *format, struct used_atom *atomelse if (!strcmp (arg,"sanitize" )) atom->u.contents.option =C_SUB_SANITIZE ;else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(subject) argument: %s" ), arg); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ),"subject" , arg);return 0 ; }
@@ -428,7 +428,7 @@ static int contents_atom_parser(struct ref_format *format, struct used_atom *atoif (strtoul_ui (arg,10 , &atom->u.contents.nlines))return strbuf_addf_ret (err,-1 ,_ ("positive value expected contents:lines=%s" ), arg); }else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(contents) argument: %s" ), arg); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ),"contents" , arg);return 0 ; }
@@ -440,7 +440,7 @@ static int raw_atom_parser(struct ref_format *format, struct used_atom *atom,else if (!strcmp (arg,"size" )) atom->u.raw_data.option =RAW_LENGTH ;else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(raw) argument: %s" ), arg); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ),"raw" , arg);return 0 ; }
@@ -459,7 +459,7 @@ static int oid_atom_parser(struct ref_format *format, struct used_atom *atom,if (atom->u.oid.length <MINIMUM_ABBREV ) atom->u.oid.length =MINIMUM_ABBREV ; }else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized argument '%s' in %%(%s)" ), arg, atom->name); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ), atom->name, arg);return 0 ; }
@@ -531,7 +531,7 @@ static int align_atom_parser(struct ref_format *format, struct used_atom *atom,else if ((position =parse_align_position (s)) >=0 ) align->position = position;else { -strbuf_addf (err,_ ("unrecognized %%(align) argument: %s" ), s); +strbuf_addf (err,_ ("unrecognized %%(%s) argument: %s" ),"align" , s);string_list_clear (¶ms,0 );return -1 ; }
@@ -557,7 +557,7 @@ static int if_atom_parser(struct ref_format *format, struct used_atom *atom, }else if (skip_prefix (arg,"notequals=" , &atom->u.if_then_else.str)) { atom->u.if_then_else.cmp_status =COMPARE_UNEQUAL ; }else -return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(if) argument: %s" ), arg); +return strbuf_addf_ret (err,-1 ,_ ("unrecognized %%(%s) argument: %s" ),"if" , arg);return 0 ; }
Signature · 1 line
gitgitgadget
PATCH v5 9/11 i18n: factorize "--foo outside a repository"
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- apply.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
apply.c +3 -3
@@ -136,7 +136,7 @@ int check_apply_state(struct apply_state *state, int force_apply)return error (_ ("options '%s' and '%s' cannot be used together" ),"--reject" ,"--3way" );if (state->threeway) {if (is_not_gitdir) -return error (_ ("--3way outside a repository" )); +return error (_ ("'%s' outside a repository" ),"--3way" ); state->check_index =1 ; }if (state->apply_with_reject) {
@@ -147,10 +147,10 @@ int check_apply_state(struct apply_state *state, int force_apply)if (!force_apply && (state->diffstat || state->numstat || state->summary || state->check || state->fake_ancestor)) state->apply =0 ;if (state->check_index && is_not_gitdir) -return error (_ ("--index outside a repository" )); +return error (_ ("'%s' outside a repository" ),"--index" );if (state->cached) {if (is_not_gitdir) -return error (_ ("--cached outside a repository" )); +return error (_ ("'%s' outside a repository" ),"--cached" ); state->check_index =1 ; }if (state->ita_only && (state->check_index || is_not_gitdir))
Signature · 1 line
gitgitgadget
PATCH v5 10/11 i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom"
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
--- ref-filter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
ref-filter.c +4 -4
@@ -841,7 +841,7 @@ static void if_then_else_handler(struct ref_formatting_stack **stack)struct if_then_else *if_then_else = (struct if_then_else *)cur->at_end_data;if (!if_then_else->then_atom_seen) -die (_ ("format: %%(if) atom used without a %%(then) atom" )); +die (_ ("format: %%(%s) atom used without a %%(%s) atom" ),"if" ,"then" );if (if_then_else->else_atom_seen) {/*
@@ -907,7 +907,7 @@ static int then_atom_handler(struct atom_value *atomv, struct ref_formatting_staif (cur->at_end == if_then_else_handler) if_then_else = (struct if_then_else *)cur->at_end_data;if (!if_then_else) -return strbuf_addf_ret (err,-1 ,_ ("format: %%(then) atom used without an %%(if) atom" )); +return strbuf_addf_ret (err,-1 ,_ ("format: %%(%s) atom used without a %%(%s) atom" ),"then" ,"if" );if (if_then_else->then_atom_seen)return strbuf_addf_ret (err,-1 ,_ ("format: %%(then) atom used more than once" ));if (if_then_else->else_atom_seen)
@@ -943,9 +943,9 @@ static int else_atom_handler(struct atom_value *atomv, struct ref_formatting_staif (prev->at_end == if_then_else_handler) if_then_else = (struct if_then_else *)prev->at_end_data;if (!if_then_else) -return strbuf_addf_ret (err,-1 ,_ ("format: %%(else) atom used without an %%(if) atom" )); +return strbuf_addf_ret (err,-1 ,_ ("format: %%(%s) atom used without a %%(%s) atom" ),"else" ,"if" );if (!if_then_else->then_atom_seen) -return strbuf_addf_ret (err,-1 ,_ ("format: %%(else) atom used without a %%(then) atom" )); +return strbuf_addf_ret (err,-1 ,_ ("format: %%(%s) atom used without a %%(%s) atom" ),"else" ,"then" );if (if_then_else->else_atom_seen)return strbuf_addf_ret (err,-1 ,_ ("format: %%(else) atom used more than once" )); if_then_else->else_atom_seen =1 ;
Signature · 1 line
gitgitgadget
PATCH v5 11/11 i18n: turn even more messages into "cannot be used together" ones
In reply to Jean-Noël Avila via GitGitGadgetFrom: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <[email protected]>
Even if some of these messages are not subject to gettext i18n, this helps bring a single style of message for a given error type.
--- builtin/add.c | 2 +- builtin/am.c | 6 +++--- builtin/cat-file.c | 2 +- builtin/checkout.c | 6 +++--- builtin/clone.c | 4 ++-- builtin/commit.c | 9 +++++---- builtin/describe.c | 4 ++-- builtin/rebase.c | 4 ++-- builtin/reset.c | 2 +- builtin/rev-list.c | 2 +- builtin/rm.c | 2 +- builtin/stash.c | 2 +- diff.c | 12 ++++++++---- t/t2026-checkout-pathspec-file.sh | 2 +- t/t2072-restore-pathspec-file.sh | 2 +- t/t3601-rm-pathspec-file.sh | 2 +- t/t3704-add-pathspec-file.sh | 2 +- t/t3909-stash-pathspec-file.sh | 2 +- t/t4209-log-pickaxe.sh | 4 ++-- t/t5606-clone-options.sh | 2 +- t/t7107-reset-pathspec-file.sh | 2 +- t/t7500-commit-template-squash-signoff.sh | 11 ++++++----- t/t7526-commit-pathspec-file.sh | 2 +- 23 files changed, 47 insertions(+), 41 deletions(-)
builtin/add.c +1 -1
@@ -566,7 +566,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)if (pathspec_from_file) {if (pathspec.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" ); parse_pathspec_file(&pathspec, PATHSPEC_ATTR, PATHSPEC_PREFER_FULL |
builtin/am.c +3 -3
@@ -2230,9 +2230,9 @@ static int parse_opt_show_current_patch(const struct option *opt, const char *ar }if (resume->mode ==RESUME_SHOW_PATCH && new_value != resume->sub_mode) -return error (_ ("--show-current-patch=%s is incompatible with " -"--show-current-patch=%s" ), - arg, valid_modes[resume->sub_mode]); +return error (_ ("options '%s=%s' and '%s=%s' " +"cannot be used together" ), +"--show-current-patch" ,"--show-current-patch" , arg, valid_modes[resume->sub_mode]); resume->mode =RESUME_SHOW_PATCH ; resume->sub_mode = new_value;
builtin/cat-file.c +1 -1
@@ -729,7 +729,7 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix) }if (force_path && batch.enabled) { -error ("--path=<path> incompatible with --batch" ); +error ("options '--path=<path>' and '--batch' cannot be used together" );usage_with_options (cat_file_usage, options); }
builtin/checkout.c +3 -3
@@ -1635,8 +1635,8 @@ static int checkout_main(int argc, const char **argv, const char *prefix, }if ((!!opts->new_branch + !!opts->new_branch_force + !!opts->new_orphan_branch) >1 ) -die (_ ("-%c, -%c and --orphan are mutually exclusive" ), - cb_option,toupper (cb_option)); +die (_ ("options '-%c', '-%c', and '%s' cannot be used together" ), + cb_option,toupper (cb_option),"--orphan" );if (opts->overlay_mode ==1 && opts->patch_mode)die (_ ("options '%s' and '%s' cannot be used together" ),"-p" ,"--overlay" );
@@ -1746,7 +1746,7 @@ static int checkout_main(int argc, const char **argv, const char *prefix,if (opts->pathspec_from_file) {if (opts->pathspec.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" );if (opts->force_detach)die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--detach" );
builtin/clone.c +2 -2
@@ -900,8 +900,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)if (option_bare) {if (option_origin) -die (_ ("--bare and --origin %s options are incompatible." ), - option_origin); +die (_ ("options '%s' and '%s %s' cannot be used together" ), +"--bare" ,"--origin" , option_origin);if (real_git_dir)die (_ ("options '%s' and '%s' cannot be used together" ),"--bare" ,"--separate-git-dir" ); option_no_checkout =1 ;
builtin/commit.c +5 -4
@@ -361,7 +361,7 @@ static const char *prepare_index(const char **argv, const char *prefix,die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"-a" );if (pathspec.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" ); parse_pathspec_file(&pathspec, 0, PATHSPEC_PREFER_FULL,
@@ -799,7 +799,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,if (!strcmp (fixup_prefix,"amend" )) {if (have_option_m) -die (_ ("cannot combine -m with --fixup:%s" ), fixup_message); +die (_ ("options '%s' and '%s:%s' cannot be used together" ),"-m" ,"--fixup" , fixup_message);prepare_amend_commit (commit, &sb, &ctx); } }else if (!stat (git_path_merge_msg (the_repository), &statbuf)) {
@@ -1229,9 +1229,10 @@ static void check_fixup_reword_options(int argc, const char *argv[]) {die (_ ("You are in the middle of a cherry-pick -- cannot reword." )); }if (argc) -die (_ ("cannot combine reword option of --fixup with path '%s'" ), *argv); +die (_ ("reword option of '%s' and path '%s' cannot be used together" ),"--fixup" , *argv);if (patch_interactive || interactive || all || also || only) -die (_ ("reword option of --fixup is mutually exclusive with --patch/--interactive/--all/--include/--only" )); +die (_ ("reword option of '%s' and '%s' cannot be used together" ), +"--fixup" ,"--patch/--interactive/--all/--include/--only" ); } static int parse_and_validate_options(int argc, const char *argv[],
builtin/describe.c +2 -2
@@ -670,9 +670,9 @@ int cmd_describe(int argc, const char **argv, const char *prefix) }describe ("HEAD" ,1 ); }else if (dirty) { -die (_ ("--dirty is incompatible with commit-ishes" )); +die (_ ("option '%s' and commit-ishes cannot be used together" ),"--dirty" ); }else if (broken) { -die (_ ("--broken is incompatible with commit-ishes" )); +die (_ ("option '%s' and commit-ishes cannot be used together" ),"--broken" ); }else {while (argc-- >0 )describe (*argv++, argc ==0 );
builtin/rebase.c +2 -2
@@ -1460,8 +1460,8 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)if (i >=0 ) {if (is_merge (&options)) -die (_ ("cannot combine apply options with " -"merge options" )); +die (_ ("apply options and merge options " +"cannot be used together" ));else options.type =REBASE_APPLY ; }
builtin/reset.c +1 -1
@@ -426,7 +426,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--patch" );if (pathspec.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" ); parse_pathspec_file(&pathspec, 0, PATHSPEC_PREFER_FULL,
builtin/rev-list.c +1 -1
@@ -676,7 +676,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)if (revs.count && (revs.tag_objects || revs.tree_objects || revs.blob_objects) && (revs.left_right || revs.cherry_mark)) -die (_ ("marked counting is incompatible with --objects" )); +die (_ ("marked counting and '%s' cannot be used together" ),"--objects" ); save_commit_buffer = (revs.verbose_header || revs.grep_filter.pattern_list ||
builtin/rm.c +1 -1
@@ -272,7 +272,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)if (pathspec_from_file) {if (pathspec.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" ); parse_pathspec_file(&pathspec, 0, PATHSPEC_PREFER_CWD,
builtin/stash.c +1 -1
@@ -1706,7 +1706,7 @@ static int push_stash(int argc, const char **argv, const char *prefix,die (_ ("options '%s' and '%s' cannot be used together" ),"--pathspec-from-file" ,"--staged" );if (ps.nr) -die (_ ("--pathspec-from-file is incompatible with pathspec arguments" )); +die (_ ("'%s' and pathspec arguments cannot be used together" ),"--pathspec-from-file" ); parse_pathspec_file(&ps, 0, PATHSPEC_PREFER_FULL | PATHSPEC_PREFIX_ORIGIN,
diff.c +8 -4
@@ -4639,16 +4639,20 @@ void diff_setup_done(struct diff_options *options) options->set_default (options);if (HAS_MULTI_BITS (options->output_format & check_mask)) -die (_ ("--name-only, --name-status, --check and -s are mutually exclusive" )); +die (_ ("options '%s', '%s', '%s', and '%s' cannot be used together" ), +"--name-only" ,"--name-status" ,"--check" ,"-s" );if (HAS_MULTI_BITS (options->pickaxe_opts &DIFF_PICKAXE_KINDS_MASK )) -die (_ ("options '%s', '%s', and '%s' cannot be used together" ),"-G" ,"-S" ,"--find-object" ); +die (_ ("options '%s', '%s', and '%s' cannot be used together" ), +"-G" ,"-S" ,"--find-object" );if (HAS_MULTI_BITS (options->pickaxe_opts &DIFF_PICKAXE_KINDS_G_REGEX_MASK )) -die (_ ("-G and --pickaxe-regex are mutually exclusive, use --pickaxe-regex with -S" )); +die (_ ("options '%s' and '%s' cannot be used together, use '%s' with '%s'" ), +"-G" ,"--pickaxe-regex" ,"--pickaxe-regex" ,"-S" );if (HAS_MULTI_BITS (options->pickaxe_opts &DIFF_PICKAXE_KINDS_ALL_OBJFIND_MASK )) -die (_ ("--pickaxe-all and --find-object are mutually exclusive, use --pickaxe-all with -G and -S" )); +die (_ ("options '%s' and '%s' cannot be used together, use '%s' with '%s' and '%s'" ), +"--pickaxe-all" ,"--find-object" ,"--pickaxe-all" ,"-G" ,"-S" );/* * Most of the time we can say "there are changes"
t/t2026-checkout-pathspec-file.sh +1 -1
@@ -155,7 +155,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git checkout --pathspec-from-file=list -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git checkout --pathspec-file-nul 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err
t/t2072-restore-pathspec-file.sh +1 -1
@@ -155,7 +155,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git restore --pathspec-from-file=list --source=HEAD^1 -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git restore --pathspec-file-nul --source=HEAD^1 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
t/t3601-rm-pathspec-file.sh +1 -1
@@ -67,7 +67,7 @@ test_expect_success 'error conditions' ' echo fileA.t >list && test_must_fail git rm --pathspec-from-file=list -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git rm --pathspec-file-nul 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
t/t3704-add-pathspec-file.sh +1 -1
@@ -147,7 +147,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .--edit. cannot be used together" err && test_must_fail git add --pathspec-from-file=list -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git add --pathspec-file-nul 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
t/t3909-stash-pathspec-file.sh +1 -1
@@ -91,7 +91,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git stash push --pathspec-from-file=list -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git stash push --pathspec-file-nul 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err
t/t4209-log-pickaxe.sh +2 -2
@@ -72,12 +72,12 @@ test_expect_success 'usage' ' grep "cannot be used together" err && test_expect_code 128 git log --pickaxe-all --find-object=HEAD 2>err && - grep "mutually exclusive" err + grep "cannot be used together" err ' test_expect_success 'usage: --pickaxe-regex' ' test_expect_code 128 git log -Gregex --pickaxe-regex 2>err && - grep "mutually exclusive" err + grep "cannot be used together" err ' test_expect_success 'usage: --no-pickaxe-regex' '
t/t5606-clone-options.sh +1 -1
@@ -46,7 +46,7 @@ test_expect_success 'disallows --bare with --origin' ' test_must_fail git clone -o foo --bare parent clone-bare-o 2>err && test_debug "cat err" && - test_i18ngrep -e "--bare and --origin foo options are incompatible" err + test_i18ngrep -e "options .--bare. and .--origin foo. cannot be used together" err '
t/t7107-reset-pathspec-file.sh +1 -1
@@ -163,7 +163,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err && test_must_fail git reset --pathspec-from-file=list -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git reset --pathspec-file-nul 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
t/t7500-commit-template-squash-signoff.sh +6 -5
@@ -359,14 +359,14 @@ test_expect_success '--fixup=reword: ignores staged changes' ' test_expect_success '--fixup=reword: error out with -m option' ' commit_for_rebase_autosquash_setup && - echo "fatal: cannot combine -m with --fixup:reword" >expect && + echo "fatal: options '\''-m'\'' and '\''--fixup:reword'\'' cannot be used together" >expect && test_must_fail git commit --fixup=reword:HEAD~ -m "reword commit message" 2>actual && test_cmp expect actual ' test_expect_success '--fixup=amend: error out with -m option' ' commit_for_rebase_autosquash_setup && - echo "fatal: cannot combine -m with --fixup:amend" >expect && + echo "fatal: options '\''-m'\'' and '\''--fixup:amend'\'' cannot be used together" >expect && test_must_fail git commit --fixup=amend:HEAD~ -m "amend commit message" 2>actual && test_cmp expect actual '
@@ -421,8 +421,9 @@ test_expect_success 'amend! commit allows empty commit msg body with --allow-emp test_fixup_reword_opt () { test_expect_success "--fixup=reword: incompatible with $1" " - echo 'fatal: reword option of --fixup is mutually exclusive with'\ - '--patch/--interactive/--all/--include/--only' >expect && + echo 'fatal: reword option of '\''--fixup'\'' and' \ + ''\''--patch/--interactive/--all/--include/--only'\' \ + 'cannot be used together' >expect && test_must_fail git commit --fixup=reword:HEAD~ $1 2>actual && test_cmp expect actual "
@@ -435,7 +436,7 @@ done test_expect_success '--fixup=reword: give error with pathsec' ' commit_for_rebase_autosquash_setup && - echo "fatal: cannot combine reword option of --fixup with path '\''foo'\''" >expect && + echo "fatal: reword option of '\''--fixup'\'' and path '\''foo'\'' cannot be used together" >expect && test_must_fail git commit --fixup=reword:HEAD~ -- foo 2>actual && test_cmp expect actual '
t/t7526-commit-pathspec-file.sh +1 -1
@@ -150,7 +150,7 @@ test_expect_success 'error conditions' ' test_i18ngrep -e "options .--pathspec-from-file. and .-a. cannot be used together" err && test_must_fail git commit --pathspec-from-file=list -m "Commit" -- fileA.t 2>err && - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err && + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err && test_must_fail git commit --pathspec-file-nul -m "Commit" 2>err && test_i18ngrep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
Signature · 1 line
gitgitgadget
Am 05.01.22 um 21:02 schrieb Jean-Noël Avila via GitGitGadget:
Quoted 23 lines
This series is a meager attempt at rationalizing a small fraction of the internationalized messages. Sorry in advance for the dull task of reviewing these insipide patches.
Doing so has some positive effects:
* non-translatable constant strings are kept out of the way for translators
* messages with identical meaning are built identically
* the total number of messages to translate is decreased.Changes since V1:
* took into account the comments, except for
ref-filter.cwhere the proposed refactoring is not obvious.
* added even more strings to the "cannot be used together" crowd.Changes since V2:
* fixed change of behaviour in
tag.c
* reverted sam changes as per Johannes Sixt commentsChanges since V3:
Quoted 7 lines
* apply Oxford comma where needed
* switch all options to " '%s' " style where i18n is applied.Changes since V4:
* Apply changes by René on
tag.c
* cosmetic changes
This round looks good to me, with one caveat: I am not a translator, nor do I use a translated version of Git. So, I haven't verified the claim that the number translatable strings was reduced greatly, nor whether there are any accidential duplicates due to typos. I infer the correctness only by looking at the changes.
There's one small nit visible in the range-diff; not worth a reroll IMHO:
Quoted 9 lines
5: a9d8a50d666 ! 5: ad58bc8d8a9 i18n: tag.c factorize i18n strings
@@ builtin/tag.c: int cmd_tag(int argc, const char **argv, const char *prefix)
- die(_("--no-contains option is only allowed in list mode"));
- if (filter.points_at.nr)
- die(_("--points-at option is only allowed in list mode"));
+- if (filter.reachable_from || filter.unreachable_from)
+- die(_("--merged and --no-merged options are only allowed in list mode"));
+ only_in_list = "-n";
+ else if (filter.with_commit)Quoted 8 lines
+ only_in_list = "--contains";
@@ builtin/tag.c: int cmd_tag(int argc, const char **argv, const char *prefix)
+ only_in_list = "--no-contains";
+ else if (filter.points_at.nr)
+ only_in_list = "--points-at";
++ else if (filter.reachable_from)
++ only_in_list = "--merged";
++ else if (filter.unreachable_from)An extra blank after the 'if'.
Quoted 9 lines
++ only_in_list = "--no-merged";
+ if (only_in_list)
+ die(_("the '%s' option is only allowed in list mode"), only_in_list);
- if (filter.reachable_from || filter.unreachable_from)
-- die(_("--merged and --no-merged options are only allowed in list mode"));
-+ die(_("'--merged' and '--no-merged' options are only allowed in list mode"));
if (cmdmode == 'd') {
ret = delete_tags(argv);
goto cleanup;-- Hannes
Quoted 8 lines · Johannes Sixt
Quoted 2 lines
* Apply changes by René on
tag.c
* cosmetic changesThis round looks good to me, with one caveat: I am not a translator, nor do I use a translated version of Git. So, I haven't verified the claim that the number translatable strings was reduced greatly, nor whether there are any accidential duplicates due to typos. I infer the correctness only by looking at the changes.
Thanks, both. Will queue with a touch-up for that doubled SP.