Skip to contentSkip to conversation

arm:arm64/hw_breakpoint.c: Remove unnecessary header

PATCH In review Maninder Singh 3 participants 3 messages Jun 11, 2015

Subsystems (3)
Arm (32-bit) arm64 Arm PMU profiling and debugging
lore
Share & tools
lore

Maninder Singh

author
#0 lore raw

PATCH v2 1/1 arm:arm64/hw_breakpoint.c: Remove unnecessary header

Header <asm/kdebug.h> is not needed in hw_breakpoint.c for arm as well as arm64.
Removing the same.

Signed-off-by Maninder Singh <[email protected]>
Reviewed-by Vaneet Narang <[email protected]>
---
 arch/arm/kernel/hw_breakpoint.c   |    1 -
 arch/arm64/kernel/hw_breakpoint.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/arch/arm/kernel/hw_breakpoint.c
index dc7d0a9..6284779 100644

arch/arm/kernel/hw_breakpoint.c +0 -1
@@ -35,7 +35,6 @@
 #include <asm/cputype.h>
 #include <asm/current.h>
 #include <asm/hw_breakpoint.h>
-#include <asm/kdebug.h>
 #include <asm/traps.h>
 
 /* Breakpoint currently in use for each BRP. */
(quoted diff) +0 -0

b/arch/arm64/kernel/hw_breakpoint.c
index e7d934d..7a1a5da 100644

arch/arm64/kernel/hw_breakpoint.c +0 -1
@@ -31,7 +31,6 @@
 #include <asm/current.h>
 #include <asm/debug-monitors.h>
 #include <asm/hw_breakpoint.h>
-#include <asm/kdebug.h>
 #include <asm/traps.h>
 #include <asm/cputype.h>
 #include <asm/system_misc.h>
Signature · 1 line
1.7.1
#1 lore raw
Quoted 10 lines · Maninder Singh

Header <asm/kdebug.h> is not needed in hw_breakpoint.c for arm as well as arm64.
Removing the same.

Signed-off-by Maninder Singh <[email protected]>
Reviewed-by Vaneet Narang <[email protected]>
---
 arch/arm/kernel/hw_breakpoint.c   |    1 -
 arch/arm64/kernel/hw_breakpoint.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Sorry for the bother, but can you send this as two separate patches please? They'll need to go via two different trees to get into mainline.

Will

maintainer
#2 lore raw
Quoted 12 lines · Will Deacon
Quoted 10 lines · Maninder Singh

Header <asm/kdebug.h> is not needed in hw_breakpoint.c for arm as well as arm64.
Removing the same.

Signed-off-by Maninder Singh <[email protected]>
Reviewed-by Vaneet Narang <[email protected]>
---
 arch/arm/kernel/hw_breakpoint.c   |    1 -
 arch/arm64/kernel/hw_breakpoint.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
Quoted 2 lines

Sorry for the bother, but can you send this as two separate patches please? They'll need to go via two different trees to get into mainline.

Or just send it to kernel-janitors at vger.kernel.org.

Signature · 1 line
Catalin