Skip to contentSkip to conversation

connman: add iptables to RDEPENDS

PATCH In review Jonathan Liu 2 participants 6 messages May 13, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 connman: add iptables to RDEPENDS

The connmand daemon requires libxtables.so from iptables to start up.

---
 meta/recipes-connectivity/connman/connman.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-connectivity/connman/connman.inc +2 -1
index afc361c..44d9d6e 100644
@@ -15,7 +15,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
 
 DEPENDS  = "dbus glib-2.0 ppp iptables gnutls"
 
-INC_PR = "r20"
+INC_PR = "r21"
 
 EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
@@ -99,6 +99,7 @@ RPROVIDES_${PN} = "\
 
 RDEPENDS_${PN} = "\
 	dbus \
+	iptables \
 	${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
 	${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
 	${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
Signature · 1 line
1.8.2.3
#1 lore raw
Quoted 1 line · Jonathan Liu

The connmand daemon requires libxtables.so from iptables to start up.

And the automatic dependencies-from-linkage code seems to be working just fine:

$ dpkg -I connman_1.13-r20.0.2_core2.ipk
...
 Depends: iptables (>= 1.4.17), dbus-1, ofono, libdbus-1-3 (>= 1.6.8),
bluez4, libgnutls26 (>= 2.12.21), libc6 (>= 2.17), libglib-2.0-0 (>=
2.36.0), shadow, base-passwd, wpa-supplicant

So the question is can you verify that this dependency isn't happening for you, and how do we fix *that* problem.

Ross

#2 lore raw

I did a git pull which updated connman to 1.13 and rebuilt image from scratch clearing all temp files and work. The iptables dependency was missing when I checked with opkg-cl on the target.

Regards,
Jonathan

Quoted 15 lines · Ross
Quoted 1 line · Jonathan Liu

The connmand daemon requires libxtables.so from iptables to start up.

And the automatic dependencies-from-linkage code seems to be working just fine:

$ dpkg -I connman_1.13-r20.0.2_core2.ipk
...
Depends: iptables (>= 1.4.17), dbus-1, ofono, libdbus-1-3 (>= 1.6.8),
bluez4, libgnutls26 (>= 2.12.21), libc6 (>= 2.17), libglib-2.0-0 (>=
2.36.0), shadow, base-passwd, wpa-supplicant

So the question is can you verify that this dependency isn't happening for you, and how do we fix *that* problem.

Ross

#3 lore raw
Quoted 3 lines · Jonathan Liu

I did a git pull which updated connman to 1.13 and rebuilt image from scratch clearing all temp files and work. The iptables dependency was missing when I checked with opkg-cl on the target.

I really can't replicate this - my connman packages just built with latest git have a versioned iptables dependency from the link. Check your do_package logs, you should find lines like this:

DEBUG: connman: Dependency libxtables.so.9 requires package iptables

Ross

#4 lore raw
Quoted 11 lines · Ross
Quoted 3 lines · Jonathan Liu

I did a git pull which updated connman to 1.13 and rebuilt image from scratch clearing all temp files and work. The iptables dependency was missing when I checked with opkg-cl on the target.

I really can't replicate this - my connman packages just built with latest git have a versioned iptables dependency from the link. Check your do_package logs, you should find lines like this:

DEBUG: connman: Dependency libxtables.so.9 requires package iptables

Ross

The connmand daemon was complaining about libxtables.so.9 missing, but it's libxtables.so.10 now. Maybe I just had to force a more complete rebuild.

Regards,
Jonathan

#5 lore raw
Quoted 3 lines · Jonathan Liu

The connmand daemon was complaining about libxtables.so.9 missing, but it's libxtables.so.10 now.
Maybe I just had to force a more complete rebuild.

iptables upgrading should have caused connman to rebuild against the new iptables and pick up the new dependency, so it's possible that your machine is pending a connman upgrade if you've been using a feed to upgrade. If it's a fresh image, then something went rather wrong.

Ross