Skip to contentSkip to conversation

backlight: ktd2801: fix unmet dependency on GPIOLIB

PATCH Applied Julian Braha 5 participants 5 messages Jul 19 – Aug 12

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backlight: ktd2801: fix unmet dependency on GPIOLIB

LEDS_EXPRESSWIRE depends on GPIOLIB, so its selector, BACKLIGHT_KTD2801 also needs to ensure GPIOLIB is enabled. Otherwise:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=n]
Selected by [y]:
- BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.

Fixes d95963e309bc ("backlight: ktd2801: Depend on GPIOLIB")
---
 drivers/video/backlight/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/backlight/Kconfig +1 -1
index 7c66b8840d88..dbf4ca23a9b6 100644
@@ -193,7 +193,7 @@ config BACKLIGHT_KTD253
 
 config BACKLIGHT_KTD2801
 	tristate "Backlight Driver for Kinetic KTD2801"
-	depends on GPIOLIB || COMPILE_TEST
+	depends on GPIOLIB
 	select LEDS_EXPRESSWIRE
 	help
 	  Say Y to enable the backlight driver for the Kinetic KTD2801 1-wire
Signature · 1 line
2.54.0
Tested-by Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 10 lines · Julian Braha

LEDS_EXPRESSWIRE depends on GPIOLIB, so its selector, BACKLIGHT_KTD2801 also needs to ensure GPIOLIB is enabled. Otherwise:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=n]
Selected by [y]:
- BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.

or it can be hand-crafted and the warning seen by 'make oldconfig' etc.

Quoted 11 lines
Fixes d95963e309bc ("backlight: ktd2801: Depend on GPIOLIB")
---
 drivers/video/backlight/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/backlight/Kconfig +0 -0
index 7c66b8840d88..dbf4ca23a9b6 100644

drivers/video/backlight/Kconfig config BACKLIGHT_KTD253 · line 199

Quoted 8 lines
drivers/video/backlight/Kconfig +1 -1
@@ -193,7 +193,7 @@ config BACKLIGHT_KTD253
 
 config BACKLIGHT_KTD2801
 	tristate "Backlight Driver for Kinetic KTD2801"
-	depends on GPIOLIB || COMPILE_TEST
+	depends on GPIOLIB
 	select LEDS_EXPRESSWIRE
 	help
 	  Say Y to enable the backlight driver for the Kinetic KTD2801 1-wire

Well, ktd2801.ko is being built for me with no warnings and I have:
COMPILE_TEST=y
GPIOLIB=n
BACKLIGHT_KTD2801=m

but we do want to eliminate the warning, so:

thanks.

Signature · 1 line
~Randy
Acked-by on v1 1/1
#2 lore raw
In reply to Julian Braha
Quoted 8 lines · On Sunday, 19 July 2026 04:49:02 Central European Summer Time Julian Braha…

LEDS_EXPRESSWIRE depends on GPIOLIB, so its selector, BACKLIGHT_KTD2801 also needs to ensure GPIOLIB is enabled. Otherwise:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=n]
Selected by [y]:
- BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

Quoted 5 lines

This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.

Fixes d95963e309bc ("backlight: ktd2801: Depend on GPIOLIB")

Regards,
--
Duje

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Julian Braha
Quoted 8 lines · Julian Braha

LEDS_EXPRESSWIRE depends on GPIOLIB, so its selector, BACKLIGHT_KTD2801 also needs to ensure GPIOLIB is enabled. Otherwise:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=n]
Selected by [y]:
- BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

Quoted 5 lines

This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.

Fixes d95963e309bc ("backlight: ktd2801: Depend on GPIOLIB")

Daniel.

maintainer Applied
#4 lore raw

Re: (subset) [PATCH] backlight: ktd2801: fix unmet dependency on GPIOLIB

In reply to Julian Braha
Quoted 9 lines · Julian Braha

LEDS_EXPRESSWIRE depends on GPIOLIB, so its selector, BACKLIGHT_KTD2801 also needs to ensure GPIOLIB is enabled. Otherwise:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=n]
Selected by [y]:
- BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y]

[...]

Applied, thanks!

[1/1] backlight: ktd2801: fix unmet dependency on GPIOLIB

      commit: 5859fa79c7d85d0c242a9a1ffb40bab9732d4ef1

--
Lee Jones [李琼斯]