review-tui: show no-reply preview for note-only reviews
PATCH 1/1 review-tui: show no-reply preview for note-only reviews
If a note is attached and nothing else is placed in the review then the email screen says:
No email to preview (missing message-id?).
Which sounds like an error, really there is no message to send so it should say:
No reply will be sent for this patch.
Remove note from the condition.
Assisted-by LLM
Signed-off-by Jason Gunthorpe <[email protected]>
--- src/b4/review_tui/_review_app.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
src/b4/review_tui/_review_app.py +1 -4
@@ -854,10 +854,7 @@ class ReviewApp(LoreNodeShutdownMixin, CheckRunnerMixin, App[None]): return if not review or not ( - review.get('trailers') - or review.get('reply', '') - or review.get('comments') - or review.get('note', '') + review.get('trailers') or review.get('reply', '') or review.get('comments') ): viewer.write('[dim]No reply will be sent for this patch.[/dim]') return
base-commit: 064bdaa79218f23790cf5792ed87f961e8681555
Signature · 1 line
2.43.0
Konstantin Ryabitsev
AppliedQuoted 1 line · Jason Gunthorpe
review-tui: show no-reply preview for note-only reviews
Applied, thanks!
[1/1] review-tui: show no-reply preview for note-only reviews
commit: db0b7456d0cd606f397e18fa0c589fc621fa57b5
Best regards,
Signature · 1 line
Konstantin Ryabitsev <[email protected]>