Skip to contentSkip to conversation

possible deadlock in hfsplus_file_truncate

syzbot syzbot 2 participants 4 messages Nov 26, 2022 – Jun 7, 2024 VFS

lore
Share & tools
lore

syzbot

author syzbot
#0 lore raw

Hello,

syzbot found the following issue on:

HEAD commit:    08ad43d554ba Merge tag 'net-6.1-rc7' of git://git.kernel.o..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11da779b880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=8d01b6e3197974dd
dashboard link: https://syzkaller.appspot.com/bug?extid=6030b3b1b9bf70e538c4
compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e40e255b7cf8/disk-08ad43d5.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/dfabe238c5ee/vmlinux-08ad43d5.xz
kernel image: https://storage.googleapis.com/syzbot-assets/2bcb24a7bbed/bzImage-08ad43d5.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by [email protected]

loop4: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected 6.1.0-rc6-syzkaller-00176-g08ad43d554ba #0 Not tainted
------------------------------------------------------
syz-executor.4/25725 is trying to acquire lock:
ffff888146b700b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595

but task is already holding lock:
ffff888029f69c08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:

       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       hfsplus_file_extend+0x1af/0x19d0 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x123/0x500 fs/hfsplus/btree.c:358
       hfsplus_create_cat+0x178/0xa20 fs/hfsplus/catalog.c:272
       hfsplus_fill_super+0x1379/0x1b50 fs/hfsplus/super.c:560
       mount_bdev+0x26c/0x3a0 fs/super.c:1401
       legacy_get_tree+0xea/0x180 fs/fs_context.c:610
       vfs_get_tree+0x88/0x270 fs/super.c:1531
       do_new_mount+0x289/0xad0 fs/namespace.c:3040
       do_mount fs/namespace.c:3383 [inline]
       __do_sys_mount fs/namespace.c:3591 [inline]
       __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3568
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&tree->tree_lock){+.+.}-{3:3}:

       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
       __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1b8/0x280 fs/hfsplus/inode.c:269
       notify_change+0xe38/0x10f0 fs/attr.c:420
       do_truncate+0x1fb/0x2e0 fs/open.c:65
       handle_truncate fs/namei.c:3216 [inline]
       do_open fs/namei.c:3561 [inline]
       path_openat+0x2770/0x2df0 fs/namei.c:3713
       do_filp_open+0x264/0x4f0 fs/namei.c:3740
       do_sys_openat2+0x124/0x4e0 fs/open.c:1310
       do_sys_open fs/open.c:1326 [inline]
       __do_sys_creat fs/open.c:1402 [inline]
       __se_sys_creat fs/open.c:1396 [inline]
       __x64_sys_creat+0x11f/0x160 fs/open.c:1396
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:
       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);

lock(&tree->tree_lock);

*** DEADLOCK ***

3 locks held by syz-executor.4/25725:
#0: ffff888146b76460 (sb_writers#29){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
#1: ffff888029f69e00 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff888029f69e00 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: do_truncate+0x1e7/0x2e0 fs/open.c:63
#2: ffff888029f69c08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

stack backtrace:
CPU: 0 PID: 25725 Comm: syz-executor.4 Not tainted 6.1.0-rc6-syzkaller-00176-g08ad43d554ba #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
 hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
 hfsplus_setattr+0x1b8/0x280 fs/hfsplus/inode.c:269
 notify_change+0xe38/0x10f0 fs/attr.c:420
 do_truncate+0x1fb/0x2e0 fs/open.c:65
 handle_truncate fs/namei.c:3216 [inline]
 do_open fs/namei.c:3561 [inline]
 path_openat+0x2770/0x2df0 fs/namei.c:3713
 do_filp_open+0x264/0x4f0 fs/namei.c:3740
 do_sys_openat2+0x124/0x4e0 fs/open.c:1310
 do_sys_open fs/open.c:1326 [inline]
 __do_sys_creat fs/open.c:1402 [inline]
 __se_sys_creat fs/open.c:1396 [inline]
 __x64_sys_creat+0x11f/0x160 fs/open.c:1396
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fe76648c0d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe767238168 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007fe7665abf80 RCX: 00007fe76648c0d9
RDX: 0000000000000000 RSI: 00000000000000b8 RDI: 0000000020000100
RBP: 00007fe7664e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffef191c68f R14: 00007fe767238300 R15: 0000000000022000
 </TASK>

---
This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

author syzbot
#1 lore raw
syzbot has found a reproducer for the following issue on:

syzbot has found a reproducer for the following issue on:

HEAD commit:    0ba09b173387 Revert "mm: align larger anonymous mappings o..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1517e983880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1
dashboard link: https://syzkaller.appspot.com/bug?extid=6030b3b1b9bf70e538c4
compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14b4d2cb880000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13d90fc3880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9758ec2c06f4/disk-0ba09b17.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/06781dbfd581/vmlinux-0ba09b17.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3d44a22d15fa/bzImage-0ba09b17.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/57266b2eb2c9/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/5f557bd13d34/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by [email protected]

loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected 6.1.0-rc7-syzkaller-00211-g0ba09b173387 #0 Not tainted
------------------------------------------------------
syz-executor955/3635 is trying to acquire lock:
ffff8880279780b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595

but task is already holding lock:
ffff8880189a3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:

       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       hfsplus_get_block+0x3a3/0x1560 fs/hfsplus/extents.c:260
       block_read_full_folio+0x3b3/0xfa0 fs/buffer.c:2271
       filemap_read_folio+0x187/0x7d0 mm/filemap.c:2407
       do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3534
       do_read_cache_page mm/filemap.c:3576 [inline]
       read_cache_page+0x56/0x270 mm/filemap.c:3585
       read_mapping_page include/linux/pagemap.h:756 [inline]
       __hfs_bnode_create+0x4d5/0x7f0 fs/hfsplus/bnode.c:440
       hfsplus_bnode_find+0x23d/0xd80 fs/hfsplus/bnode.c:486
       hfsplus_brec_find+0x145/0x520 fs/hfsplus/bfind.c:183
       hfsplus_brec_read+0x27/0x100 fs/hfsplus/bfind.c:222
       hfsplus_find_cat+0x168/0x6d0 fs/hfsplus/catalog.c:202
       hfsplus_iget+0x402/0x630 fs/hfsplus/super.c:82
       hfsplus_fill_super+0xc6a/0x1b50 fs/hfsplus/super.c:503
       mount_bdev+0x26c/0x3a0 fs/super.c:1401
       legacy_get_tree+0xea/0x180 fs/fs_context.c:610
       vfs_get_tree+0x88/0x270 fs/super.c:1531
       do_new_mount+0x289/0xad0 fs/namespace.c:3040
       do_mount fs/namespace.c:3383 [inline]
       __do_sys_mount fs/namespace.c:3591 [inline]
       __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3568
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&tree->tree_lock){+.+.}-{3:3}:

       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
       __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
       lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
       __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
       hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
       hfsplus_delete_inode+0x16d/0x210
       hfsplus_unlink+0x4e2/0x7d0 fs/hfsplus/dir.c:405
       hfsplus_rename+0xc3/0x1b0 fs/hfsplus/dir.c:547
       vfs_rename+0xd53/0x1130 fs/namei.c:4779
       do_renameat2+0xb53/0x1370 fs/namei.c:4930
       __do_sys_rename fs/namei.c:4976 [inline]
       __se_sys_rename fs/namei.c:4974 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:4974
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:
       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);

lock(&tree->tree_lock);

*** DEADLOCK ***

6 locks held by syz-executor955/3635:
#0: ffff888075a6c460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
#1: ffff8880189a2b80 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename+0x182/0x1a0
#2: ffff8880189a3240 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff8880189a3240 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_nondirectories+0xdd/0x130 fs/inode.c:1121 #3: ffff8880189a3900 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: vfs_rename+0x80a/0x1130 fs/namei.c:4749 #4: ffff888027abb198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x135/0x7d0 fs/hfsplus/dir.c:370
#5: ffff8880189a3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

stack backtrace:
CPU: 1 PID: 3635 Comm: syz-executor955 Not tainted 6.1.0-rc7-syzkaller-00211-g0ba09b173387 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
 check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
 lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
 __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
 hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
 hfsplus_delete_inode+0x16d/0x210
 hfsplus_unlink+0x4e2/0x7d0 fs/hfsplus/dir.c:405
 hfsplus_rename+0xc3/0x1b0 fs/hfsplus/dir.c:547
 vfs_rename+0xd53/0x1130 fs/namei.c:4779
 do_renameat2+0xb53/0x1370 fs/namei.c:4930
 __do_sys_rename fs/namei.c:4976 [inline]
 __se_sys_rename fs/namei.c:4974 [inline]
 __x64_sys_rename+0x82/0x90 fs/namei.c:4974
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f462a64f3f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f462a5da2f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f462a64f3f9
RDX: 0000000000000031 RSI: 00000000200001c0 RDI: 0000000020000180
RBP: 00007f462a6d4798 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000005fb R11: 0000000000000246 R12: 00007f462a6d4790
R13: 736f706d6f636564 R14: 0030656c69662f2e R15: 0073756c70736668
 </TASK>
#2 lore raw

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git misc

Quoted 149 lines · syzbot

syzbot has found a reproducer for the following issue on:

HEAD commit:    0ba09b173387 Revert "mm: align larger anonymous mappings o..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1517e983880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1
dashboard link: https://syzkaller.appspot.com/bug?extid=6030b3b1b9bf70e538c4
compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14b4d2cb880000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13d90fc3880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9758ec2c06f4/disk-0ba09b17.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/06781dbfd581/vmlinux-0ba09b17.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3d44a22d15fa/bzImage-0ba09b17.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/57266b2eb2c9/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/5f557bd13d34/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by [email protected]

loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected 6.1.0-rc7-syzkaller-00211-g0ba09b173387 #0 Not tainted
------------------------------------------------------
syz-executor955/3635 is trying to acquire lock:
ffff8880279780b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595

but task is already holding lock:
ffff8880189a3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:

        lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
        __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
        __mutex_lock kernel/locking/mutex.c:747 [inline]
        mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
        hfsplus_get_block+0x3a3/0x1560 fs/hfsplus/extents.c:260
        block_read_full_folio+0x3b3/0xfa0 fs/buffer.c:2271
        filemap_read_folio+0x187/0x7d0 mm/filemap.c:2407
        do_read_cache_folio+0x2d3/0x790 mm/filemap.c:3534
        do_read_cache_page mm/filemap.c:3576 [inline]
        read_cache_page+0x56/0x270 mm/filemap.c:3585
        read_mapping_page include/linux/pagemap.h:756 [inline]
        __hfs_bnode_create+0x4d5/0x7f0 fs/hfsplus/bnode.c:440
        hfsplus_bnode_find+0x23d/0xd80 fs/hfsplus/bnode.c:486
        hfsplus_brec_find+0x145/0x520 fs/hfsplus/bfind.c:183
        hfsplus_brec_read+0x27/0x100 fs/hfsplus/bfind.c:222
        hfsplus_find_cat+0x168/0x6d0 fs/hfsplus/catalog.c:202
        hfsplus_iget+0x402/0x630 fs/hfsplus/super.c:82
        hfsplus_fill_super+0xc6a/0x1b50 fs/hfsplus/super.c:503
        mount_bdev+0x26c/0x3a0 fs/super.c:1401
        legacy_get_tree+0xea/0x180 fs/fs_context.c:610
        vfs_get_tree+0x88/0x270 fs/super.c:1531
        do_new_mount+0x289/0xad0 fs/namespace.c:3040
        do_mount fs/namespace.c:3383 [inline]
        __do_sys_mount fs/namespace.c:3591 [inline]
        __se_sys_mount+0x2d3/0x3c0 fs/namespace.c:3568
        do_syscall_x64 arch/x86/entry/common.c:50 [inline]
        do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
        entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&tree->tree_lock){+.+.}-{3:3}:

        check_prev_add kernel/locking/lockdep.c:3097 [inline]
        check_prevs_add kernel/locking/lockdep.c:3216 [inline]
        validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
        __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
        lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
        __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
        __mutex_lock kernel/locking/mutex.c:747 [inline]
        mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
        hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
        hfsplus_delete_inode+0x16d/0x210
        hfsplus_unlink+0x4e2/0x7d0 fs/hfsplus/dir.c:405
        hfsplus_rename+0xc3/0x1b0 fs/hfsplus/dir.c:547
        vfs_rename+0xd53/0x1130 fs/namei.c:4779
        do_renameat2+0xb53/0x1370 fs/namei.c:4930
        __do_sys_rename fs/namei.c:4976 [inline]
        __se_sys_rename fs/namei.c:4974 [inline]
        __x64_sys_rename+0x82/0x90 fs/namei.c:4974
        do_syscall_x64 arch/x86/entry/common.c:50 [inline]
        do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
        entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

  Possible unsafe locking scenario:
        CPU0                    CPU1
        ----                    ----
   lock(&HFSPLUS_I(inode)->extents_lock);
                                lock(&tree->tree_lock);
                                lock(&HFSPLUS_I(inode)->extents_lock);

lock(&tree->tree_lock);

*** DEADLOCK ***

6 locks held by syz-executor955/3635:
#0: ffff888075a6c460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
#1: ffff8880189a2b80 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename+0x182/0x1a0
#2: ffff8880189a3240 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff8880189a3240 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: lock_two_nondirectories+0xdd/0x130 fs/inode.c:1121 #3: ffff8880189a3900 (&sb->s_type->i_mutex_key#15/4){+.+.}-{3:3}, at: vfs_rename+0x80a/0x1130 fs/namei.c:4749 #4: ffff888027abb198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x135/0x7d0 fs/hfsplus/dir.c:370
#5: ffff8880189a3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x280/0xbb0 fs/hfsplus/extents.c:576

stack backtrace:
CPU: 1 PID: 3635 Comm: syz-executor955 Not tainted 6.1.0-rc7-syzkaller-00211-g0ba09b173387 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
  <TASK>
  __dump_stack lib/dump_stack.c:88 [inline]
  dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
  check_noncircular+0x2cc/0x390 kernel/locking/lockdep.c:2177
  check_prev_add kernel/locking/lockdep.c:3097 [inline]
  check_prevs_add kernel/locking/lockdep.c:3216 [inline]
  validate_chain+0x1898/0x6ae0 kernel/locking/lockdep.c:3831
  __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5055
  lock_acquire+0x182/0x3c0 kernel/locking/lockdep.c:5668
  __mutex_lock_common+0x1bd/0x26e0 kernel/locking/mutex.c:603
  __mutex_lock kernel/locking/mutex.c:747 [inline]
  mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
  hfsplus_file_truncate+0x871/0xbb0 fs/hfsplus/extents.c:595
  hfsplus_delete_inode+0x16d/0x210
  hfsplus_unlink+0x4e2/0x7d0 fs/hfsplus/dir.c:405
  hfsplus_rename+0xc3/0x1b0 fs/hfsplus/dir.c:547
  vfs_rename+0xd53/0x1130 fs/namei.c:4779
  do_renameat2+0xb53/0x1370 fs/namei.c:4930
  __do_sys_rename fs/namei.c:4976 [inline]
  __se_sys_rename fs/namei.c:4974 [inline]
  __x64_sys_rename+0x82/0x90 fs/namei.c:4974
  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
  do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
  entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f462a64f3f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f462a5da2f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f462a64f3f9
RDX: 0000000000000031 RSI: 00000000200001c0 RDI: 0000000020000180
RBP: 00007f462a6d4798 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000005fb R11: 0000000000000246 R12: 00007f462a6d4790
R13: 736f706d6f636564 R14: 0030656c69662f2e R15: 0073756c70736668
  </TASK>
author syzbot
#3 lore raw
syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by [email protected]

Tested on:

commit:         9012da7c hfsplus: fix to avoid false alarm of circular..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git misc
console output: https://syzkaller.appspot.com/x/log.txt?x=17244a6a980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6be91306a8917025
dashboard link: https://syzkaller.appspot.com/bug?extid=6030b3b1b9bf70e538c4
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.
Note: testing is done by a robot and is best-effort only.