Skip to contentSkip to conversation

Build failure with ltp-2009-12-08 cvs

LTP Mitani 2 participants 5 messages Dec 8, 2009 – Dec 11, 2009

lore
Share & tools
lore

Mitani

author Applied
#0 lore raw

Hi,

I tried to "make" with "ltp-2009-12-08.tar.gz" version in RHEL4.8 (kernel 2.6.9-89.ELsmp) and x86 architecture.

But it failed by following message:

------------
make[4]: Entering directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/LTP/ltp-2009-12-08/testcases/kernel/include -I/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils
-I../../../../include -I../../../../include -L../../../../lib
get_mempolicy01.c -lltp -lnuma -o get_mempolicy01
In file included from get_mempolicy01.c:58:
/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils/nu maif.h:88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' make[3]: *** [all] Error 2
------------

For reference, "make" succeeded in my following systems:
- RHEL5.4 (kernel 2.6.18-164.el5) and x86 architecture
- RHEL5.4 (kernel 2.6.18-164.el5) and x86_64 architecture

"nodemask_set" is the structure whitch defined in following two header files:
(a) "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h"
(b) "/usr/include/numa.h"

In "numaif.h" file, definition is as follows:

------------
#if HAVE_NUMA_H
#include <numa.h>
#else /* The following symbols clash with the numa.h ones. */

typedef struct {
        unsigned long n[NUMA_NUM_NODES/(sizeof(unsigned long)*8)];
} nodemask_t;

[...]

#endif

static inline void nodemask_dump(const char *header, const nodemask_t *mask)

{
        int i;
        EPRINTF("%s", header);
        for (i = 0; i < NUMA_NUM_NODES/(sizeof(unsigned long)*8); i++)
                EPRINTF(" 0x%08lx", mask->n[i]);
        EPRINTF("\n");
}

static inline void nodemask_set(nodemask_t *mask, int node)

{
        mask->n[node / (8*sizeof(unsigned long))] |=
                (1UL << (node % (8*sizeof(unsigned long))));
}

------------

In above definition, "nodemask_set" structure is always defined whether "HAVE_NUMA_H" is defined.
If "HAVE_NUMA_H" was defined, <numa.h> which defines "nodemask_set" structure is included.
Therefore, "nodemask_set" is defined twice when "HAVE_NUMA_H" is defined.

I think that "nodemask_set" definition of "numaif.h" must be in "#if HAVE_NUMA_H" block.

I applied following patch, and succeeded to "make".

============

numaif.h 2009-12-08 10:25:09.000000000 +0900 renamed from numaif.h.org 2009-11-13 05:30:36.000000000 +0900 +6 -0
@@ -73,6 +73,12 @@
                        return 0;
        return 1;
 }
+
+static inline void nodemask_set(nodemask_t *mask, int node)
+{
+       mask->n[node / (8*sizeof(unsigned long))] |=
+               (1UL << (node % (8*sizeof(unsigned long))));
+}
 #endif
 
 static inline void nodemask_dump(const char *header, const nodemask_t

*mask)
@@ -84,12 +90,6 @@

        EPRINTF("\n");

}

-static inline void nodemask_set(nodemask_t *mask, int node) -{
- mask->n[node / (8*sizeof(unsigned long))] |=
- (1UL << (node % (8*sizeof(unsigned long))));
-}
-

 #ifndef MPOL_DEFAULT
    // Policies

# define MPOL_DEFAULT 0
============

I'm glad if I can get opinion that my revision is right or not.

Thank you--

-Tomonori Mitani

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 32 lines · Mitani

Hi,

I tried to "make" with "ltp-2009-12-08.tar.gz" version in RHEL4.8 (kernel 2.6.9-89.ELsmp) and x86 architecture.

But it failed by following message:

------------
make[4]: Entering directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall

(quoted diff) +0 -3
-I/home/LTP/ltp-2009-12-08/testcases/kernel/include
-I/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils
-I../../../../include -I../../../../include   -L../../../../lib

get_mempolicy01.c   -lltp -lnuma -o get_mempolicy01
In file included from get_mempolicy01.c:58:
/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils/nu maif.h:88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' make[3]: *** [all] Error 2
------------

For reference, "make" succeeded in my following systems:
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86 architecture
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86_64 architecture

Quoted 6 lines

"nodemask_set" is the structure whitch defined in following two header files:
 (a) "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h"
 (b) "/usr/include/numa.h"

In "numaif.h" file, definition is as follows:

Mitani-san,
This issue keeps on coming back to haunt us. Can you tell me what
the Fedora Core equivalent of RHEL 4.8 is so I can isolate and resolve the issue?
Thanks,
-Garrett

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#2 lore raw

RHEL4.8's kernel version is 2.6.9-89.ELsmp.
Fedora 3 has kernel 2.6.9-1.667.

But Fedora3 and RHEL4.8 diverged halfway, and now they seem to be different each other.

If you want some other informations, I offer them.

I heard that CentOS4.8 had kernel of the version same as RHEL4.8.

Thank you--

-Tomonori Mitani

-----Original Message-----
From: Garrett Cooper [mailto:[email protected]]
Sent: Wednesday, December 09, 2009 2:07 PM
To: Mitani
Cc: [email protected]
Subject: Re: [LTP] Build failure with ltp-2009-12-08 cvs

Quoted 6 lines · Mitani

Hi,

I tried to "make" with "ltp-2009-12-08.tar.gz" version in RHEL4.8 (kernel 2.6.9-89.ELsmp) and x86 architecture.

Quoted 8 lines

But it failed by following message:

------------
make[4]: Entering directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/LTP/ltp-2009-12-08/testcases/kernel/include

-I/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils

Quoted 4 lines

-I../../../../include -I../../../../include   -L../../../../lib get_mempolicy01.c   -lltp -lnuma -o get_mempolicy01 In file included from get_mempolicy01.c:58:

/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils/nu

Quoted 14 lines

maif.h:88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' make[3]: *** [all] Error 2
------------

For reference, "make" succeeded in my following systems:
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86 architecture
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86_64 architecture

Quoted 6 lines

"nodemask_set" is the structure whitch defined in following two header files:
 (a) "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h"
 (b) "/usr/include/numa.h"

In "numaif.h" file, definition is as follows:

Mitani-san,
This issue keeps on coming back to haunt us. Can you tell me what
the Fedora Core equivalent of RHEL 4.8 is so I can isolate and resolve the issue?
Thanks,
-Garrett

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 63 lines · Mitani

RHEL4.8's kernel version is 2.6.9-89.ELsmp.
Fedora 3 has kernel 2.6.9-1.667.

But Fedora3 and RHEL4.8 diverged halfway, and now they seem to be different each other.

If you want some other informations, I offer them.

I heard that CentOS4.8 had kernel of the version same as RHEL4.8.

Thank you--

-Tomonori Mitani

-----Original Message-----
From: Garrett Cooper [mailto:[email protected]]
Sent: Wednesday, December 09, 2009 2:07 PM
To: Mitani
Cc: [email protected]
Subject: Re: [LTP] Build failure with ltp-2009-12-08 cvs

Quoted 6 lines · Mitani

Hi,

I tried to "make" with "ltp-2009-12-08.tar.gz" version in RHEL4.8 (kernel 2.6.9-89.ELsmp) and x86 architecture.

Quoted 8 lines

But it failed by following message:

------------
make[4]: Entering directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/LTP/ltp-2009-12-08/testcases/kernel/include

-I/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils

Quoted 4 lines

-I../../../../include -I../../../../include -L../../../../lib
get_mempolicy01.c -lltp -lnuma -o get_mempolicy01
In file included from get_mempolicy01.c:58:

/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils/nu

Quoted 19 lines

maif.h:88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' make[3]: *** [all] Error 2
------------

For reference, "make" succeeded in my following systems:
- RHEL5.4 (kernel 2.6.18-164.el5) and x86 architecture
- RHEL5.4 (kernel 2.6.18-164.el5) and x86_64 architecture

"nodemask_set" is the structure whitch defined in following two header files:
(a) "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h"
(b) "/usr/include/numa.h"

Quoted 6 lines
Quoted 1 line

In "numaif.h" file, definition is as follows:

Mitani-san,
This issue keeps on coming back to haunt us. Can you tell me what
the Fedora Core equivalent of RHEL 4.8 is so I can isolate and resolve the issue?

Ok, finally fixed. The problem was that you have a version 1 copy of numa.h, and the newer headers don't have that that definition out of the box.
Thanks,
-Garrett
------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#4 lore raw
In reply to Garrett Cooper

Hi,

I tried to let RHEL4.8's failure reappear in the other OS.

I obtained CentOS4.8 and installed it in my machine. CentOS4.8 has same version kernel as RHEL4.8(kernel 2.6.9-89.ELsmp).

I tried to "make" with "ltp-2009-12-08.tar.gz" version in CentOS4.8. And I succeeded to let RHEL4.8's failure reappear:

------------
make[4]: Entering directory `/home/mitani/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get _mempolicy'
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/mitani/LTP/ltp-2009-12-08/test
cases/kernel/include -I/home/mitani/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempo licy/../utils -I../../../../include -I../../../../include -L../../../../lib get_mempoli
cy01.c -lltp -lnuma -o get_mempolicy01
In file included from get_mempolicy01.c:58:
/home/mitani/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../u tils/numaif.h:
88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/mitani/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_ mempolicy'
make[3]: *** [all] Error 2
------------

I confirmed that this error message is the same one that happened in RHEL4.8.

After that, I revised "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h" file.
Then, "make" succeeded.

Does this information help you?

Regards--

-Tomonori Mitani

-----Original Message-----
From: Garrett Cooper [mailto:[email protected]]
Sent: Wednesday, December 09, 2009 2:07 PM
To: Mitani
Cc: [email protected]
Subject: Re: [LTP] Build failure with ltp-2009-12-08 cvs

Quoted 6 lines · Mitani

Hi,

I tried to "make" with "ltp-2009-12-08.tar.gz" version in RHEL4.8 (kernel 2.6.9-89.ELsmp) and x86 architecture.

Quoted 8 lines

But it failed by following message:

------------
make[4]: Entering directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/LTP/ltp-2009-12-08/testcases/kernel/include

-I/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils

Quoted 4 lines

-I../../../../include -I../../../../include   -L../../../../lib get_mempolicy01.c   -lltp -lnuma -o get_mempolicy01 In file included from get_mempolicy01.c:58:

/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy/../utils/nu

Quoted 14 lines

maif.h:88: error: redefinition of 'nodemask_set' /usr/include/numa.h:45: error: previous definition of 'nodemask_set' was here
make[4]: *** [get_mempolicy01] Error 1
make[4]: Leaving directory `/home/LTP/ltp-2009-12-08/testcases/kernel/syscalls/get_mempolicy' make[3]: *** [all] Error 2
------------

For reference, "make" succeeded in my following systems:
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86 architecture
 - RHEL5.4 (kernel 2.6.18-164.el5) and x86_64 architecture

Quoted 6 lines

"nodemask_set" is the structure whitch defined in following two header files:
 (a) "${LTPROOT}/testcases/kernel/syscalls/utils/numaif.h"
 (b) "/usr/include/numa.h"

In "numaif.h" file, definition is as follows:

Mitani-san,
This issue keeps on coming back to haunt us. Can you tell me what
the Fedora Core equivalent of RHEL 4.8 is so I can isolate and resolve the issue?
Thanks,
-Garrett

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list